Re: [PATCH v5 06/13] ARM: dts: imx6ul: Extend VAR-SOM-6UL and add DART-6UL files

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: net: micrel: boolean property assigned integer value <1>
--

commit 7e70ac71fa47849af4ee0ecb85b6da2be68dfac5
Author: Stefano Radaelli <stefano.r@variscite.com>

ARM: dts: imx6ul: Extend VAR-SOM-6UL and add DART-6UL files

Add the DART-6UL module description and wrappers for i.MX6UL,
i.MX6ULL and i.MX6ULZ, plus an i.MX6ULZ wrapper for VAR-SOM-6UL.

> diff --git a/arch/arm/boot/dts/nxp/imx/imx6ul-imx6ull-var-dart.dtsi b/arch/arm/boot/dts/nxp/imx/imx6ul-imx6ull-var-dart.dtsi
> new file mode 100644
> index 0000000000000..f7190f6d50b59
> --- /dev/null
> +++ b/arch/arm/boot/dts/nxp/imx/imx6ul-imx6ull-var-dart.dtsi

[ ... ]

> +&fec1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_enet1>, <&pinctrl_enet1_gpio>, <&pinctrl_enet1_mdio>;
> +	phy-mode = "rmii";
> +	phy-handle = <&ethphy0>;
> +	status = "okay";
> +
> +	mdio {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		ethphy0: ethernet-phy@1 {
> +			compatible = "ethernet-phy-ieee802.3-c22";
> +			reg = <1>;
> +			clocks = <&rmii_ref_clk>;
> +			clock-names = "rmii-ref";
> +			reset-gpios = <&gpio5 0 GPIO_ACTIVE_LOW>;
> +			reset-assert-us = <10000>;
> +			reset-deassert-us = <100000>;
> +			micrel,rmii-reference-clock-select-25-mhz = <1>;

[Severity: Low]
Does this assignment cause a dtbs_check schema violation?

The micrel,rmii-reference-clock-select-25-mhz property is defined as a boolean
in the dt-binding schema. Assigning it an integer value like <1> will trigger
a warning during Device Tree compile validation.

Could this be specified simply by its presence without an assigned value,
such as: micrel,rmii-reference-clock-select-25-mhz; ?

> +			micrel,led-mode = <1>;
> +		};
> +	};
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1791487179.git.stefano.r@variscite.com?part=6