Re: [PATCH 2/3] serial: 8250_omap: set priv->line before enabling the IRQ

[sashiko-bot@kernel.org]

> omap8250_irq() is requested in omap8250_probe() with IRQ_NOAUTOEN and
> enabled only in omap_8250_startup(). The handler obtains the port by
> serial8250_get_port(priv->line), but probe stores priv->line only after
> serial8250_register_8250_port() returns.
> 
> The port becomes visible to userspace already inside
> serial8250_register_8250_port() (uart_add_one_port()). So it can be
> opened -- and the IRQ enabled -- before probe stores the line. An
> interrupt in that window makes the handler call
> serial8250_get_port(-ENODEV) and dereference a pointer outside of
> serial8250_ports[].
> 
> Store the line in omap_8250_startup() before enable_irq(), so the
> handler never runs with an unset line. Keep the assignment in probe
> too, as remove and the system PM callbacks rely on it even when the
> port was never opened.
> 
> Fixes: fef4f600319e ("serial: 8250: omap: Fix life cycle issues for interrupt handlers")
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/ef47d676a44346e058f29a00c8701484db722831.1791524724.git.jirislaby@kernel.org?part=2