From: sashiko-bot@kernel.org
To: "Bertrand Jacquin" <bertrand@jacquin.bzh>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: typec: ucsi: Fix NULL pointer dereference in power level debugfs
Date: Sat, 10 Oct 2026 11:17:05 +0000 [thread overview]
Message-ID: <sashiko-outbox-166463@kernel.org> (raw)
In-Reply-To: <20261010120357.4937-1-bertrand@jacquin.bzh>
> ucsi_register() creates the debugfs entries right away, but
> ucsi->connector is only set by ucsi_init(), which runs later from
> ucsi->work and only publishes the connectors once the PPM has been
> reset and all ports are registered. Until then, or for good if init
> fails, ucsi->connector is NULL, yet the peak_current, avg_current and
> vbus_voltage show callbacks dereference it unconditionally.
>
> On an Intel NUC13ANKi5 whose PPM never answers when CONFIG_ACPI_EC=n,
> reading those files after the failed init oopses:
>
> ucsi_acpi USBC000:00: error -ETIMEDOUT: PPM init failed
> BUG: kernel NULL pointer dereference, address: 000000000000045c
> #PF: supervisor read access in kernel mode
> RIP: 0010:ucsi_debugfs_register+0x291/0x420 [typec_ucsi]
> Call Trace:
> <TASK>
> seq_read_iter+0x1e4/0x4c0
> seq_read+0x12b/0x160
> full_proxy_read+0x9a/0x1f0
> vfs_read+0xba/0x320
> ksys_read+0x74/0x110
> do_syscall_64+0x79/0x240
> entry_SYSCALL_64_after_hwframe+0x71/0x79
>
> Return -ENODEV from those callbacks while no connector is available.
>
> Fixes: c851b71fd6cd ("usb: typec: ucsi: Add support for READ_POWER_LEVEL command")
> Cc: stable@vger.kernel.org
> Signed-off-by: Bertrand Jacquin <bertrand@jacquin.bzh>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261010120357.4937-1-bertrand@jacquin.bzh?part=1
next prev parent reply other threads:[~2026-10-10 11:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-10 12:03 [PATCH] usb: typec: ucsi: Fix NULL pointer dereference in power level debugfs Bertrand Jacquin
2026-10-10 11:17 ` sashiko-bot [this message]
2026-10-12 3:16 ` Huang Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-166463@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=bertrand@jacquin.bzh \
--cc=linux-usb@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.