From: sashiko-bot@kernel.org
To: "Linfeng Sun" <linfeng.sun.dev@gmail.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
virtualization@lists.linux.dev,
"Eugenio Perez" <eperezma@redhat.com>
Subject: Re: [PATCH v3] vhost-scsi: reject delayed virtqueue setup
Date: Sat, 10 Oct 2026 12:37:18 +0000 [thread overview]
Message-ID: <sashiko-outbox-166540@kernel.org> (raw)
In-Reply-To: <20261010-fix-warning-in-sbitmap_get-v3-1-33de562d1359@gmail.com>
> From: Linfeng Sun <linfeng.sun.dev@gmail.com>
>
> vhost_scsi_set_endpoint() allocates command pools only for I/O
> virtqueues that are already set up, but publishes the backend for every
> virtqueue. Userspace can complete a skipped queue after attaching the
> endpoint, then kick it with scsi_tags uninitialized and trigger the
> alloc_hint warning in sbitmap_get().
>
> Delayed virtqueue setup is not supported. Leave skipped I/O virtqueues
> inactive and reject changes to the vring size or addresses while an
> endpoint is attached. Userspace must clear the endpoint before changing
> the vring configuration.
>
> I found this bug myself, though the patch was written with AI assistance.
>
> Fixes: 25b98b64e284 ("vhost scsi: alloc cmds per vq instead of session")
> Assisted-by: OpenAI-Codex:GPT-5.6
> Signed-off-by: Linfeng Sun <linfeng.sun.dev@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261010-fix-warning-in-sbitmap_get-v3-1-33de562d1359@gmail.com?part=1
prev parent reply other threads:[~2026-10-10 12:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-10 12:22 [PATCH v3] vhost-scsi: reject delayed virtqueue setup Linfeng Sun
2026-10-10 12:22 ` Linfeng Sun via B4 Relay
2026-10-10 12:37 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-166540@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=eperezma@redhat.com \
--cc=linfeng.sun.dev@gmail.com \
--cc=mst@redhat.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.