Re: [PATCH net-next v1 1/5] net: enetc: Add pseudo-MAC support for ENETCv4 Ports via a DT overlay

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] net: enetc: memory leak of partially applied overlay on of_overlay_fdt_apply() error
--

commit 8ec35cbb99007d6ea94d2243308ce4530bb6180d
Author: Claudiu Manoil <claudiu.manoil@nxp.com>

net: enetc: Add pseudo-MAC support for ENETCv4 Ports via a DT overlay

This commit introduces pseudo-MAC support for ENETCv4 ports by modeling
them as fixed links. It uses a compiled device-tree overlay to synthesize
the fixed-link node at probe time when the port lacks an ethernet DT node
representation.

> diff --git a/drivers/net/ethernet/freescale/enetc/enetc4_pf.c b/drivers/net/ethernet/freescale/enetc/enetc4_pf.c
> index 71c971618388b..7999355b5b9f5 100644
> --- a/drivers/net/ethernet/freescale/enetc/enetc4_pf.c
> +++ b/drivers/net/ethernet/freescale/enetc/enetc4_pf.c
[ ... ]
> +static int enetc4_apply_overlay(struct enetc_ndev_priv *priv)
> +{
> +	u32 size = __dtbo_enetc4_pseudo_mac_end - __dtbo_enetc4_pseudo_mac_begin;
> +	struct device_node *np = dev_of_node(priv->dev);
> +	int err;
> +
> +	if (!np)
> +		return dev_err_probe(priv->dev, -ENODEV,
> +				     "Missing of_node for Pseudo-MAC port\n");
> +
> +	err = of_overlay_fdt_apply(__dtbo_enetc4_pseudo_mac_begin, size,
> +				   &priv->ovcs_id, np);
> +	if (err)
> +		return dev_err_probe(priv->dev, err,
> +				     "Failed to apply fixed-link overlay\n");

[Severity: Medium]
Can this leak the partially applied overlay changeset?

If of_overlay_fdt_apply() fails during application (for example, from a
post-apply notifier returning an error), it can return a negative error
code but still populate the changeset ID in priv->ovcs_id. Returning
immediately here without calling enetc4_put_overlay() bypasses cleaning up
the partially applied state.

Looking at the caller enetc4_link_init():

	err = enetc4_apply_overlay(priv);
	if (err)
		return err;

The error propagates directly and skips the err_mdiobus_create label
which would otherwise invoke enetc4_put_overlay() to handle the cleanup.

> +
> +	return 0;
> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1791548316.git.claudiu.manoil@nxp.com?part=1