Re: [PATCH bpf-next v6 4/7] libbpf: Support declarative manual load via SEC("!...") prefix

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] bpf: multi-line comment style violation in bpf_object__init_prog()
--

commit b80dd28fdb1bbcbf64f3eb8617664b84a1b0b738
Author: Andrey Grodzovsky <andrey.grodzovsky@crowdstrike.com>

libbpf: Support declarative manual load via SEC("!...") prefix

This commit adds a SEC("!...") section-name prefix, allowing a program to
declare itself manually loaded. It builds upon the existing SEC("?...")
convention and skips the bulk auto-load pass.

> diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
> index 42fb687a97954..043f220ebb136 100644
> --- a/tools/lib/bpf/libbpf.c
> +++ b/tools/lib/bpf/libbpf.c
> @@ -968,11 +968,19 @@ bpf_object__init_prog(struct bpf_object *obj, struct bpf_program *prog,
>  	/* libbpf's convention for SEC("?abc...") is that it's just like
>  	 * SEC("abc...") but the corresponding bpf_program starts out with
>  	 * autoload set to false.
> +	 *
> +	 * Similarly, SEC("!abc...") marks the program for manual loading:
> +	 * it is skipped by the bulk auto-load pass and must be explicitly
> +	 * loaded via bpf_program__load().
>  	 */

[Severity: Low]
This isn't a bug, but the BPF subsystem multi-line comment style guidelines
require the opening /* to be on its own line.

Since this patch extends the multi-line comment in bpf_object__init_prog()
in tools/lib/bpf/libbpf.c, could the opening of the comment be updated to
match the preferred style?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261010143156.379864-1-andrey.grodzovsky@crowdstrike.com?part=4