From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A067DCA9EC1 for ; Sat, 10 Oct 2026 16:25:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CVJ2CZVa65irme40RyLhdsA2srAC422vnnIgJ89Bbug=; b=3dBfXFv2lhLxRZ voJEC/+zs8+PKOl5vUEBkyurcXtpC7VhY0PaYlK0DHC52Tj1hLT5DPHOJt/h+u+X7N7TPjDA9kk5v oMQnFXCylEd8ugyocPNGw9Dp9PX/6Hl3bFfJkGNhDEmP7+gydMdJelHvnGPrOOYEZDAUB+0WQs8CJ GoUEewKdPPIMkumYHgJFdfEBZ6IBHCpo6Uc/jysInbfI0xjLaG/Ku6GGoKUpb7iTt6ejRIFdk7hXq LGCJbOJwgxF3EH94G/8uesMKuPK/m+p/QDG1sOJqKM3++yGVov3DVZGe7fSKiw4Lkn0Vv8FkG1fs9 T76g/4fqQUlsKUs1Cm8Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xFZtW-00000008GoF-1Ncq; Sat, 10 Oct 2026 16:25:58 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xFZtR-00000008Gnu-0NoP for linux-phy@lists.infradead.org; Sat, 10 Oct 2026 16:25:56 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 7BC2343448; Sat, 10 Oct 2026 16:25:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7C011F000FF; Sat, 10 Oct 2026 16:25:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791649552; bh=9BQoPNpg/BuzHBZB4mO3d/+THaNd9C2XTiHsMc60QaY=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=CtAKnH5tK5prTd7sikrq+hsrzJFXD4KQPW8uWMIXGIAR+0YktZqvH+qX6hknBIWL3 XwdAvvi4Yz9C8YvxWFM2Wnce1RDYVXUEMboz9zLe2WIV5pl2loQJhAK0KJRukLL6Y/ FnUox1zaibUQQ8RCZ3hWjqqP3Im8FR8g3efqF6xWqmnfF9M2VeqXLDGLtgkUh1W2BO jf6qph7SQAeyA9KqDuWkgMAqQv8YRDdHb4Z3yeflBJHE6W0NJyHVnwiSEj9/WoSXl5 dY/Ud52M7Rg/9xx3qF6N1Kl+SsIzvrEJo+Z5SrEK1PGEnEVMqli87CaX7+h8kHFgWa S5bdLBUCx3gDw== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v20 08/13] media: qcom: camss: vfe: Add support for VFE 1080 To: "Hangxiang Ma" Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, olteanv@gmail.com, vkoul@kernel.org, neil.armstrong@linaro.org, linux-phy@lists.infradead.org, robh@kernel.org, media-ci@linuxtv.org In-Reply-To: <20261010-kaanapali-camss-v20-8-63e98ce9ac0c@oss.qualcomm.com> References: <20261010-kaanapali-camss-v20-0-63e98ce9ac0c@oss.qualcomm.com> <20261010-kaanapali-camss-v20-8-63e98ce9ac0c@oss.qualcomm.com> Date: Sat, 10 Oct 2026 16:25:51 +0000 X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MyBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIG1lZGlhOiB2ZmU6IEFV UF9VUERBVEUgbWlzbWF0Y2ggZHVyaW5nIHN0cmVhbSBlbmFibGUgdmlvbGF0ZXMgaGFyZHdhcmUg Y29uc3RyYWludAotIFtIaWdoXSBtZWRpYTogY3NpZDogbG9ja2xlc3MgcmVhZC1tb2RpZnktd3Jp dGUgcmFjZSBvbiBjc2lkLT5hdXBfdXBkYXRlIGZyb20gcHJvY2VzcyBhbmQgaGFyZGlycQotIFtN ZWRpdW1dIG1lZGlhOiB2ZmU6IGhhcmRjb2RlZCB2ZmUtPmlkIG1hcHBpbmcgYnJlYWtzIE1lZGlh IENvbnRyb2xsZXIgY3Jvc3Mtcm91dGluZwotLQoKY29tbWl0IGQ2ZjA5YjJkMzUyMjBiZjFmOTE4 NzNmNjY1ZTJkZTcwMTk2YzJlODMKQXV0aG9yOiBIYW5neGlhbmcgTWEgPGhhbmd4aWFuZy5tYUBv c3MucXVhbGNvbW0uY29tPgoKbWVkaWE6IHFjb206IGNhbXNzOiB2ZmU6IEFkZCBzdXBwb3J0IGZv ciBWRkUgMTA4MAoKQWRkIHN1cHBvcnQgZm9yIHRoZSBWRkUgKFZpZGVvIEZyb250IEVuZCkgMTA4 MCBmb3VuZCBvbiBLYWFuYXBhbGkgU29DLgpUaGUgZHJpdmVyIGNvbnRpbnVlcyB0byB1c2UgVkZF IG5hbWluZywgYW5kIEthYW5hcGFsaSByZXF1aXJlcyBSRUdfVVBEQVRFCmFuZCBBVVBfVVBEQVRF IHRvIGJlIGlzc3VlZCBvbmx5IGFmdGVyIENTSUQgY29uZmlndXJhdGlvbi4KCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vcWNvbS9jYW1zcy9jYW1zcy12ZmUtMTA4MC5jIGIv ZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9xY29tL2NhbXNzL2NhbXNzLXZmZS0xMDgwLmMKPiBuZXcg ZmlsZSBtb2RlIDEwMDY0NAo+IGluZGV4IDAwMDAwMDAwMDAwMDAuLjAxNjg1N2NkMTAyNTEKPiAt LS0gL2Rldi9udWxsCj4gKysrIGIvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9xY29tL2NhbXNzL2Nh bXNzLXZmZS0xMDgwLmMKClsgLi4uIF0KCj4gK3N0YXRpYyB2b2lkIHZmZV9yZWdfdXBkYXRlKHN0 cnVjdCB2ZmVfZGV2aWNlICp2ZmUsIGVudW0gdmZlX2xpbmVfaWQgbGluZV9pZCkKPiArewo+ICsJ aW50IHBvcnRfaWQgPSBsaW5lX2lkOwo+ICsKPiArCWNhbXNzX3JlZ191cGRhdGUodmZlLT5jYW1z cywgdmZlLT5pZCwgcG9ydF9pZCwgZmFsc2UpOwo+ICt9CgpbU2V2ZXJpdHk6IE1lZGl1bV0KVGhl IENBTVNTIGRyaXZlciBmcmFtZXdvcmsgYWxsb3dzIGZsZXhpYmxlIHN0cmVhbSByb3V0aW5nLCBt ZWFuaW5nIHVzZXJzcGFjZQpjYW4gbGluayBhbnkgQ1NJRCBwYWQgdG8gYW55IFZGRSBwYWQgdmlh IHRoZSBNZWRpYSBDb250cm9sbGVyIGdyYXBoIChlLmcuLApyb3V0aW5nIGNzaWQwIHRvIHZmZTEp LgoKQnkgaGFyZGNvZGluZyB0aGUgaGFyZHdhcmUgSUQgdG8gdGhlIGxvY2FsIFZGRSdzIElEICh2 ZmUtPmlkKSwgaWYgY3NpZDAgaXMKcm91dGVkIHRvIHZmZTEsIHZmZV9yZWdfdXBkYXRlKCkgd2ls bCBsb29rIHVwIGNzaWQxIGFuZCBpbmNvcnJlY3RseSBpc3N1ZSB0aGUKYnVmZmVyIEFVUF9VUERB VEUgY29tbWFuZHMgdG8gdGhlIGNzaWQxIGhhcmR3YXJlIGluc3RlYWQgb2YgdGhlIGFjdGl2ZSBj c2lkMC4KCkNvdWxkIHRoaXMgZHJvcCBxdWV1ZWQgYnVmZmVycyBvbiB0aGUgYWN0aXZlIHN0cmVh bSBhbmQgY29ycnVwdCB0aGUgcmVnaXN0ZXIKc3RhdGUgb2YgdGhlIGluYWN0aXZlIENTSUQ/Cgpb U2V2ZXJpdHk6IEhpZ2hdClRoaXMgd2lyZXMgdXAgdmZlX3JlZ191cGRhdGUoKSB0byBjYW1zc19y ZWdfdXBkYXRlKCksIGJyaWRnaW5nIFZGRSdzIGJ1ZmZlcgpxdWV1ZSBwYXRoIGludG8gdGhlIENT SUQgcmVnaXN0ZXIgdXBkYXRlIHBhdGguCgp2ZmVfcXVldWVfYnVmZmVyX3YyKCkgZXhlY3V0ZXMg aW4gcHJvY2VzcyBjb250ZXh0IGFuZCBhY3F1aXJlcwp2ZmUtPm91dHB1dF9sb2NrICh3aGljaCBk aXNhYmxlcyBsb2NhbCBpbnRlcnJ1cHRzIGJ1dCBkb2VzIG5vdCBwcmV2ZW50CmV4ZWN1dGlvbiBv biBvdGhlciBDUFVzKSwgYW5kIGl0IHRyaWdnZXJzIHZmZV9yZWdfdXBkYXRlKCkgLT4KX19jc2lk X2F1cF91cGRhdGUoKS4gVGhpcyBwZXJmb3JtcyBhIG5vbi1hdG9taWMgcmVhZC1tb2RpZnktd3Jp dGUgb24gc2hhcmVkCnN0YXRlOgoKICAgIGNzaWQtPmF1cF91cGRhdGUgfD0gQ1NJRF9SVVBfQVVQ X1JESShwb3J0X2lkKTsKCkNvbmN1cnJlbnRseSwgY3NpZF9pc3IoKSBjYW4gZXhlY3V0ZSBpbiBo YXJkaXJxIGNvbnRleHQgb24gYW5vdGhlciBDUFUuIEl0CmNhbGxzIF9fY3NpZF9hdXBfcnVwX2Ns ZWFyKCksIHdoaWNoIG1vZGlmaWVzIHRoZSBleGFjdCBzYW1lIHZhcmlhYmxlCmxvY2tsZXNzbHk6 CgogICAgY3NpZC0+YXVwX3VwZGF0ZSAmPSB+Q1NJRF9SVVBfQVVQX1JESShwb3J0X2lkKTsKClNp bmNlIF9fY3NpZF9hdXBfdXBkYXRlKCkgYW5kIF9fY3NpZF9hdXBfcnVwX2NsZWFyKCkgdXNlIG5v bi1hdG9taWMgc3RhbmRhcmQKYml0d2lzZSBvcGVyYXRvcnMgKHw9IGFuZCAmPSkgZnJvbSBjb21w ZXRpbmcgY29udGV4dHMgd2l0aG91dCBhIHNoYXJlZApzcGlubG9jaywgZG9lcyB0aGlzIGZvcm0g YSBUT0NUT1UgZGF0YSByYWNlIHRoYXQgd2lsbCBjb3JydXB0CmNzaWQtPmF1cF91cGRhdGU/IENv dWxkIHRoaXMgcmVzdWx0IGluIGxvc3QgcmVnaXN0ZXIgdXBkYXRlcywgZHJvcHBlZCBidWZmZXJz LAphbmQgcGlwZWxpbmUgc3RhbGxzPwoKWyAuLi4gXQoKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9t ZWRpYS9wbGF0Zm9ybS9xY29tL2NhbXNzL2NhbXNzLXZmZS5jIGIvZHJpdmVycy9tZWRpYS9wbGF0 Zm9ybS9xY29tL2NhbXNzL2NhbXNzLXZmZS5jCj4gaW5kZXggMjY4MGE5OTE0NzY1Zi4uNTcxMGZk YmU0MWIzZSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL3Fjb20vY2Ftc3Mv Y2Ftc3MtdmZlLmMKPiArKysgYi9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL3Fjb20vY2Ftc3MvY2Ft c3MtdmZlLmMKClsgLi4uIF0KCj4gQEAgLTU1Miw3ICs1NTMsOSBAQCBpbnQgdmZlX2VuYWJsZV9v dXRwdXRfdjIoc3RydWN0IHZmZV9saW5lICpsaW5lKQo+ICAJCW91dHB1dC0+Z2VuMi5hY3RpdmVf bnVtKys7Cj4gIAkJb3BzLT52ZmVfd21fdXBkYXRlKHZmZSwgb3V0cHV0LT53bV9pZHhbMF0sCj4g IAkJCQkgICBvdXRwdXQtPmJ1ZltpXS0+YWRkclswXSwgbGluZSk7Cj4gLQkJb3BzLT5yZWdfdXBk YXRlKHZmZSwgbGluZS0+aWQpOwo+ICsKPiArCQlpZiAoIXZmZS0+cmVzLT5yZWdfdXBkYXRlX2Fm dGVyX2NzaWRfY29uZmlnKQo+ICsJCQlvcHMtPnJlZ191cGRhdGUodmZlLCBsaW5lLT5pZCk7Cj4g IAl9CgpbU2V2ZXJpdHk6IEhpZ2hdClRoZSBjb21taXQgbWVzc2FnZSBzdGF0ZXMgdGhhdCAidGhl IG51bWJlciBvZiBBVVBfVVBEQVRFIHJlcXVlc3RzIG11c3QgbWF0Y2gKdGhlIG51bWJlciBvZiBi dWZmZXJzIHF1ZXVlZCB0byB0aGUgd3JpdGUgbWFzdGVyIHdoaWxlIGl0IGlzIGJlaW5nIGVuYWJs ZWQuIgpIZXJlIGluIHZmZV9lbmFibGVfb3V0cHV0X3YyKCksIHRoZSBsb29wIGZldGNoaW5nIHF1 ZXVlZCBidWZmZXJzIGJyZWFrcyBlYXJseQppZiBmZXdlciB0aGFuIENBTVNTX0lOSVRfQlVGX0NP VU5UICgyKSBidWZmZXJzIGFyZSBhdmFpbGFibGUsIG1lYW5pbmcgaXQgaXMKdmFsaWQgZm9yIHVz ZXJzcGFjZSB0byBxdWV1ZSBvbmx5IDAgb3IgMSBidWZmZXJzLgoKSG93ZXZlciwgY3NpZF9jb25m aWd1cmVfc3RyZWFtKCkgaW4gY2Ftc3MtY3NpZC0xMDgwLmMgaW5kaXNjcmltaW5hdGVseSBsb29w cwphbmQgaXNzdWVzIGV4YWN0bHkgMiBBVVBfVVBEQVRFIHJlcXVlc3RzIHVuY29uZGl0aW9uYWxs eSwgaWdub3JpbmcgdGhlIFZGRSdzCmFjdHVhbCBhY3RpdmVfbnVtLgoKRG9lcyB0aGlzIG1pc21h dGNoIHZpb2xhdGUgdGhlIGhhcmR3YXJlIGNvbnN0cmFpbnQgYW5kIGNhdXNlIHRoZSBWRkUgV3Jp dGUKTWFzdGVyIHRvIGZldGNoIHVuaW5pdGlhbGl6ZWQgYnVmZmVyIGFkZHJlc3NlcyAoMHgwKSBm b3IgdGhlIG1pc3NpbmcgdXBkYXRlcywKcG90ZW50aWFsbHkgbGVhZGluZyB0byBETUEgZmF1bHRz IG9yIHBoeXNpY2FsIG1lbW9yeSBjb3JydXB0aW9uPwoKLS0gClNhc2hpa28gQUkgcmV2aWV3IMK3 IGh0dHBzOi8vc2FzaGlrby5kZXYvIy9wYXRjaHNldC8yMDI2MTAxMC1rYWFuYXBhbGktY2Ftc3Mt djIwLTAtNjNlOThjZTlhYzBjQG9zcy5xdWFsY29tbS5jb20/cGFydD04CgotLSAKbGludXgtcGh5 IG1haWxpbmcgbGlzdApsaW51eC1waHlAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwczovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1waHkK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4B75382F07 for ; Sat, 10 Oct 2026 16:25:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791649553; cv=none; b=O48kebNACBPnHC8TZq7UuqmsydgcGMVqteZlDXAyr9ym28fbwREXL7nr9q/eUJ5AfN1NJsO14n3cA3YrhsBXoeQVPO41Ccv1r83S70MEofPS93kzkRri5CjFZ5ZFLCwNQCbCVYHiwDWJBxRBELsj6mqTEmmw5Ahl4VMrh1GQ5Yo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791649553; c=relaxed/simple; bh=80EPWBsZX25JmeAOEW1OTO9vbAOytTWmIw+jnGuzRXo=; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type: Date; b=ZloQxZPuskXA1CMsGvGtEME2CKuxtgHGLflBzyUOnxvETlOJC8PUp4Umo46YW3LjL4O3+Vol9yaBvMOol+t0/yh5fCMStvoc62k5Dj2fGMwci/foWiVzLkbAdMrMmOl2F3umvFf98tkkSq7ma5zCuQATt9qdphENq+dVOqK0AFg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CtAKnH5t; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CtAKnH5t" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7C011F000FF; Sat, 10 Oct 2026 16:25:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791649552; bh=9BQoPNpg/BuzHBZB4mO3d/+THaNd9C2XTiHsMc60QaY=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=CtAKnH5tK5prTd7sikrq+hsrzJFXD4KQPW8uWMIXGIAR+0YktZqvH+qX6hknBIWL3 XwdAvvi4Yz9C8YvxWFM2Wnce1RDYVXUEMboz9zLe2WIV5pl2loQJhAK0KJRukLL6Y/ FnUox1zaibUQQ8RCZ3hWjqqP3Im8FR8g3efqF6xWqmnfF9M2VeqXLDGLtgkUh1W2BO jf6qph7SQAeyA9KqDuWkgMAqQv8YRDdHb4Z3yeflBJHE6W0NJyHVnwiSEj9/WoSXl5 dY/Ud52M7Rg/9xx3qF6N1Kl+SsIzvrEJo+Z5SrEK1PGEnEVMqli87CaX7+h8kHFgWa S5bdLBUCx3gDw== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v20 08/13] media: qcom: camss: vfe: Add support for VFE 1080 Reply-To: sashiko-reviews@lists.linux.dev To: "Hangxiang Ma" Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, olteanv@gmail.com, vkoul@kernel.org, neil.armstrong@linaro.org, linux-phy@lists.infradead.org, robh@kernel.org, media-ci@linuxtv.org In-Reply-To: <20261010-kaanapali-camss-v20-8-63e98ce9ac0c@oss.qualcomm.com> References: <20261010-kaanapali-camss-v20-0-63e98ce9ac0c@oss.qualcomm.com> <20261010-kaanapali-camss-v20-8-63e98ce9ac0c@oss.qualcomm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Sat, 10 Oct 2026 16:25:51 +0000 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 3 potential issue(= s) to consider: - [High] media: vfe: AUP_UPDATE mismatch during stream enable violates hard= ware constraint - [High] media: csid: lockless read-modify-write race on csid->aup_update f= rom process and hardirq - [Medium] media: vfe: hardcoded vfe->id mapping breaks Media Controller cr= oss-routing -- commit d6f09b2d35220bf1f91873f665e2de70196c2e83 Author: Hangxiang Ma media: qcom: camss: vfe: Add support for VFE 1080 Add support for the VFE (Video Front End) 1080 found on Kaanapali SoC. The driver continues to use VFE naming, and Kaanapali requires REG_UPDATE and AUP_UPDATE to be issued only after CSID configuration. > diff --git a/drivers/media/platform/qcom/camss/camss-vfe-1080.c b/drivers= /media/platform/qcom/camss/camss-vfe-1080.c > new file mode 100644 > index 0000000000000..016857cd10251 > --- /dev/null > +++ b/drivers/media/platform/qcom/camss/camss-vfe-1080.c [ ... ] > +static void vfe_reg_update(struct vfe_device *vfe, enum vfe_line_id line= _id) > +{ > + int port_id =3D line_id; > + > + camss_reg_update(vfe->camss, vfe->id, port_id, false); > +} [Severity: Medium] The CAMSS driver framework allows flexible stream routing, meaning userspace can link any CSID pad to any VFE pad via the Media Controller graph (e.g., routing csid0 to vfe1). By hardcoding the hardware ID to the local VFE's ID (vfe->id), if csid0 is routed to vfe1, vfe_reg_update() will look up csid1 and incorrectly issue t= he buffer AUP_UPDATE commands to the csid1 hardware instead of the active csid= 0. Could this drop queued buffers on the active stream and corrupt the register state of the inactive CSID? [Severity: High] This wires up vfe_reg_update() to camss_reg_update(), bridging VFE's buffer queue path into the CSID register update path. vfe_queue_buffer_v2() executes in process context and acquires vfe->output_lock (which disables local interrupts but does not prevent execution on other CPUs), and it triggers vfe_reg_update() -> __csid_aup_update(). This performs a non-atomic read-modify-write on shared state: csid->aup_update |=3D CSID_RUP_AUP_RDI(port_id); Concurrently, csid_isr() can execute in hardirq context on another CPU. It calls __csid_aup_rup_clear(), which modifies the exact same variable locklessly: csid->aup_update &=3D ~CSID_RUP_AUP_RDI(port_id); Since __csid_aup_update() and __csid_aup_rup_clear() use non-atomic standard bitwise operators (|=3D and &=3D) from competing contexts without a shared spinlock, does this form a TOCTOU data race that will corrupt csid->aup_update? Could this result in lost register updates, dropped buffe= rs, and pipeline stalls? [ ... ] > diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/medi= a/platform/qcom/camss/camss-vfe.c > index 2680a9914765f..5710fdbe41b3e 100644 > --- a/drivers/media/platform/qcom/camss/camss-vfe.c > +++ b/drivers/media/platform/qcom/camss/camss-vfe.c [ ... ] > @@ -552,7 +553,9 @@ int vfe_enable_output_v2(struct vfe_line *line) > output->gen2.active_num++; > ops->vfe_wm_update(vfe, output->wm_idx[0], > output->buf[i]->addr[0], line); > - ops->reg_update(vfe, line->id); > + > + if (!vfe->res->reg_update_after_csid_config) > + ops->reg_update(vfe, line->id); > } [Severity: High] The commit message states that "the number of AUP_UPDATE requests must match the number of buffers queued to the write master while it is being enabled." Here in vfe_enable_output_v2(), the loop fetching queued buffers breaks ear= ly if fewer than CAMSS_INIT_BUF_COUNT (2) buffers are available, meaning it is valid for userspace to queue only 0 or 1 buffers. However, csid_configure_stream() in camss-csid-1080.c indiscriminately loops and issues exactly 2 AUP_UPDATE requests unconditionally, ignoring the VFE's actual active_num. Does this mismatch violate the hardware constraint and cause the VFE Write Master to fetch uninitialized buffer addresses (0x0) for the missing update= s, potentially leading to DMA faults or physical memory corruption? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261010-kaanapali-= camss-v20-0-63e98ce9ac0c@oss.qualcomm.com?part=3D8