Re: [PATCH 09/10] dt-bindings: arm: apple: Add M4 Pro/Max based devices

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] dt-bindings: missing blank line before M4 Pro/Max list in description
- [Low] dt-bindings: orphaned t6050-aic3 compatible in aic2 schema
--

commit fae2108ff5a60b40ae253b364d3bc3ad16bac012
Author: Yureka Lilian <yureka@cyberchaos.dev>

dt-bindings: arm: apple: Add M4 Pro/Max based devices

This commit adds device tree compatibles for the M4 Pro and M4 Max
based MacBook Pro, Mac mini, and Mac Studio devices. It updates the
top-level device listing and defines the required matching properties
for these platforms.

> diff --git a/Documentation/devicetree/bindings/arm/apple.yaml b/Documentation/devicetree/bindings/arm/apple.yaml
> --- a/Documentation/devicetree/bindings/arm/apple.yaml
> +++ b/Documentation/devicetree/bindings/arm/apple.yaml
> @@ -144,6 +144,14 @@ description: |
>    - MacBook Pro (16-inch, M3 Max, 2023)
>    - Mac Studio (M3 Ultra, 2025)
>  
> +  Devices based on the "M4 Pro" and "M4 Max" SoCs:

[Severity: Low]
Is there a missing blank line before this heading?

Most prior generation entries in this description block separate the
generation heading and device list with a blank line for readability.
Adding a blank line before this heading would keep the text formatting
consistent.

> +  - MacBook Pro (14-inch, M4 Pro, 2024)
> +  - MacBook Pro (14-inch, M4 Max, 2024)

[ ... ]

> diff --git a/Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml b/Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml
> --- a/Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml
> @@ -134,6 +136,7 @@ allOf:
>                - apple,t6000-aic
>                - apple,t6020-aic
>                - apple,t6031-aic3
> +              - apple,t6050-aic3
>      then:
>        properties:

[Severity: Low]
Does this compatible string also need to be in the top-level enum list?

This compatible string was added to the conditional block here in an earlier
commit in this series, but it appears to be completely missing from the
top-level properties:compatible enum definition.

Any device tree attempting to use apple,t6050-aic3 will fail schema
validation at the top-level compatible check, which makes this condition
effectively dead code.

While t6041-aic3 correctly uses 3 interrupt cells and does not belong in this
4-cell branch, the apple,t6050-aic3 string added here has no matching
top-level enum. Should it be added to the top-level list, or was this string
included here by mistake?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261010-apple-m4-pro-max-initial-devicetrees-v1-0-781fb3f2d9f6@cyberchaos.dev?part=9