Re: [PATCH RESEND] usb: octeon-hcd: release the USB block when initialization fails

[sashiko-bot@kernel.org]

> cvmx_usb_initialize() gets as far as selecting the reference clock,
> enabling USBN_CLK_CTL and taking the PHY out of reset (steps 2b-2e)
> before anything can go wrong, and its only caller frees the HCD and
> returns without touching the hardware. Both of its error returns
> therefore leave the USB block clocked and out of reset on a failed
> probe.
> 
> Release it on the way out with cvmx_usb_shutdown(), which is the undo
> the retry path a few lines above already uses. It cannot refuse with
> -EBUSY here: the pipe lists it checks are initialised by
> octeon_usb_probe() before cvmx_usb_initialize() is called, and no pipe
> can have been opened yet.
> 
> Fixes: 22bce6d2b3fd ("usb: octeon-hcd: fail the probe when the USB core does not respond")
> Assisted-by: LLM
> Signed-off-by: Orgad Shaneh <orgads@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261011072238.2381564-1-orgads@gmail.com?part=1