Re: [PATCH v2] usb: octeon-hcd: keep SOF interrupts while a pipe needs them

[sashiko-bot@kernel.org]

> cvmx_usb_schedule() now sleeps on an hrtimer until the nearest future
> periodic deadline instead of counting frames down on every SOF. The scan
> that finds that deadline only looks at pipes with
> 
> 	next_tx_frame > usb->frame_number
> 
> which is right for picking the deadline, but two kinds of pipe that
> need a SOF to make progress are invisible to the decision:
> 
> - A periodic pipe that is due and was *not* started: no idle hardware
>   channel this round, its split window is closed
>   (cvmx_usb_find_ready_pipe() rejects both), or another pipe owns
>   usb->active_split. cvmx_usb_next_pipe() looks at the isochronous and
>   interrupt lists only when is_sof is true.
> 
> [ ... ]
> "due" and would keep SOF enabled permanently.
> 
> Fixes: aebbc7d63407 ("usb: octeon-hcd: sleep on an hrtimer for far-off periodic transfers")
> Assisted-by: LLM
> Signed-off-by: Orgad Shaneh <orgads@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261011080506.2394708-1-orgads@gmail.com?part=1