From: sashiko-bot@kernel.org
To: "Aleksandrs Vinarskis" <alex@vinarskis.com>
Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v5 1/3] dt-bindings: platform: introduce EC for Dell XPS 13 9345
Date: Sun, 11 Oct 2026 17:37:21 +0000 [thread overview]
Message-ID: <sashiko-outbox-167353@kernel.org> (raw)
In-Reply-To: <20261011-dell-xps-9345-ec-v5-1-2ab1258b84c1@vinarskis.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: architecture-specific header included in yaml example
--
commit 8b45bf401f436a6e8330c0e4539c0d77e9e73400
Author: Aleksandrs Vinarskis <alex@vinarskis.com>
dt-bindings: platform: introduce EC for Dell XPS 13 9345
Add bindings for the Embedded Controller in the Dell XPS 13 9345. It defines
properties for thermal and power management over multiple i2c busses.
> diff --git a/Documentation/devicetree/bindings/embedded-controller/dell,xps13-9345-ec.yaml b/Documentation/devicetree/bindings/embedded-controller/dell,xps13-9345-ec.yaml
> new file mode 100644
> index 0000000000000..3485117b505cc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/embedded-controller/dell,xps13-9345-ec.yaml
[ ... ]
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + #include <arm64/qcom/qcom-adc5-gen3.h>
[Severity: Low]
Does this example include an architecture-specific header? Including headers
outside of include/dt-bindings/ breaks dt-binding schema portability rules.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261011-dell-xps-9345-ec-v5-0-2ab1258b84c1@vinarskis.com?part=1
next prev parent reply other threads:[~2026-10-11 17:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-11 17:29 [PATCH v5 0/3] (no cover subject) Aleksandrs Vinarskis
2026-10-11 17:29 ` [PATCH v5 1/3] dt-bindings: platform: introduce EC for Dell XPS 13 9345 Aleksandrs Vinarskis
2026-10-11 17:37 ` sashiko-bot [this message]
2026-10-11 17:29 ` [PATCH v5 2/3] platform: arm64: dell-xps-ec: new driver Aleksandrs Vinarskis
2026-10-11 17:42 ` sashiko-bot
2026-10-11 17:29 ` [PATCH v5 3/3] arm64: dts: qcom: x1e80100-dell-xps13-9345: introduce EC Aleksandrs Vinarskis
2026-10-11 17:36 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-167353@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=alex@vinarskis.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.