Re: [PATCH v6 1/3] dt-bindings: platform: introduce EC for Dell XPS 13 9345

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: arch-specific include in schema example breaks external tools
--

commit 6a2d14c54cd528a2a30745160408a04834bb3011
Author: Aleksandrs Vinarskis <alex@vinarskis.com>

dt-bindings: platform: introduce EC for Dell XPS 13 9345

This commit adds device tree bindings for the Embedded Controller found in
the Dell XPS 13 9345. It defines the required properties for communication
over i2c, including thermal channel mappings.

> diff --git a/Documentation/devicetree/bindings/embedded-controller/dell,xps13-9345-ec.yaml b/Documentation/devicetree/bindings/embedded-controller/dell,xps13-9345-ec.yaml
> new file mode 100644
> index 0000000000000..3485117b505cc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/embedded-controller/dell,xps13-9345-ec.yaml

[ ... ]

> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    #include <arm64/qcom/qcom-adc5-gen3.h>

[Severity: Low]
Will this architecture-specific include break external device tree validation
tools?

Out-of-tree schema validation tools or downstream projects using these bindings
(like U-Boot or Zephyr) will typically fail to compile the example because
they lack the Linux-specific arch/arm64/boot/dts/ tree and the associated
Makefile symlinks.

A search of Documentation/devicetree/bindings/ shows that other schema examples
strictly rely on <dt-bindings/...> headers instead of architecture-specific
paths.

Could this be adjusted to avoid the architecture-specific include?

> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        embedded-controller@3b {
> +            compatible = "dell,xps13-9345-ec";

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261011-dell-xps-9345-ec-v6-0-2a66a364fe70@vinarskis.com?part=1