Re: [PATCH v7 13/14] selftests/verification: Add tlob selftests

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] selftests: commit message incorrectly claims run_tlob_tests.sh builds helpers
--

commit efda93f229ffc44f9ac300b085e473092fbfd5fd
Author: Wen Yang <wen.yang@linux.dev>

selftests/verification: Add tlob selftests

This commit adds ten ftrace-style test scripts for the tlob RV monitor, along
with a target helper binary. It also introduces a runner script to handle
ftracetest delegation.

Suggested-by: Gabriele Monaco <gmonaco@redhat.com>
Signed-off-by: Wen Yang <wen.yang@linux.dev>

> Helper binarie tlob_target is built via TEST_GEN_FILES, following
> the kselftests convention.  run_tlob_tests.sh builds the helpers
> and delegates argument handling to ftracetest.

[Severity: Low]
This isn't a bug in the code, but there is a typo (binarie), and the commit
message states that run_tlob_tests.sh builds the helpers. Is this description
accurate?

Looking at the added script, it explicitly refuses to build the helper and
errors out if the binary is missing:

> diff --git a/tools/testing/selftests/verification/test.d/tlob/run_tlob_tests.sh b/tools/testing/selftests/verification/test.d/tlob/run_tlob_tests.sh
> new file mode 100755
> index 0000000000000..c87484813fc86
> --- /dev/null
> +++ b/tools/testing/selftests/verification/test.d/tlob/run_tlob_tests.sh
[ ... ]
> +# The helper is built on the host by the selftests Makefile
> +# (TEST_GEN_FILES in $BINDIR/Makefile); the VM (virtme-ng) mounts the
> +# source read-only and may lack a compiler, so this runner never builds.
> +# Build it on the host first:
> +#   make -C "$BINDIR" tlob_target
> +if [ ! -x "$BINDIR/tlob_target" ]; then
> +	echo "ERROR: tlob_target not built in $BINDIR" >&2
> +	echo "       build it on the host: make -C $BINDIR tlob_target" >&2
> +	exit 1
> +fi

Could the commit message be updated to clarify that the script expects the
helper to be pre-built on the host rather than building it automatically?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1791745088.git.wen.yang@linux.dev?part=13