Re: [PATCH] perf regs: Add alpha support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] perf: missing POSIX header inclusions in perf_regs_alpha.c
--

commit fd8853fd5c4e09ccccf58c76fbab7cdfcce13a97
Author: Matt Turner <mattst88@gmail.com>

perf regs: Add alpha support

Add the alpha perf register tables so that -I/--user-regs and
--call-graph dwarf work. r9-r15 cannot be sampled and are left out of the
mask.

> diff --git a/tools/perf/util/perf-regs-arch/perf_regs_alpha.c b/tools/perf/util/perf-regs-arch/perf_regs_alpha.c
> new file mode 100644
> index 0000000000000..cb9c8a1cd74b9
> --- /dev/null
> +++ b/tools/perf/util/perf-regs-arch/perf_regs_alpha.c
> @@ -0,0 +1,34 @@
> +// SPDX-License-Identifier: GPL-2.0
> +
> +#include "../perf_regs.h"
> +#include "../../arch/alpha/include/perf_regs.h"

[Severity: Low]
Does this file need explicit inclusions for stdint.h, stdbool.h, and stddef.h?

The code below relies on uint64_t, bool, and NULL. Relying on implicit header
dependencies might cause build failures on systems using musl libc where these
headers are not automatically included by other subsystem headers.

> +
> +static const char * const alpha_reg_names[PERF_REG_ALPHA_MAX] = {
> +	"r0", "r1", "r2", "r3", "r4", "r5", "r6", "r7",
> +	"r8", "r9", "r10", "r11", "r12", "r13", "r14", "r15",
> +	"r16", "r17", "r18", "r19", "r20", "r21", "r22", "r23",
> +	"r24", "r25", "r26", "r27", "r28", "gp", "sp", "pc",
> +};
> +
> +uint64_t __perf_reg_mask_alpha(bool intr __maybe_unused)

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261011-alpha-perf-tools-regs-v1-1-2a5940e22548@gmail.com?part=1