Re: [PATCH v5 6/6] drm/xe/xe_ras: Track offlined pages by firmware to avoid duplicates

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] xe: ignored error return from xe_drm_ras_init()
--

commit 7ebbe76ad5759ef208c6c4acec5e508c52920687
Author: Riana Tauro <riana.tauro@intel.com>

drm/xe/xe_ras: Track offlined pages by firmware to avoid duplicates

A memory scrubber can report multiple errors at the same address. Track
pages already successfully offlined by the firmware so that subsequent
reports for the same address are removed from the firmware queue instead
of issuing redundant page offline requests.

> diff --git a/drivers/gpu/drm/xe/xe_ras.c b/drivers/gpu/drm/xe/xe_ras.c
> --- a/drivers/gpu/drm/xe/xe_ras.c
> +++ b/drivers/gpu/drm/xe/xe_ras.c

[ ... ]

> @@ -1147,15 +1183,18 @@ u32 xe_ras_get_max_pages(struct xe_device *xe)
>   * @xe: xe device instance
>   *
>   * Initialize Xe RAS
> + *
> + * Return: 0 on success, negative error code otherwise
>   */
> -void xe_ras_init(struct xe_device *xe)
> +int xe_ras_init(struct xe_device *xe)
>  {
> +	struct xe_ras_state *state = &xe->ras.state;
>  	int ret;
>  
>  	xe_drm_ras_init(xe);

[Severity: Medium]
Should the return value of xe_drm_ras_init() be checked and propagated
here? 

If xe_drm_ras_init() fails to allocate memory or register the DRM RAS
nodes, it returns an error code like -ENOMEM. Because this patch updates
xe_ras_init() to return an int and propagate errors, missing this check
could allow the driver to continue initialization with partially set up
RAS nodes instead of properly failing the probe.

>  
>  	if (!xe->info.has_sysctrl)
> -		return;
> +		return 0;
>  
>  	/*
>  	 * TODO: Replace with xe->info.has_disable_vram_page_offline once the feature flag is

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261012054056.2272869-8-riana.tauro@intel.com?part=6