Re: [PATCH v2 2/4] arm64: dts: qcom: talos: Add Talos Lyra EVK SoM platform

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dts: incorrect vqmmc-supply regulator mapped for removable sdhc_2 slot
--

commit bc866a802f7bd7dd47f8f7f1b6cd6d40693036e4
Author: Avaneesh Kumar Dwivedi <avaneesh.dwivedi@oss.qualcomm.com>

arm64: dts: qcom: talos: Add Talos Lyra EVK SoM platform

Introduce the device tree for the QCS615-based Talos Lyra EVK SoM.
Lyra EVK SoM is a compact compute module integrating the QCS615 SoC,
PMIC, and essential connectivity, designed to mount on carrier boards.

> diff --git a/arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi b/arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi
> new file mode 100644
> index 0000000000000..15124572186a2
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi
> @@ -0,0 +1,251 @@
[ ... ]
> +&apps_rsc {
> +	regulators-0 {
> +		compatible = "qcom,pm8150-rpmh-regulators";
> +		qcom,pmic-id = "a";
> +
> +		vreg_s4a: smps4 {
> +			regulator-name = "vreg_s4a";
> +			regulator-min-microvolt = <1800000>;
> +			regulator-max-microvolt = <1829000>;
> +			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> +		};
[ ... ]
> +		vreg_l2a: ldo2 {
> +			regulator-name = "vreg_l2a";
> +			regulator-min-microvolt = <1650000>;
> +			regulator-max-microvolt = <3100000>;
> +			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> +			regulator-allow-set-load;
> +			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> +						   RPMH_REGULATOR_MODE_HPM>;
> +		};
[ ... ]
> +&sdhc_2 {
> +	pinctrl-0 = <&sdc2_state_on>;
> +	pinctrl-1 = <&sdc2_state_off>;
> +	pinctrl-names = "default", "sleep";
> +	bus-width = <4>;
> +	cd-gpios = <&tlmm 99 GPIO_ACTIVE_LOW>;
> +	vmmc-supply = <&vreg_l10a>;
> +	vqmmc-supply = <&vreg_s4a>;

[Severity: Medium]
Will this configuration prevent standard removable SD cards from initializing?

Standard removable SD cards require 3.3V for initialization, but the
vqmmc-supply for sdhc_2 is bound to the fixed 1.8V vreg_s4a.

This mismatch typically causes regulator_set_voltage() to fail during MMC
core initialization, breaking SD card support. Should this use the unused
vreg_l2a instead, since it is configured with a 1.65V to 3.10V range?

> +
> +	status = "okay";
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261012-talos-lyra-evk-v2-v2-0-dcc9316ebb59@oss.qualcomm.com?part=2