From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2DAFFCA9EC5 for ; Mon, 12 Oct 2026 06:59:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pgfGFM8tbVOrS1CKA0hs1U5ZPqYomIp+le2EEwuaGrs=; b=sEV5TWZIXWDs85 pRCkX3Sp0ImnQ5g2jEPLmH36zKQfi+32/mMHTCtqhvH2WFJf6Z14Mw1beEuQUToKCxMw8LLD3pg+B 3HAucBiP0SudIAeI3nZEqKDRal6dKQdIc4qRtRNOkLQgDUbkECz3cuqzksifJjhEnD8roXCU7Z23P WeyJr3kDFHFLx/aM7GvpXkcQ2EsvRpsW52m2eNlGQr+pAwqe6qNJ32Xk+dsPcHyVJXeGAqK9dpfMR /jpN8W9vA5GeN1lUbRGrt8N0vtNdiKBSHopwoGkHgaQ3TIKppzbDxAhSrO+amxBf7Icgw26FBdosa tyoKePnNpmi0RcsVNWvg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xGA0R-00000009nI2-3Nx2; Mon, 12 Oct 2026 06:59:31 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xGA0Q-00000009nGp-1WO1 for linux-phy@lists.infradead.org; Mon, 12 Oct 2026 06:59:30 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 1F8FE436AA; Mon, 12 Oct 2026 06:59:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84D0E1F0089B; Mon, 12 Oct 2026 06:59:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791788370; bh=PHBb957IgA6MRnaF64Q9ve7cXpoFrFlLO1NKWF1X71w=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=IAS4j4vtSHqUNGTJyBzvs5XxLMwiQ3xGFcisxfokrMIZC8fu74WyAso9jtvP7lL53 6NFOs9t+pQEFh7HO46zk1Q7OdEr8L4pKfi2cKikaCq/Nrg4SaP8X4u0lTf1bLlo1N9 TeM6FVg99JGYcjRLWJT2PsgW0bQEdIs9BfxIO69Qe5AMINfQ6IUG701b6+wu5NmQvA PA3XVQaXENNpLSHCUlph2fjHz3S+3FP15BBpujlJq/EMiAdF/i4P8a5Aj3Gz88cViJ ISOoOsPC+iJUtmwjreEN0xngXX+9cB3b/utitx5/3VU5dYk8m3ohRhMWegnsJQproT x5UUil8k+F0QQ== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v21 08/14] media: qcom: camss: csid: Add support for CSID 1080 To: "Hangxiang Ma" Cc: neil.armstrong@linaro.org, robh@kernel.org, olteanv@gmail.com, linux-phy@lists.infradead.org, conor+dt@kernel.org, devicetree@vger.kernel.org, vkoul@kernel.org, media-ci@linuxtv.org In-Reply-To: <20261011-kaanapali-camss-v21-8-04fd28d815c6@oss.qualcomm.com> References: <20261011-kaanapali-camss-v21-0-04fd28d815c6@oss.qualcomm.com> <20261011-kaanapali-camss-v21-8-04fd28d815c6@oss.qualcomm.com> Date: Mon, 12 Oct 2026 06:59:29 +0000 X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIG1lZGlhOiBxY29tOiBj YW1zczogZGF0YSByYWNlIG9uIGF1cF91cGRhdGUgYW5kIHJ1cF91cGRhdGUgYml0bWFza3MKLSBb TWVkaXVtXSBtZWRpYTogcWNvbTogY2Ftc3M6IG1pc3NpbmcgUkRJTiBJUlEgbWFzayBpbml0aWFs aXphdGlvbiBmb3IgQ1NJRCAxMDgwCi0tCgpjb21taXQgZmVkMGY0ODIwMzQzZDRlMTU4MDEyMjEx MGYxYTk2NTU2ZmNlZTM2YwpBdXRob3I6IEhhbmd4aWFuZyBNYSA8aGFuZ3hpYW5nLm1hQG9zcy5x dWFsY29tbS5jb20+CgptZWRpYTogcWNvbTogY2Ftc3M6IGNzaWQ6IEFkZCBzdXBwb3J0IGZvciBD U0lEIDEwODAKClRoaXMgY29tbWl0IGFkZHMgc3VwcG9ydCBmb3IgdGhlIENTSUQgMTA4MCBoYXJk d2FyZSBmb3VuZCBvbiB0aGUKS2FhbmFwYWxpIFNvQy4gSXQgaW50cm9kdWNlcyBoYXJkd2FyZSBy ZXNvdXJjZSBkZXNjcmlwdGlvbnMsIHJlc2V0CnNlcXVlbmNlcywgYW5kIGludGVycnVwdCBoYW5k bGluZy4gSXQgYWxzbyB1cGRhdGVzIHRoZSBDU0lEIGludGVyZmFjZQp0byBoYW5kbGUgc2VwYXJh dGUgUlVQIGFuZCBBVVAgcmVnaXN0ZXJzLgoKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tZWRpYS9w bGF0Zm9ybS9xY29tL2NhbXNzL2NhbXNzLWNzaWQtMTA4MC5jIGIvZHJpdmVycy9tZWRpYS9wbGF0 Zm9ybS9xY29tL2NhbXNzL2NhbXNzLWNzaWQtMTA4MC5jCj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQK PiBpbmRleCAwMDAwMDAwMDAwMDAwLi40NmU0NDNlMDUxOTVhCj4gLS0tIC9kZXYvbnVsbAo+ICsr KyBiL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vcWNvbS9jYW1zcy9jYW1zcy1jc2lkLTEwODAuYwoK WyAuLi4gXQoKPiArc3RhdGljIHZvaWQgX19jc2lkX2F1cF9ydXBfY2xlYXIoc3RydWN0IGNzaWRf ZGV2aWNlICpjc2lkLCBpbnQgcG9ydF9pZCkKPiArewo+ICsJLyogSGFyZHdhcmUgY2xlYXJzIHRo ZSByZWdpc3RlcnMgdXBvbiBjb25zdW1pbmcgdGhlIHNldHRpbmdzICovCj4gKwljc2lkLT5hdXBf dXBkYXRlICY9IH5DU0lEX1JVUF9BVVBfUkRJKHBvcnRfaWQpOwo+ICsJY3NpZC0+cnVwX3VwZGF0 ZSAmPSB+Q1NJRF9SVVBfQVVQX1JESShwb3J0X2lkKTsKPiArfQo+ICsKPiArc3RhdGljIHZvaWQg X19jc2lkX2F1cF91cGRhdGUoc3RydWN0IGNzaWRfZGV2aWNlICpjc2lkLCBpbnQgcG9ydF9pZCkK PiArewo+ICsJY3NpZC0+YXVwX3VwZGF0ZSB8PSBDU0lEX1JVUF9BVVBfUkRJKHBvcnRfaWQpOwo+ ICsJd3JpdGVsKGNzaWQtPmF1cF91cGRhdGUsIGNzaWQtPmJhc2UgKyBDU0lEX0FVUF9DTUQpOwo+ ICsKPiArCV9fY3NpZF9hdXBfcnVwX3RyaWdnZXIoY3NpZCk7Cj4gK30KPiArCj4gK3N0YXRpYyB2 b2lkIF9fY3NpZF9yZWdfdXBkYXRlKHN0cnVjdCBjc2lkX2RldmljZSAqY3NpZCwgaW50IHBvcnRf aWQpCj4gK3sKPiArCWNzaWQtPnJ1cF91cGRhdGUgfD0gQ1NJRF9SVVBfQVVQX1JESShwb3J0X2lk KTsKCltTZXZlcml0eTogSGlnaF0KQ2FuIHRoZXNlIG5vbi1hdG9taWMgYml0d2lzZSBvcGVyYXRp b25zIHJhY2Ugd2l0aCB0aGUgaW50ZXJydXB0IGhhbmRsZXI/CgpfX2NzaWRfYXVwX3J1cF9jbGVh cigpIHJ1bnMgaW4gaGFyZGlycSBjb250ZXh0IHZpYSBjc2lkX2lzcigpLCBtb2RpZnlpbmcKYm90 aCBjc2lkLT5hdXBfdXBkYXRlIGFuZCBjc2lkLT5ydXBfdXBkYXRlLgoKQ29uY3VycmVudGx5LCBf X2NzaWRfYXVwX3VwZGF0ZSgpIGFuZCBfX2NzaWRfcmVnX3VwZGF0ZSgpIHBlcmZvcm0gbm9uLWF0 b21pYwpiaXR3aXNlIE9SIG9wZXJhdGlvbnMgb24gdGhlc2Ugc2FtZSBzaGFyZWQgYml0bWFza3Mg ZnJvbSBwcm9jZXNzIGNvbnRleHQKZHVyaW5nIGNzaWRfY29uZmlndXJlX3N0cmVhbSgpLgoKV2l0 aG91dCBzeW5jaHJvbml6YXRpb24gc3VjaCBhcyBzcGluX2xvY2tfaXJxc2F2ZSgpIG9yIHVzaW5n IGF0b21pYyBiaXRvcHMsCmNvdWxkIHByb2Nlc3MgY29udGV4dCBvdmVyd3JpdGUgdGhlIGludGVy cnVwdCBoYW5kbGVyJ3MgbW9kaWZpY2F0aW9ucywKcmVzdXJyZWN0aW5nIGNsZWFyZWQgYml0cyBv ciBkcm9wcGluZyBuZXdseSBzZXQgYml0cz8gVGhpcyBtaWdodCBsZWFkIHRvCm1pc3NlZCBvciBy ZWR1bmRhbnQgaGFyZHdhcmUgdXBkYXRlcy4KCj4gKwl3cml0ZWwoY3NpZC0+cnVwX3VwZGF0ZSwg Y3NpZC0+YmFzZSArIENTSURfUlVQX0NNRCk7Cj4gKwo+ICsJX19jc2lkX2F1cF9ydXBfdHJpZ2dl cihjc2lkKTsKPiArfQoKWyAuLi4gXQoKPiArc3RhdGljIGlycXJldHVybl90IGNzaWRfaXNyKGlu dCBpcnEsIHZvaWQgKmRldikKPiArewo+ICsJc3RydWN0IGNzaWRfZGV2aWNlICpjc2lkID0gZGV2 Owo+ICsJdTMyIHZhbCwgYnVmX2RvbmVfdmFsOwo+ICsJdTggcmVzZXRfZG9uZTsKPiArCWludCBp Owo+ICsKPiArCXZhbCA9IHJlYWRsKGNzaWQtPmJhc2UgKyBDU0lEX1RPUF9JUlFfU1RBVFVTKTsK PiArCXdyaXRlbCh2YWwsIGNzaWQtPmJhc2UgKyBDU0lEX1RPUF9JUlFfQ0xFQVIpOwo+ICsKPiAr CXJlc2V0X2RvbmUgPSB2YWwgJiBJTkZPX1JTVF9ET05FOwo+ICsKPiArCWJ1Zl9kb25lX3ZhbCA9 IHJlYWRsKGNzaWQtPmJhc2UgKyBDU0lEX0JVRl9ET05FX0lSUV9TVEFUVVMpOwo+ICsJd3JpdGVs KGJ1Zl9kb25lX3ZhbCwgY3NpZC0+YmFzZSArIENTSURfQlVGX0RPTkVfSVJRX0NMRUFSKTsKPiAr Cj4gKwlmb3IgKGkgPSAwOyBpIDwgTVNNX0NTSURfTUFYX1NSQ19TVFJFQU1TXzEwODA7IGkrKykg ewo+ICsJCWlmIChjc2lkLT5waHkuZW5fdmMgJiBCSVQoaSkpIHsKPiArCQkJdmFsID0gcmVhZGwo Y3NpZC0+YmFzZSArIENTSURfQ1NJMl9SRElOX0lSUV9TVEFUVVMoaSkpOwo+ICsJCQl3cml0ZWwo dmFsLCBjc2lkLT5iYXNlICsgQ1NJRF9DU0kyX1JESU5fSVJRX0NMRUFSKGkpKTsKPiArCj4gKwkJ CWlmICh2YWwgJiBJTkZPX1JVUF9ET05FKQoKW1NldmVyaXR5OiBNZWRpdW1dCldpbGwgdGhpcyBJ TkZPX1JVUF9ET05FIHN0YXR1cyBhY3R1YWxseSBsYXRjaCBpbiBoYXJkd2FyZT8KClRoZSBDU0lE X0NTSTJfUkRJTl9JUlFfTUFTSyBtYWNybyBpcyBkZWZpbmVkLCBidXQgaXQgZG9lc24ndCBzZWVt IHRvIGV2ZXIKYmUgd3JpdHRlbiB0byBoYXJkd2FyZSB0byBlbmFibGUgdGhpcyBpbnRlcnJ1cHQg ZHVyaW5nIGNzaWRfcmVzZXQoKSBvcgpjc2lkX2NvbmZpZ3VyZV9zdHJlYW0oKS4KCklmIHRoZSBt YXNrIHJlbWFpbnMgemVybywgdGhlIHN0YXR1cyBiaXQgbWlnaHQgbm90IGJlIHJlY29yZGVkLiBB cyBhIHJlc3VsdCwKY3NpZF9pc3IoKSB3b3VsZCBuZXZlciBvYnNlcnZlIElORk9fUlVQX0RPTkUs IGZhaWxpbmcgdG8gY2xlYXIKY3NpZC0+YXVwX3VwZGF0ZSBhbmQgbGVha2luZyBzdGFsZSBiaXRt YXNrcyBhY3Jvc3MgZnJhbWVzLgoKPiArCQkJCWNzaWRfc3ViZGV2X3JlZ191cGRhdGUoY3NpZCwg aSwgdHJ1ZSk7Cj4gKwo+ICsJCQlpZiAoYnVmX2RvbmVfdmFsICYgQklUKEJVRl9ET05FX0lSUV9T VEFUVVNfUkRJX09GRlNFVCArIGkpKQo+ICsJCQkJY2Ftc3NfYnVmX2RvbmUoY3NpZC0+Y2Ftc3Ms IGNzaWQtPmlkLCBpKTsKPiArCQl9Cj4gKwl9Cj4gKwo+ICsJdmFsID0gSVJRX0NNRF9DTEVBUjsK PiArCXdyaXRlbCh2YWwsIGNzaWQtPmJhc2UgKyBDU0lEX0lSUV9DTUQpOwo+ICsKPiArCWlmIChy ZXNldF9kb25lKQo+ICsJCWNvbXBsZXRlKCZjc2lkLT5yZXNldF9jb21wbGV0ZSk7Cj4gKwo+ICsJ cmV0dXJuIElSUV9IQU5ETEVEOwo+ICt9CgotLSAKU2FzaGlrbyBBSSByZXZpZXcgwrcgaHR0cHM6 Ly9zYXNoaWtvLmRldi8jL3BhdGNoc2V0LzIwMjYxMDExLWthYW5hcGFsaS1jYW1zcy12MjEtMC0w NGZkMjhkODE1YzZAb3NzLnF1YWxjb21tLmNvbT9wYXJ0PTgKCi0tIApsaW51eC1waHkgbWFpbGlu ZyBsaXN0CmxpbnV4LXBoeUBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHBzOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXBoeQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B62043DED9 for ; Mon, 12 Oct 2026 06:59:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791788377; cv=none; b=dQkhyBaMLP7y8BoKnDnKYNJ3kxrAYENQVerUtDcW0fYPC2JJsvL7rlFjbKSGJg8fzYo2y1UDTmCxKd2x7wldvEdapxyZf9stW5T+AsvB5zkTnP6NDSrmny1myYB8/ycJKAKp+Zc6jgfuIMkx4ydBe0CWuihIhhjNBfAQzj5Levg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791788377; c=relaxed/simple; bh=KukewqaBY0xvrLnRnQK2k7JGxgBkcu1uUnelbiSK6iM=; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type: Date; b=amQeJnCxpVl9u5tuN3l5qaEaM6qtYVadr2FJWJEB1lx9YLuJHEBpAYVxs8kKEvnRvNZgQ2hEfANnPMiSo/OxnRXH0OEWDdssglp9lJvSifpGK3xQGXockVZlQUvzOURKStKtq+TxCXiT53CAVE1CcM0Lka6hs7d9xw6kVJM9ZRA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IAS4j4vt; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IAS4j4vt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84D0E1F0089B; Mon, 12 Oct 2026 06:59:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791788370; bh=PHBb957IgA6MRnaF64Q9ve7cXpoFrFlLO1NKWF1X71w=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=IAS4j4vtSHqUNGTJyBzvs5XxLMwiQ3xGFcisxfokrMIZC8fu74WyAso9jtvP7lL53 6NFOs9t+pQEFh7HO46zk1Q7OdEr8L4pKfi2cKikaCq/Nrg4SaP8X4u0lTf1bLlo1N9 TeM6FVg99JGYcjRLWJT2PsgW0bQEdIs9BfxIO69Qe5AMINfQ6IUG701b6+wu5NmQvA PA3XVQaXENNpLSHCUlph2fjHz3S+3FP15BBpujlJq/EMiAdF/i4P8a5Aj3Gz88cViJ ISOoOsPC+iJUtmwjreEN0xngXX+9cB3b/utitx5/3VU5dYk8m3ohRhMWegnsJQproT x5UUil8k+F0QQ== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v21 08/14] media: qcom: camss: csid: Add support for CSID 1080 Reply-To: sashiko-reviews@lists.linux.dev To: "Hangxiang Ma" Cc: neil.armstrong@linaro.org, robh@kernel.org, olteanv@gmail.com, linux-phy@lists.infradead.org, conor+dt@kernel.org, devicetree@vger.kernel.org, vkoul@kernel.org, media-ci@linuxtv.org In-Reply-To: <20261011-kaanapali-camss-v21-8-04fd28d815c6@oss.qualcomm.com> References: <20261011-kaanapali-camss-v21-0-04fd28d815c6@oss.qualcomm.com> <20261011-kaanapali-camss-v21-8-04fd28d815c6@oss.qualcomm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 12 Oct 2026 06:59:29 +0000 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 2 potential issue(= s) to consider: - [High] media: qcom: camss: data race on aup_update and rup_update bitmasks - [Medium] media: qcom: camss: missing RDIN IRQ mask initialization for CSI= D 1080 -- commit fed0f4820343d4e1580122110f1a96556fcee36c Author: Hangxiang Ma media: qcom: camss: csid: Add support for CSID 1080 This commit adds support for the CSID 1080 hardware found on the Kaanapali SoC. It introduces hardware resource descriptions, reset sequences, and interrupt handling. It also updates the CSID interface to handle separate RUP and AUP registers. > diff --git a/drivers/media/platform/qcom/camss/camss-csid-1080.c b/driver= s/media/platform/qcom/camss/camss-csid-1080.c > new file mode 100644 > index 0000000000000..46e443e05195a > --- /dev/null > +++ b/drivers/media/platform/qcom/camss/camss-csid-1080.c [ ... ] > +static void __csid_aup_rup_clear(struct csid_device *csid, int port_id) > +{ > + /* Hardware clears the registers upon consuming the settings */ > + csid->aup_update &=3D ~CSID_RUP_AUP_RDI(port_id); > + csid->rup_update &=3D ~CSID_RUP_AUP_RDI(port_id); > +} > + > +static void __csid_aup_update(struct csid_device *csid, int port_id) > +{ > + csid->aup_update |=3D CSID_RUP_AUP_RDI(port_id); > + writel(csid->aup_update, csid->base + CSID_AUP_CMD); > + > + __csid_aup_rup_trigger(csid); > +} > + > +static void __csid_reg_update(struct csid_device *csid, int port_id) > +{ > + csid->rup_update |=3D CSID_RUP_AUP_RDI(port_id); [Severity: High] Can these non-atomic bitwise operations race with the interrupt handler? __csid_aup_rup_clear() runs in hardirq context via csid_isr(), modifying both csid->aup_update and csid->rup_update. Concurrently, __csid_aup_update() and __csid_reg_update() perform non-atomic bitwise OR operations on these same shared bitmasks from process context during csid_configure_stream(). Without synchronization such as spin_lock_irqsave() or using atomic bitops, could process context overwrite the interrupt handler's modifications, resurrecting cleared bits or dropping newly set bits? This might lead to missed or redundant hardware updates. > + writel(csid->rup_update, csid->base + CSID_RUP_CMD); > + > + __csid_aup_rup_trigger(csid); > +} [ ... ] > +static irqreturn_t csid_isr(int irq, void *dev) > +{ > + struct csid_device *csid =3D dev; > + u32 val, buf_done_val; > + u8 reset_done; > + int i; > + > + val =3D readl(csid->base + CSID_TOP_IRQ_STATUS); > + writel(val, csid->base + CSID_TOP_IRQ_CLEAR); > + > + reset_done =3D val & INFO_RST_DONE; > + > + buf_done_val =3D readl(csid->base + CSID_BUF_DONE_IRQ_STATUS); > + writel(buf_done_val, csid->base + CSID_BUF_DONE_IRQ_CLEAR); > + > + for (i =3D 0; i < MSM_CSID_MAX_SRC_STREAMS_1080; i++) { > + if (csid->phy.en_vc & BIT(i)) { > + val =3D readl(csid->base + CSID_CSI2_RDIN_IRQ_STATUS(i)); > + writel(val, csid->base + CSID_CSI2_RDIN_IRQ_CLEAR(i)); > + > + if (val & INFO_RUP_DONE) [Severity: Medium] Will this INFO_RUP_DONE status actually latch in hardware? The CSID_CSI2_RDIN_IRQ_MASK macro is defined, but it doesn't seem to ever be written to hardware to enable this interrupt during csid_reset() or csid_configure_stream(). If the mask remains zero, the status bit might not be recorded. As a result, csid_isr() would never observe INFO_RUP_DONE, failing to clear csid->aup_update and leaking stale bitmasks across frames. > + csid_subdev_reg_update(csid, i, true); > + > + if (buf_done_val & BIT(BUF_DONE_IRQ_STATUS_RDI_OFFSET + i)) > + camss_buf_done(csid->camss, csid->id, i); > + } > + } > + > + val =3D IRQ_CMD_CLEAR; > + writel(val, csid->base + CSID_IRQ_CMD); > + > + if (reset_done) > + complete(&csid->reset_complete); > + > + return IRQ_HANDLED; > +} --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261011-kaanapali-= camss-v21-0-04fd28d815c6@oss.qualcomm.com?part=3D8