Re: [PATCH] arm64: dts: imx95-19x19-frdm-pro: add boot phase properties

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dts: Missing bootph-pre-ram for gpio3 breaks early SD card access
--

commit dc22078eb20524e315ef0d520678ff9336ed179e
Author: Joseph Guo <qijian.guo@nxp.com>

    arm64: dts: imx95-19x19-frdm-pro: add boot phase properties
    
    Add boot phase properties to essential resources during boot phase.
    
    FRDM-IMX95-PRO need UART, SD-Card, eMMC access during boot process.

> diff --git a/arch/arm64/boot/dts/freescale/imx95-19x19-frdm-pro.dts b/arch/arm64/boot/dts/freescale/imx95-19x19-frdm-pro.dts
> index 1f62d729a5e77..8dc1134f8d24d 100644
> --- a/arch/arm64/boot/dts/freescale/imx95-19x19-frdm-pro.dts
> +++ b/arch/arm64/boot/dts/freescale/imx95-19x19-frdm-pro.dts
> @@ -180,6 +180,7 @@ reg_usdhc2_vmmc: regulator-usdhc2 {
>  		regulator-min-microvolt = <3300000>;
>  		gpio = <&gpio3 7 GPIO_ACTIVE_HIGH>;
>  		enable-active-high;
> +		bootph-pre-ram;
>  	};

[Severity: Medium]
Will this regulator be available in the SPL phase without adding bootph-pre-ram
to the gpio3 node?

Since the fdtgrep tool extracts nodes tagged with bootph-pre-ram but does not
automatically trace and retain phandles for nodes lacking the tag, the
gpio3 controller node will be entirely stripped from the SPL device tree.

Could the gpio3 node also be marked with bootph-pre-ram so that
reg_usdhc2_vmmc can resolve its GPIO dependency?

[ ... ]

> @@ -996,6 +1008,7 @@ &usdhc2 {
>  	pinctrl-3 = <&pinctrl_usdhc2>, <&pinctrl_usdhc2_gpio>;
>  	pinctrl-names = "default", "state_100mhz", "state_200mhz", "sleep";
>  	vmmc-supply = <&reg_usdhc2_vmmc>;
> +	bootph-pre-ram;
>  	status = "okay";
>  };

[Severity: Medium]
Similarly to the regulator, usdhc2 relies on gpio3 for card detect during the
boot process (cd-gpios = <&gpio3 00 GPIO_ACTIVE_LOW>).

If the gpio3 node is missing from the SPL device tree, will usdhc2 fail to
probe during early boot because it cannot resolve the cd-gpios property?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261012-bootph-frdm-imx95-pro-v1-1-6757c5f04a17@nxp.com?part=1