From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D0B5CA9ED5 for ; Mon, 12 Oct 2026 07:13:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=u4UtOwuLGYzDJEKUPK/q/B2xRVAlcNnsZ4MgI2af7wE=; b=meta2qDfflf4GV 1MAxXKSfa44COXeDC5JGZv5v5EMbQ61CeBAUVOMDmLWq3rXVAOpcSUgD4oCKpPGO4CQ3pq7sUR6Nk P6py24FkgX3kbzmQfIH6rdnqDfis8alCjtOj0AP43pS64dtG9TeVMNPfRQ+Qodmha8lzl8zjmfhOf wO7v5ZWN0bkDSjlM0Ima+Ub7s5CXiaAv/Nt8x2vAH8+BXkaZIUWjiHfsxarbV21LVpYZriQbs6RUE fXLfk3Kutl6MkrOa8j78a6ANov5sY3dC1gpDu0wOiJ3g3YyE+2m15abd3mA2LHRsFY723wIgWJzpu bYgvo+xX8JVMUXe/zPTg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xGAE1-00000009p3v-1X9z; Mon, 12 Oct 2026 07:13:33 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xGADz-00000009p3l-3bxN for linux-amlogic@lists.infradead.org; Mon, 12 Oct 2026 07:13:31 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id F226860AB5; Mon, 12 Oct 2026 07:13:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42DAE1F0089B; Mon, 12 Oct 2026 07:13:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791789210; bh=Wk1YgX+JwCRBoXgwopV5P61jFYBRUySBF7WBFxlgVew=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=ZM13eROdScVRAzK9s0LSvEzS8nRPGqWXeWc8V9GqGDPhz7ABL02viU1joahrwLBkq Jrdg3Hoi13q3GiYGmorTpiGgXB7fj07MGqTArICuYc6DxvmLFua0j/jhrFVTeqg/jO V8ZBF769k3rq160QKg3ZVqtgfxmvCWfRMVmIi0M8dzv9OkmwKS23b3yjsq9SRA8CY9 IzkdFafUDCmNOUSFWnhRd61eYhafkkiI4rlhf2uwGwebEMH4j6iLQS1gexkjyP8yI9 HcDwt3lqB4sXmZ/rBlinm755/Y3KdBnmVhvSZqn3ugj654CQDFb2gLHko+okoUzGqe 5+2EOjlg0FAwQ== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v11 3/6] media: dt-bindings: Add Amlogic V4L2 video decoder To: "Zhentao Guo" Cc: linux-amlogic@lists.infradead.org, neil.armstrong@linaro.org, conor+dt@kernel.org, media-ci@linuxtv.org, devicetree@vger.kernel.org, robh@kernel.org In-Reply-To: <20261012-b4-s4-vdec-upstream-v11-3-25939f85ada5@amlogic.com> References: <20261012-b4-s4-vdec-upstream-v11-0-25939f85ada5@amlogic.com> <20261012-b4-s4-vdec-upstream-v11-3-25939f85ada5@amlogic.com> Date: Mon, 12 Oct 2026 07:13:29 +0000 X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0xvd10gZHQtYmluZGluZ3M6IG1l ZGlhOiBhbWxvZ2ljLHM0LXZkZWM6IGluY29tcGxldGUgdmFsaWRhdGlvbiBmb3IgaW50ZXJydXB0 cyBhcnJheSBhbmQgbmFtZXMKLS0KCmNvbW1pdCAwYzgxMDllNjVhYjE2NGRmODJiMGM4MDBjYTYy MWJiZTk4ZWQxNWY3CkF1dGhvcjogWmhlbnRhbyBHdW8gPHpoZW50YW8uZ3VvQGFtbG9naWMuY29t PgoKbWVkaWE6IGR0LWJpbmRpbmdzOiBBZGQgQW1sb2dpYyBWNEwyIHZpZGVvIGRlY29kZXIKClRo aXMgcGF0Y2ggYWRkcyB0aGUgZGV2aWNlIHRyZWUgYmluZGluZyBzY2hlbWEgZm9yIHRoZSBBbWxv Z2ljIGhhcmR3YXJlCmRlY29kZXIgYWNjZWxlcmF0b3IuIFRoZSBkZXZpY2Ugc3VwcG9ydHMgc3Rh dGVsZXNzIEguMjY0IGRlY29kaW5nIG9uCkFtbG9naWMgU29Dcy4KCj4gZGlmZiAtLWdpdCBhL0Rv Y3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9tZWRpYS9hbWxvZ2ljLHM0LXZkZWMueWFt bCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9tZWRpYS9hbWxvZ2ljLHM0LXZk ZWMueWFtbAo+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4gaW5kZXggMDAwMDAwMDAwMDAwMC4uNzVi OWJhM2NiMDhkMgo+IC0tLSAvZGV2L251bGwKPiArKysgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRy ZWUvYmluZGluZ3MvbWVkaWEvYW1sb2dpYyxzNC12ZGVjLnlhbWwKPiBAQCAtMCwwICsxLDExNCBA QApbIC4uLiBdCj4gKyAgaW50ZXJydXB0czoKPiArICAgIG1heEl0ZW1zOiAyCj4gKwo+ICsgIGlu dGVycnVwdC1uYW1lczoKPiArICAgIGl0ZW1zOgo+ICsgICAgICAtIGNvbnN0OiBodmRlYwo+ICsg ICAgICAtIGNvbnN0OiB2ZGVjCgpbU2V2ZXJpdHk6IExvd10KRG9lcyB0aGUgc2NoZW1hIG5lZWQg bWluSXRlbXM6IDIgaGVyZSBmb3IgdGhlIGludGVycnVwdHMgYXJyYXk/IFdpdGhvdXQgaXQsCmFu IGluY29tcGxldGUgbm9kZSB3aXRoIG9ubHkgMSBpbnRlcnJ1cHQgd2lsbCBwYXNzIHNjaGVtYSBj aGVja3Mgd2hpbGUgc3RpbGwKZmFpbGluZyBhdCB0aGUgZHJpdmVyIGxldmVsIHdoZW4gaW5kZXgg MSBpcyByZXF1ZXN0ZWQuCgpbIC4uLiBdCj4gK3JlcXVpcmVkOgo+ICsgIC0gY29tcGF0aWJsZQo+ ICsgIC0gcmVnCj4gKyAgLSByZWctbmFtZXMKPiArICAtIGludGVycnVwdHMKPiArICAtIGNsb2Nr cwo+ICsgIC0gY2xvY2stbmFtZXMKPiArICAtIHBvd2VyLWRvbWFpbnMKPiArICAtIHBvd2VyLWRv bWFpbi1uYW1lcwo+ICsgIC0gcmVzZXRzCj4gKyAgLSBhbWxvZ2ljLGNhbnZhcwo+ICsgIC0gYW1s b2dpYyxzZWN1cmUtbW9uaXRvcgoKW1NldmVyaXR5OiBMb3ddCklzIGludGVycnVwdC1uYW1lcyBt aXNzaW5nIGZyb20gdGhpcyByZXF1aXJlZCBsaXN0PwoKTGVhdmluZyBpdCBvdXQgcGVybWl0cyBp bmNvbXBsZXRlIGNvbmZpZ3VyYXRpb25zIHRvIHNpbGVudGx5IHBhc3Mgc2NoZW1hCnZhbGlkYXRp b24gKGR0X2JpbmRpbmdfY2hlY2spLiBJZiB0aGUgZHJpdmVyIGZldGNoZXMgdGhlIGludGVycnVw dCBwdXJlbHkKYnkgaW5kZXggKGUuZy4gcGxhdGZvcm1fZ2V0X2lycShwZGV2LCBJUlFfVkRFQykg d2hlcmUgSVJRX1ZERUMgaXMgZW51bSAxKSwKb21pdHRpbmcgaW50ZXJydXB0LW5hbWVzIGZyb20g dGhlIHJlcXVpcmVtZW50cyBhbGxvd3MgZGV2aWNlIHRyZWUgYXV0aG9ycwp0byBlYXNpbHkgbWlz cyB0aGUgY29ycmVjdCBvcmRlcmluZyBvciBwcm92aWRlIG9ubHkgb25lIGludGVycnVwdCwgbGVh ZGluZwpkaXJlY3RseSB0byBkcml2ZXIgcHJvYmUgZmFpbHVyZXMgb3IgaW5jb3JyZWN0IGludGVy cnVwdCByb3V0aW5nIGF0IHJ1bnRpbWUuCgpbIC4uLiBdCj4gKyAgICAgIHJlZy1uYW1lcyA9ICJk b3MiLAo+ICsgICAgICAgICAgICAgICAgICAiZG1jIjsKPiArICAgICAgaW50ZXJydXB0cyA9IDxH SUNfU1BJIDkxIElSUV9UWVBFX0VER0VfUklTSU5HPiwKPiArICAgICAgICAgICAgICAgICAgIDxH SUNfU1BJIDkyIElSUV9UWVBFX0VER0VfUklTSU5HPjsKPiArICAgICAgY2xvY2tzID0gPCZjbGtj X3BlcmlwaHMgQ0xLSURfRE9TPiwKCltTZXZlcml0eTogTG93XQpTaG91bGQgaW50ZXJydXB0LW5h bWVzIGJlIGluY2x1ZGVkIGluIHRoaXMgZXhhbXBsZT8KClRoZSBleGFtcGxlIGN1cnJlbnRseSBv bWl0cyBpbnRlcnJ1cHQtbmFtZXMgY29tcGxldGVseSwgZGVtb25zdHJhdGluZyBob3cgYQpmdW5j dGlvbmFsbHkgaW5jb21wbGV0ZSBub2RlIGlzIHBlcm1pdHRlZCBieSB0aGUgc2NoZW1hLgoKLS0g ClNhc2hpa28gQUkgcmV2aWV3IMK3IGh0dHBzOi8vc2FzaGlrby5kZXYvIy9wYXRjaHNldC8yMDI2 MTAxMi1iNC1zNC12ZGVjLXVwc3RyZWFtLXYxMS0wLTI1OTM5Zjg1YWRhNUBhbWxvZ2ljLmNvbT9w YXJ0PTMKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxp bnV4LWFtbG9naWMgbWFpbGluZyBsaXN0CmxpbnV4LWFtbG9naWNAbGlzdHMuaW5mcmFkZWFkLm9y ZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFtbG9n aWMK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A60E344DB5 for ; Mon, 12 Oct 2026 07:13:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791789212; cv=none; b=YlwuQXmN0qEkurehEZfReeSkBQCdSSBaAezR8Law9uWYVPH9as8YAMqSA90nx79sICpkZJz6XIAYk0rIeX5Gq8HIaJqfxpidF0Wl9/TNmfFY9ZGBn8LlIzgGJLXPqktcEo/1T1d/YCXzFmdxvRNbYL+sTIxgvioGAlTcnordgjk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791789212; c=relaxed/simple; bh=DGvkmq4+EjnMEWjQSxuCoRxOcpwv8WQRcJXTyLtuE+0=; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type: Date; b=ilbgghexHd91TCMxoD/I539MQghlS54HJev10wNHenz9/iLUVw3JqJFgV2Rfh9oZbl2hayFSCTGXMrsCABcW2owS0tKPOh26f+SLI4WW4ftOAt44K23yad7EmQdn4R832lgZUib6UTu930XxojyzFEZOowHaAGoB33wLDMYrmh4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZM13eROd; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZM13eROd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42DAE1F0089B; Mon, 12 Oct 2026 07:13:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791789210; bh=Wk1YgX+JwCRBoXgwopV5P61jFYBRUySBF7WBFxlgVew=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=ZM13eROdScVRAzK9s0LSvEzS8nRPGqWXeWc8V9GqGDPhz7ABL02viU1joahrwLBkq Jrdg3Hoi13q3GiYGmorTpiGgXB7fj07MGqTArICuYc6DxvmLFua0j/jhrFVTeqg/jO V8ZBF769k3rq160QKg3ZVqtgfxmvCWfRMVmIi0M8dzv9OkmwKS23b3yjsq9SRA8CY9 IzkdFafUDCmNOUSFWnhRd61eYhafkkiI4rlhf2uwGwebEMH4j6iLQS1gexkjyP8yI9 HcDwt3lqB4sXmZ/rBlinm755/Y3KdBnmVhvSZqn3ugj654CQDFb2gLHko+okoUzGqe 5+2EOjlg0FAwQ== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v11 3/6] media: dt-bindings: Add Amlogic V4L2 video decoder Reply-To: sashiko-reviews@lists.linux.dev To: "Zhentao Guo" Cc: linux-amlogic@lists.infradead.org, neil.armstrong@linaro.org, conor+dt@kernel.org, media-ci@linuxtv.org, devicetree@vger.kernel.org, robh@kernel.org In-Reply-To: <20261012-b4-s4-vdec-upstream-v11-3-25939f85ada5@amlogic.com> References: <20261012-b4-s4-vdec-upstream-v11-0-25939f85ada5@amlogic.com> <20261012-b4-s4-vdec-upstream-v11-3-25939f85ada5@amlogic.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 12 Oct 2026 07:13:29 +0000 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] dt-bindings: media: amlogic,s4-vdec: incomplete validation for inte= rrupts array and names -- commit 0c8109e65ab164df82b0c800ca621bbe98ed15f7 Author: Zhentao Guo media: dt-bindings: Add Amlogic V4L2 video decoder This patch adds the device tree binding schema for the Amlogic hardware decoder accelerator. The device supports stateless H.264 decoding on Amlogic SoCs. > diff --git a/Documentation/devicetree/bindings/media/amlogic,s4-vdec.yaml= b/Documentation/devicetree/bindings/media/amlogic,s4-vdec.yaml > new file mode 100644 > index 0000000000000..75b9ba3cb08d2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/amlogic,s4-vdec.yaml > @@ -0,0 +1,114 @@ [ ... ] > + interrupts: > + maxItems: 2 > + > + interrupt-names: > + items: > + - const: hvdec > + - const: vdec [Severity: Low] Does the schema need minItems: 2 here for the interrupts array? Without it, an incomplete node with only 1 interrupt will pass schema checks while still failing at the driver level when index 1 is requested. [ ... ] > +required: > + - compatible > + - reg > + - reg-names > + - interrupts > + - clocks > + - clock-names > + - power-domains > + - power-domain-names > + - resets > + - amlogic,canvas > + - amlogic,secure-monitor [Severity: Low] Is interrupt-names missing from this required list? Leaving it out permits incomplete configurations to silently pass schema validation (dt_binding_check). If the driver fetches the interrupt purely by index (e.g. platform_get_irq(pdev, IRQ_VDEC) where IRQ_VDEC is enum 1), omitting interrupt-names from the requirements allows device tree authors to easily miss the correct ordering or provide only one interrupt, leading directly to driver probe failures or incorrect interrupt routing at runtime. [ ... ] > + reg-names =3D "dos", > + "dmc"; > + interrupts =3D , > + ; > + clocks =3D <&clkc_periphs CLKID_DOS>, [Severity: Low] Should interrupt-names be included in this example? The example currently omits interrupt-names completely, demonstrating how a functionally incomplete node is permitted by the schema. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261012-b4-s4-vdec= -upstream-v11-0-25939f85ada5@amlogic.com?part=3D3