From: sashiko-bot@kernel.org
To: "Sandipan Das" <sandipan.das@amd.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 3/3] perf vendor events amd: Remove "PerPkg" from Zen 6 memory controller metrics
Date: Mon, 12 Oct 2026 07:59:11 +0000 [thread overview]
Message-ID: <sashiko-outbox-167817@kernel.org> (raw)
In-Reply-To: <8f22b9814dbe0014a1486a9510da3bb48ba8aeb1.1791791463.git.sandipan.das@amd.com>
> "PerPkg" is an event attribute and has no effect on metrics. Remove it
> from the Zen 6 memory controller metrics for consistency with the data
> fabric metrics, which do not set it.
>
> The "PerPkg" setting on the underlying events remains correct on Zen 6.
> perf de-duplicates "PerPkg" counts by socket and die, and on AMD
> processors these are the same domain. Each UMC PMU instance belongs to
> a single IOD, so the CPUs it counts on always share the same socket and
> die. De-duplication therefore never merges counts from different IODs,
> unlike the single Data Fabric PMU, which spans both IODs in a socket.
>
> Signed-off-by: Sandipan Das <sandipan.das@amd.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1791791463.git.sandipan.das@amd.com?part=3
next prev parent reply other threads:[~2026-10-12 7:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 7:53 [PATCH 0/3] perf vendor events amd: Add Zen 6 data fabric events and metrics Sandipan Das
2026-10-12 7:53 ` [PATCH 1/3] perf vendor events amd: Add Zen 6 data fabric events Sandipan Das
2026-10-12 7:59 ` sashiko-bot
2026-10-12 7:53 ` [PATCH 2/3] perf vendor events amd: Add Zen 6 data fabric metrics Sandipan Das
2026-10-12 8:02 ` sashiko-bot
2026-10-12 7:53 ` [PATCH 3/3] perf vendor events amd: Remove "PerPkg" from Zen 6 memory controller metrics Sandipan Das
2026-10-12 7:59 ` sashiko-bot [this message]
2026-10-12 21:00 ` [PATCH 0/3] perf vendor events amd: Add Zen 6 data fabric events and metrics Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-167817@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=sandipan.das@amd.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.