From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1282433C1BE for ; Mon, 12 Oct 2026 08:15:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791792951; cv=none; b=rR6lB+syGVGGEeYnr3xQysW4LZvNEkdlkAdWb2iesA4MhjnlA6k+g75himiMLcr8OSpiKf0H2l0qxfLv7DmKX3oetFCwidhGwu4ylVnZUuIaKg/dEPsMSpIMtJszVjn/zb7czM42hXQITMat2LzyTFTdLKNq3ylevWt0mcX42Xw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791792951; c=relaxed/simple; bh=yHW9YGMjVKLHQHBQzk2U9y+gnTYtfc23B8grb8VNHQQ=; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type: Date; b=Uh7/F2Sgt4QlWso0ty14l+OpCXnJj/tcE1aQ5+fVU8rXb3yK8BCYn13AHE/umJNimE+HS6Cn20SRFDnChymRnZEUnK1qjzWeF+k+6ziK+/+CK1zvm2LsGMrVMQA1RHicYbMphIbDHBbAS6lDf6Zq4hC65r5HWZV4irK6B4jR6w8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=I0rKPpdA; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="I0rKPpdA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 518691F0089C; Mon, 12 Oct 2026 08:15:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791792949; bh=RPr+QclsJzPOVUXH7iy1yxBLvSkFSB9zf6ErqWEqDTg=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=I0rKPpdAMALZRz2yQqPMIchkRmAsy+yldNw6Uu2+YWmWJk3FhzM3ybeu9oTdVOIhj Sq11gkoJTJK5E5tvt/l9BYTMgsQx3Xnqg0JRWstP4q4FT5AKcKdUw81g+7K+3KCUuh 7x+Ou96+y43gVIJ9myqk4DE79wYgu9Wc+/ebdoXUyCJALXMXK8XzgrOFU0w5wnTWJb sgZ5mT0B+gumfBawBSI3gku9os01CEvcJothKrRHfpXJ2HU3hs9AZL+35OTWzSNis4 DB6MJJD3Xte8ZFROYZGeQQPEb13LI7VAvt5rtVOvqs1T787k0M53qfHNI/ItlJlQZ5 JEBge0jkTbn8Q== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH 2/3] phy: cix: Add Sky1 DP PHY driver Reply-To: sashiko-reviews@lists.linux.dev To: "Luo Liu" Cc: devicetree@vger.kernel.org, linux-phy@lists.infradead.org, olteanv@gmail.com, vkoul@kernel.org, conor+dt@kernel.org, neil.armstrong@linaro.org, robh@kernel.org In-Reply-To: <20261012080517.566920-3-Luo.Liu@cixtech.com> References: <20261012080517.566920-1-Luo.Liu@cixtech.com> <20261012080517.566920-3-Luo.Liu@cixtech.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 12 Oct 2026 08:15:48 +0000 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] phy: cix: premature hardware ready polling in CDB transactions -- commit 9a56e63287f31e17b6e8c0dd1873f84b0c04b8d1 Author: Luo Liu phy: cix: Add Sky1 DP PHY driver Add a PHY driver for the CIX Sky1 dedicated DisplayPort PMA. Support link rate, lane count, SSC and voltage swing via the generic PHY DP ops. > diff --git a/drivers/phy/cix/phy-cix-dp.c b/drivers/phy/cix/phy-cix-dp.c > new file mode 100644 > index 0000000000000..b5adc9c295060 > --- /dev/null > +++ b/drivers/phy/cix/phy-cix-dp.c [ ... ] > +static int cix_dp_phy_cdb_write(struct cix_dp *dp, u32 offset, u32 data) > +{ > + int ret; > + > + ret =3D cix_dp_phy_cdb_ready(dp); > + if (ret) > + return ret; > + > + writel(offset, dp->base + CIX_DP_CDB_ADDR); > + writel(data, dp->base + CIX_DP_CDB_WDATA); > + writel(CIX_DP_CDB_SEL_WRITE, dp->base + CIX_DP_CDB_SEL_WR); > + writel(1, dp->base + CIX_DP_CDB_ENABLE); > + > + return cix_dp_phy_cdb_ready(dp); [Severity: Medium] Is there a risk of a race condition here if the hardware takes a few clock cycles to pull the CIX_DP_CDB_READY bit low after CIX_DP_CDB_ENABLE is set? Because cix_dp_phy_cdb_ready() uses readl_poll_timeout(), it immediately performs a read. If the PHY IP drops the ready bit asynchronously (e.g., due to a clock domain crossing), the CPU might read the stale idle state where the ready bit is still 1 and return success instantly. This could cause the write operation to return before the hardware transaction actually completes, potentially overlapping with the next transaction and corrupting PHY configuration. > +} > + > +static int cix_dp_phy_cdb_read(struct cix_dp *dp, u32 offset) > +{ > + int ret; > + > + ret =3D cix_dp_phy_cdb_ready(dp); > + if (ret) > + return ret; > + > + writel(offset, dp->base + CIX_DP_CDB_ADDR); > + writel(CIX_DP_CDB_SEL_READ, dp->base + CIX_DP_CDB_SEL_WR); > + writel(1, dp->base + CIX_DP_CDB_ENABLE); > + > + ret =3D cix_dp_phy_cdb_ready(dp); > + if (ret) > + return ret; > + > + return readl(dp->base + CIX_DP_CDB_RDATA) & GENMASK(15, 0); [Severity: Medium] Similarly, could this early ready check cause cix_dp_phy_cdb_read() to read stale data? If the hardware hasn't pulled the ready bit to 0 yet, cix_dp_phy_cdb_ready() will return 0 immediately and we will read CIX_DP_CDB_RDATA before the hardware has actually populated it. > +} [ ... ] --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261012080517.5669= 20-1-Luo.Liu@cixtech.com?part=3D2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CA211CA9EC5 for ; Mon, 12 Oct 2026 08:15:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iMr8xLjnK++VzvhgCLXfEP+4o1UpFIRSO2cRgQtUeQ0=; b=sVYW8VxeZPwCQ8 zlSAXysluF2XS28H/HmWhIBDLdbDFc3kgAgC1FTNy74GsDPKziuWAjsoMIn58Ysm96CThCbL0hbUu WuGymUKfwI7ac4sg5olxRj6xVcICn4BsP2SvaUnryoIlCNgAqYi68feT5SOOaFJw9VlZMik28qb1s az3AiIsIIdGv5uJOkpRyBMte7fOC4ntkPoS3VDT86ss6iM0evWPUYEOpNBu+uwPVd8uH5WYAxymro 6Ez11H8N1MEjYIDZ/D6A+pLuEcmLlGanDaoJ0DYkdu+DlwK1GcufbuluwR7YcBunpa+34iQy66K1l Sp18/AsMeOJxylbbq4IA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xGBCK-00000009ulR-0m8T; Mon, 12 Oct 2026 08:15:52 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xGBCI-00000009ukz-2dfw for linux-phy@lists.infradead.org; Mon, 12 Oct 2026 08:15:50 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id D897044859; Mon, 12 Oct 2026 08:15:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 518691F0089C; Mon, 12 Oct 2026 08:15:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791792949; bh=RPr+QclsJzPOVUXH7iy1yxBLvSkFSB9zf6ErqWEqDTg=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=I0rKPpdAMALZRz2yQqPMIchkRmAsy+yldNw6Uu2+YWmWJk3FhzM3ybeu9oTdVOIhj Sq11gkoJTJK5E5tvt/l9BYTMgsQx3Xnqg0JRWstP4q4FT5AKcKdUw81g+7K+3KCUuh 7x+Ou96+y43gVIJ9myqk4DE79wYgu9Wc+/ebdoXUyCJALXMXK8XzgrOFU0w5wnTWJb sgZ5mT0B+gumfBawBSI3gku9os01CEvcJothKrRHfpXJ2HU3hs9AZL+35OTWzSNis4 DB6MJJD3Xte8ZFROYZGeQQPEb13LI7VAvt5rtVOvqs1T787k0M53qfHNI/ItlJlQZ5 JEBge0jkTbn8Q== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH 2/3] phy: cix: Add Sky1 DP PHY driver To: "Luo Liu" Cc: devicetree@vger.kernel.org, linux-phy@lists.infradead.org, olteanv@gmail.com, vkoul@kernel.org, conor+dt@kernel.org, neil.armstrong@linaro.org, robh@kernel.org In-Reply-To: <20261012080517.566920-3-Luo.Liu@cixtech.com> References: <20261012080517.566920-1-Luo.Liu@cixtech.com> <20261012080517.566920-3-Luo.Liu@cixtech.com> Date: Mon, 12 Oct 2026 08:15:48 +0000 X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW01lZGl1bV0gcGh5OiBjaXg6IHBy ZW1hdHVyZSBoYXJkd2FyZSByZWFkeSBwb2xsaW5nIGluIENEQiB0cmFuc2FjdGlvbnMKLS0KCmNv bW1pdCA5YTU2ZTYzMjg3ZjMxZTE3YjZlOGMwZGQxODczZjg0YjBjMDRiOGQxCkF1dGhvcjogTHVv IExpdSA8THVvLkxpdUBjaXh0ZWNoLmNvbT4KCnBoeTogY2l4OiBBZGQgU2t5MSBEUCBQSFkgZHJp dmVyCgpBZGQgYSBQSFkgZHJpdmVyIGZvciB0aGUgQ0lYIFNreTEgZGVkaWNhdGVkIERpc3BsYXlQ b3J0IFBNQS4gU3VwcG9ydApsaW5rIHJhdGUsIGxhbmUgY291bnQsIFNTQyBhbmQgdm9sdGFnZSBz d2luZyB2aWEgdGhlIGdlbmVyaWMgUEhZIERQCm9wcy4KCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv cGh5L2NpeC9waHktY2l4LWRwLmMgYi9kcml2ZXJzL3BoeS9jaXgvcGh5LWNpeC1kcC5jCj4gbmV3 IGZpbGUgbW9kZSAxMDA2NDQKPiBpbmRleCAwMDAwMDAwMDAwMDAwLi5iNWFkYzljMjk1MDYwCj4g LS0tIC9kZXYvbnVsbAo+ICsrKyBiL2RyaXZlcnMvcGh5L2NpeC9waHktY2l4LWRwLmMKWyAuLi4g XQo+ICtzdGF0aWMgaW50IGNpeF9kcF9waHlfY2RiX3dyaXRlKHN0cnVjdCBjaXhfZHAgKmRwLCB1 MzIgb2Zmc2V0LCB1MzIgZGF0YSkKPiArewo+ICsJaW50IHJldDsKPiArCj4gKwlyZXQgPSBjaXhf ZHBfcGh5X2NkYl9yZWFkeShkcCk7Cj4gKwlpZiAocmV0KQo+ICsJCXJldHVybiByZXQ7Cj4gKwo+ ICsJd3JpdGVsKG9mZnNldCwgZHAtPmJhc2UgKyBDSVhfRFBfQ0RCX0FERFIpOwo+ICsJd3JpdGVs KGRhdGEsIGRwLT5iYXNlICsgQ0lYX0RQX0NEQl9XREFUQSk7Cj4gKwl3cml0ZWwoQ0lYX0RQX0NE Ql9TRUxfV1JJVEUsIGRwLT5iYXNlICsgQ0lYX0RQX0NEQl9TRUxfV1IpOwo+ICsJd3JpdGVsKDEs IGRwLT5iYXNlICsgQ0lYX0RQX0NEQl9FTkFCTEUpOwo+ICsKPiArCXJldHVybiBjaXhfZHBfcGh5 X2NkYl9yZWFkeShkcCk7CgpbU2V2ZXJpdHk6IE1lZGl1bV0KSXMgdGhlcmUgYSByaXNrIG9mIGEg cmFjZSBjb25kaXRpb24gaGVyZSBpZiB0aGUgaGFyZHdhcmUgdGFrZXMgYSBmZXcgY2xvY2sKY3lj bGVzIHRvIHB1bGwgdGhlIENJWF9EUF9DREJfUkVBRFkgYml0IGxvdyBhZnRlciBDSVhfRFBfQ0RC X0VOQUJMRSBpcyBzZXQ/CgpCZWNhdXNlIGNpeF9kcF9waHlfY2RiX3JlYWR5KCkgdXNlcyByZWFk bF9wb2xsX3RpbWVvdXQoKSwgaXQgaW1tZWRpYXRlbHkKcGVyZm9ybXMgYSByZWFkLiBJZiB0aGUg UEhZIElQIGRyb3BzIHRoZSByZWFkeSBiaXQgYXN5bmNocm9ub3VzbHkgKGUuZy4sCmR1ZSB0byBh IGNsb2NrIGRvbWFpbiBjcm9zc2luZyksIHRoZSBDUFUgbWlnaHQgcmVhZCB0aGUgc3RhbGUgaWRs ZSBzdGF0ZQp3aGVyZSB0aGUgcmVhZHkgYml0IGlzIHN0aWxsIDEgYW5kIHJldHVybiBzdWNjZXNz IGluc3RhbnRseS4KClRoaXMgY291bGQgY2F1c2UgdGhlIHdyaXRlIG9wZXJhdGlvbiB0byByZXR1 cm4gYmVmb3JlIHRoZSBoYXJkd2FyZQp0cmFuc2FjdGlvbiBhY3R1YWxseSBjb21wbGV0ZXMsIHBv dGVudGlhbGx5IG92ZXJsYXBwaW5nIHdpdGggdGhlIG5leHQKdHJhbnNhY3Rpb24gYW5kIGNvcnJ1 cHRpbmcgUEhZIGNvbmZpZ3VyYXRpb24uCgo+ICt9Cj4gKwo+ICtzdGF0aWMgaW50IGNpeF9kcF9w aHlfY2RiX3JlYWQoc3RydWN0IGNpeF9kcCAqZHAsIHUzMiBvZmZzZXQpCj4gK3sKPiArCWludCBy ZXQ7Cj4gKwo+ICsJcmV0ID0gY2l4X2RwX3BoeV9jZGJfcmVhZHkoZHApOwo+ICsJaWYgKHJldCkK PiArCQlyZXR1cm4gcmV0Owo+ICsKPiArCXdyaXRlbChvZmZzZXQsIGRwLT5iYXNlICsgQ0lYX0RQ X0NEQl9BRERSKTsKPiArCXdyaXRlbChDSVhfRFBfQ0RCX1NFTF9SRUFELCBkcC0+YmFzZSArIENJ WF9EUF9DREJfU0VMX1dSKTsKPiArCXdyaXRlbCgxLCBkcC0+YmFzZSArIENJWF9EUF9DREJfRU5B QkxFKTsKPiArCj4gKwlyZXQgPSBjaXhfZHBfcGh5X2NkYl9yZWFkeShkcCk7Cj4gKwlpZiAocmV0 KQo+ICsJCXJldHVybiByZXQ7Cj4gKwo+ICsJcmV0dXJuIHJlYWRsKGRwLT5iYXNlICsgQ0lYX0RQ X0NEQl9SREFUQSkgJiBHRU5NQVNLKDE1LCAwKTsKCltTZXZlcml0eTogTWVkaXVtXQpTaW1pbGFy bHksIGNvdWxkIHRoaXMgZWFybHkgcmVhZHkgY2hlY2sgY2F1c2UgY2l4X2RwX3BoeV9jZGJfcmVh ZCgpIHRvCnJlYWQgc3RhbGUgZGF0YT8KCklmIHRoZSBoYXJkd2FyZSBoYXNuJ3QgcHVsbGVkIHRo ZSByZWFkeSBiaXQgdG8gMCB5ZXQsCmNpeF9kcF9waHlfY2RiX3JlYWR5KCkgd2lsbCByZXR1cm4g MCBpbW1lZGlhdGVseSBhbmQgd2Ugd2lsbCByZWFkCkNJWF9EUF9DREJfUkRBVEEgYmVmb3JlIHRo ZSBoYXJkd2FyZSBoYXMgYWN0dWFsbHkgcG9wdWxhdGVkIGl0LgoKPiArfQpbIC4uLiBdCgotLSAK U2FzaGlrbyBBSSByZXZpZXcgwrcgaHR0cHM6Ly9zYXNoaWtvLmRldi8jL3BhdGNoc2V0LzIwMjYx MDEyMDgwNTE3LjU2NjkyMC0xLUx1by5MaXVAY2l4dGVjaC5jb20/cGFydD0yCgotLSAKbGludXgt cGh5IG1haWxpbmcgbGlzdApsaW51eC1waHlAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwczovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1waHkK