From: sashiko-bot@kernel.org
To: "Heiko Carstens" <hca@linux.ibm.com>
Cc: "Vasily Gorbik" <gor@linux.ibm.com>,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Heiko Carstens" <hca@linux.ibm.com>,
linux-s390@vger.kernel.org,
"Christian Borntraeger" <borntraeger@linux.ibm.com>
Subject: Re: [PATCH 2/3] s390/probes: Add missing fixup for bctgr and bic
Date: Mon, 12 Oct 2026 08:46:04 +0000 [thread overview]
Message-ID: <sashiko-outbox-167861@kernel.org> (raw)
In-Reply-To: <20261012083629.2109206-3-hca@linux.ibm.com>
> For the bctgr and bic instructions the probes fixup is missing.
> For both instructions the instruction address must only be fixed up
> if the branch is not taken. If the branch is taken the instruction
> address is already correct.
>
> Return FIXUP_BRANCH_NOT_TAKEN instead of the default FIXUP_PSW_NORMAL
> to reflect that.
>
> Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261012083629.2109206-1-hca@linux.ibm.com?part=2
next prev parent reply other threads:[~2026-10-12 8:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 8:36 [PATCH 0/3] s390/probes: Various fixes Heiko Carstens
2026-10-12 8:36 ` [PATCH 1/3] s390/probes: Fix wrong opcode for cgrb fixup Heiko Carstens
2026-10-12 8:41 ` sashiko-bot
2026-10-12 8:36 ` [PATCH 2/3] s390/probes: Add missing fixup for bctgr and bic Heiko Carstens
2026-10-12 8:46 ` sashiko-bot [this message]
2026-10-12 8:36 ` [PATCH 3/3] s390/probes: Fix wrong mnemonic comment for clgib Heiko Carstens
2026-10-12 8:38 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-167861@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.