From: sashiko-bot@kernel.org
To: "Chen-Yu Tsai" <wenst@chromium.org>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH v4] usb: hub: Set proper message when usb_hub_create_port_device() fails
Date: Mon, 12 Oct 2026 09:33:19 +0000 [thread overview]
Message-ID: <sashiko-outbox-167901@kernel.org> (raw)
In-Reply-To: <20261012092725.575885-1-wenst@chromium.org>
> Right now when usb_hub_create_port_device() fails, it prints a separate
> error message to say which port failed, but otherwise leaves |message|
> set to the default "out of memory", which is somewhat misleading.
>
> Set |message| to an error message that is more specific to this error
> path instead of using the default "out of memory" message.
>
> Assisted-by: LLM # local reviews
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261012092725.575885-1-wenst@chromium.org?part=1
next prev parent reply other threads:[~2026-10-12 9:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 9:27 [PATCH v4] usb: hub: Set proper message when usb_hub_create_port_device() fails Chen-Yu Tsai
2026-10-12 9:33 ` sashiko-bot [this message]
2026-10-12 20:53 ` Andy Shevchenko
2026-10-12 21:24 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-167901@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.