From: sashiko-bot@kernel.org
To: "Alexandre Cassen" <acassen@corp.free.fr>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH net v2 1/2] net/mlx5: HWS, fix modify header pattern compare on big-endian
Date: Mon, 12 Oct 2026 10:32:20 +0000 [thread overview]
Message-ID: <sashiko-outbox-167959@kernel.org> (raw)
In-Reply-To: <20261012101937.1335231-2-acassen@corp.free.fr>
> mlx5hws_pat_compare_pattern() casts each __be64 action to __be32 to
> compare only its control dword. On big-endian this keeps the data dword
> instead, which HWS clears from the pattern of set and add actions. Two
> such actions writing the same value into different fields then share a
> pattern and the second rule modifies the wrong field.
>
> Read the first dword of each action from memory instead. Little-endian
> behavior is unchanged.
>
> Discovered by an AI code review agent [1] and confirmed by code
> inspection. Not reproduced for lack of big-endian hardware running HWS.
>
> Fixes: aefc15a0fa1c ("net/mlx5: HWS, added modify header pattern and args handling")
> Link: https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261010120147.135825-1-acassen%40corp.free.fr [1]
> Signed-off-by: Alexandre Cassen <acassen@corp.free.fr>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261012101937.1335231-1-acassen@corp.free.fr?part=1
next prev parent reply other threads:[~2026-10-12 10:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 10:19 [PATCH net v2 0/2] net/mlx5: HWS, fix modify header pattern compare Alexandre Cassen
2026-10-12 10:19 ` [PATCH net v2 1/2] net/mlx5: HWS, fix modify header pattern compare on big-endian Alexandre Cassen
2026-10-12 10:32 ` sashiko-bot [this message]
2026-10-12 10:19 ` [PATCH net v2 2/2] net/mlx5: HWS, fix modify header pool match for copy actions Alexandre Cassen
2026-10-12 10:32 ` sashiko-bot
2026-10-12 10:24 ` [PATCH net v2 0/2] net/mlx5: HWS, fix modify header pattern compare netdev-bot+sinfo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-167959@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=acassen@corp.free.fr \
--cc=linux-rdma@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.