Re: [PATCH RFC 24/28] selftests/filesystems: test filesystem errors while frozen

[sashiko-bot@kernel.org]

> Add tests for filesystems that hit an error while they are frozen:
> 
> - ext2, jfs and nilfs2: corrupt a directory, look up a file in it while
>   frozen, thaw
> - superblock stays read-write and shows "emergency_ro"
> - create, write through an earlier opened fd, chmod, mkdir, rename,
>   unlink, truncate and write opens fail with EROFS instead of blocking
> - same again after another freeze and thaw
> - remount keeps refusing modifications, going read-only works, going
>   back to read-write fails with EROFS
> - write, error, remount read-only and umount without a crash
> - write, error, sync: fsync fails with EROFS on ext2 and nilfs2, jfs
>   still commits
> - gfs2: withdraw while frozen, thaw, "withdrawn" shown, writes through
>   earlier opened fds fail instead of blocking
> - freezing a withdrawn gfs2 fails and leaves it thawed
> 
> Everything skips without root, loop devices, the filesystem or its mkfs
> tool. The ext2 variant also skips when ext4 serves ext2. Children run
> with stdio on /dev/null so a writer stuck in sb_start_write() can't hang
> the test runner.
> 
> Signed-off-by: Christian Brauner (Amutable) <brauner@kernel.org>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261012-work-fs-sb_rdonly-v1-0-60743a3dc326@kernel.org?part=24