Re: [PATCH] arm64: dts: qcom: shikra-iqs: add M.2 Wi-Fi and Bluetooth overlay

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] dts: qcom: shikra: overlay references missing &pcie and &tc9563 labels
- [Medium] dts: qcom: shikra: i2c3 bus left disabled in Wi-Fi/BT overlay
--

commit c7775498584a8a4439bd0383ef59c4918ec334ae
Author: Linghui Wu <linghui.wu@oss.qualcomm.com>

    arm64: dts: qcom: shikra-iqs: add M.2 Wi-Fi and Bluetooth overlay

    Add an overlay for M.2 Key-E Wi-Fi and Bluetooth modules on Qualcomm
    Shikra IQS EVK.

> diff --git a/arch/arm64/boot/dts/qcom/shikra-iqs-evk-m2-wifi-bt.dtso b/arch/arm64/boot/dts/qcom/shikra-iqs-evk-m2-wifi-bt.dtso
> new file mode 100644
> index 0000000000000..3264c0add67bd
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/shikra-iqs-evk-m2-wifi-bt.dtso
> @@ -0,0 +1,107 @@
[ ... ]
> +&i2c3 {
> +	qps_gpio_expander: gpio@3c {
> +		compatible = "nxp,pca9534";
> +		reg = <0x3c>;
> +		gpio-controller;
> +		#gpio-cells = <2>;
> +	};
> +};

[Severity: Medium]
Will this GPIO expander probe successfully? The i2c3 bus is disabled by default
in the base SoC device tree, and this overlay adds the expander to the bus
without explicitly setting status = "okay" to enable the controller.

Since the m2_keye_3p3 regulator relies on a GPIO from qps_gpio_expander, the
expander failing to probe will cause the regulator to defer indefinitely,
leaving the Wi-Fi/BT module unpowered.

> +
> +&pcie {
> +	iommu-map = <0x0 &apps_smmu 0x0800 0x0 0x1>,
> +		    <0x100 &apps_smmu 0x0801 0x0 0x1>;
> +	vddpe-3v3-supply = <&m2_keye_3p3>;
> +};

[Severity: Medium]
Are we missing prerequisite patches for the base Shikra device tree? The
overlay targets the &pcie label, which does not appear to be defined anywhere
in the base device trees (shikra.dtsi, shikra-iqs-som.dtsi,
shikra-iqs-evk.dts). Applying the overlay will fail with an unresolved phandle
error.

> +
> +&pcie_port0 {
> +	compatible = "pciclass,0604";
> +	reset-gpios = <&tlmm 118 GPIO_ACTIVE_LOW>;
> +
> +	port {
> +		pcie_port0_ep: endpoint {
> +			remote-endpoint = <&m2_e_pcie_ep>;
> +		};
> +	};
> +};

[Severity: Medium]
Similarly, does the base tree define the &pcie_port0 label? It also appears to
be missing from the base tree, which will prevent the overlay from applying.

> +
> +&tc9563 {
> +	reg = <0x1ff00 0x0 0x0 0x0 0x0>;
> +	status = "disabled";
> +};

[Severity: Medium]
Is the &tc9563 label present in the base tree? The overlay attempts to disable
this node, but it seems to be entirely missing from the base Shikra device
tree, which will also result in unresolved phandle errors.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261012122934.3240030-1-linghui.wu@oss.qualcomm.com?part=1