From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28092367B8E for ; Mon, 12 Oct 2026 13:43:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791812589; cv=none; b=s9xwwChy2yQCemUUf7FMoYckT7NP267F4FVoe8yeb/ux+jlk/yOg5WEWDs/YSXJ9/b2RSj0Iz8FBigr6DQflscma4uPLxvEijOCXeuAF+tmG8YzP4pVKtaFq9JNpB+qD7r2gxx4sj0mt3t82CsXABh3a2ntE7aejZ6PgeSLx9f8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791812589; c=relaxed/simple; bh=0A/4IuTBKUPfmXHYgVTCwq+ba99vzgmoCHdKwoP8JG8=; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type: Date; b=XOWCVmpSL57XHNECkE2RCYmnQH4LXtP2mzXtkarB5bjvq/Lu1u//HOxT5viC7TlVNsBlUT7R2fTlxW5x3elWwVKPUtNrcsgpxVmgWMph3JUT4/2Ee9Tr7erWpyEyWKYn2VZuqBADevAe67ssHNs+evpZsFoB6RnQ1kfV8xQTaos= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XdBhCkqt; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XdBhCkqt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 571BC1F0089B; Mon, 12 Oct 2026 13:43:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791812587; bh=HU8W7WyvQhr6+WPeL0/gx4fQymldhTyReuYTGv/aPN4=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=XdBhCkqtSGb0JMR0LcYhaWbbRIwpLceLXs+GpbyJhFZflUgf2/lFwshzZsHeFlgJA 3nQuAKSmOt+F6NJaSTVFnwdML2KTYo4g2f8etbqB3Vpa2FBE1suWJaAXgasuR4qQ1f c1GWQ24uo+qrWYa++bkmdi31OcgpDnzG8HnwuVAOsVs6Ov3/1RwfE/ktkyNkZsUqxt 9fWirxuQym+a4PZzyUdEGPD1gBDQkJrEBnIM5sUifbdBP4oBzA4gUbx8OqNFldlh5C 4rGLXnZDHxjRm1Pjsafp/bAPbeflk1rh0fROezPZ7pbBoA29iTRaeXo7J/pxnGg/dH mVcY6PrMm7H6Q== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 12/13] phy: qcom: edp: Add Nord PHY configuration data tables Reply-To: sashiko-reviews@lists.linux.dev To: "Nabige Aala" Cc: linux-phy@lists.infradead.org, olteanv@gmail.com, devicetree@vger.kernel.org, vkoul@kernel.org, conor+dt@kernel.org, robh@kernel.org, dri-devel@lists.freedesktop.org, neil.armstrong@linaro.org In-Reply-To: <20261012-nord-drv-dt-v2-12-a2ab9af954d2@oss.qualcomm.com> References: <20261012-nord-drv-dt-v2-0-a2ab9af954d2@oss.qualcomm.com> <20261012-nord-drv-dt-v2-12-a2ab9af954d2@oss.qualcomm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 12 Oct 2026 13:43:06 +0000 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] build: unused static symbols break compilation under Werror -- commit bc3d5c7d159a12dc8bac2f06bcc9089584cfa877 Author: Ritesh Kumar phy: qcom: edp: Add Nord PHY configuration data tables This commit adds Nord-specific AUX channel, VCO divider, LDO and TX resistor calibration data. These tables are sourced from HPG Tables 2-1-a, 2-1-b and 2-1-d. > diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/p= hy-qcom-edp.c > index 3e857d1056680..cb5f6e0ae607b 100644 > --- a/drivers/phy/qualcomm/phy-qcom-edp.c > +++ b/drivers/phy/qualcomm/phy-qcom-edp.c > @@ -1741,6 +1741,39 @@ static int qcom_edp_com_configure_pll_nord(const s= truct qcom_edp *edp) > return 0; > } > =20 > +static const u8 edp_phy_aux_cfg_nord[DP_AUX_CFG_SIZE] =3D { > + 0x00, 0x13, 0xa4, 0x00, 0x0a, 0x26, 0x0a, 0x03, 0x37, 0x03, 0x02, 0x02,= 0x04, > +}; > + > +static const u8 edp_phy_vco_div_cfg_nord[4] =3D { > + 0x00, 0x00, 0x02, 0x01, > +}; [Severity: Low] Does this code introduce unused static variables? These arrays, as well as tx_res_cfg_nord below, are defined as static but a= re not referenced anywhere in this commit. Defining unreferenced static arrays triggers a -Wunused-const-variable compiler warning. If the kernel is built with CONFIG_WERROR=3Dy, this warning is promoted to = an error and breaks the build. While a later patch in this series (commit 1393c79f29bd788a83ce23c45373ba39e69132d0) references these tables, intermediate patches must compile cleanly to maintain git bisectability. > + > +static int qcom_edp_ldo_config_nord(const struct qcom_edp *edp) > +{ > + const struct phy_configure_opts_dp *dp_opts =3D &edp->dp_opts; > + > + writel(0xd0, edp->tx0 + TXn_LDO_CONFIG); [Severity: Low] Does this code introduce an unused static function? Similar to the static arrays above, qcom_edp_ldo_config_nord is defined as static but never called in this commit. This triggers a -Wunused-function warning, which will also break the build under CONFIG_WERROR=3Dy. [ ... ] --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261012-nord-drv-d= t-v2-0-a2ab9af954d2@oss.qualcomm.com?part=3D12 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6DA7CA9EC5 for ; Mon, 12 Oct 2026 13:43:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zoEq97CJtySBQrp/98H4q7QNnXFk8NfIijVQo2URf3k=; b=qHxwOm2zdFrhSB jk6FsDzSpU8wVzScJujCJbfh8DCKUcbp1nRkrVSQ3qOcu1JvAfQmUKWJ3m6zPRbgupoQG9UHbLLH7 6u7FXhYBN92QIUMdto00opAecFM7RcMANUME33Vo+RpdGmcC/OVGeWKnLYccv3nxyFGR6JItZr1yb 8Tyebr8dJRuHhPryrcme0ANLIMFs/+d/H6SdfUB4vBrtAKnIRO3E/qmWpkd3Y/T4wBefRtcQslGV6 eOifrLrMVpg91VHl1vmiSaOcv4zb3mnHQDKaXVIFuUr7zhBPilfsGIxeBp43JjBVLoXSTQfXo6bAG bk/WvKpOBb8DjQwtnVww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xGGJ4-0000000Aben-1RiD; Mon, 12 Oct 2026 13:43:10 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xGGJ2-0000000AbeP-2Bwv for linux-phy@lists.infradead.org; Mon, 12 Oct 2026 13:43:08 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id CC92241A27; Mon, 12 Oct 2026 13:43:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 571BC1F0089B; Mon, 12 Oct 2026 13:43:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791812587; bh=HU8W7WyvQhr6+WPeL0/gx4fQymldhTyReuYTGv/aPN4=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=XdBhCkqtSGb0JMR0LcYhaWbbRIwpLceLXs+GpbyJhFZflUgf2/lFwshzZsHeFlgJA 3nQuAKSmOt+F6NJaSTVFnwdML2KTYo4g2f8etbqB3Vpa2FBE1suWJaAXgasuR4qQ1f c1GWQ24uo+qrWYa++bkmdi31OcgpDnzG8HnwuVAOsVs6Ov3/1RwfE/ktkyNkZsUqxt 9fWirxuQym+a4PZzyUdEGPD1gBDQkJrEBnIM5sUifbdBP4oBzA4gUbx8OqNFldlh5C 4rGLXnZDHxjRm1Pjsafp/bAPbeflk1rh0fROezPZ7pbBoA29iTRaeXo7J/pxnGg/dH mVcY6PrMm7H6Q== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 12/13] phy: qcom: edp: Add Nord PHY configuration data tables To: "Nabige Aala" Cc: linux-phy@lists.infradead.org, olteanv@gmail.com, devicetree@vger.kernel.org, vkoul@kernel.org, conor+dt@kernel.org, robh@kernel.org, dri-devel@lists.freedesktop.org, neil.armstrong@linaro.org In-Reply-To: <20261012-nord-drv-dt-v2-12-a2ab9af954d2@oss.qualcomm.com> References: <20261012-nord-drv-dt-v2-0-a2ab9af954d2@oss.qualcomm.com> <20261012-nord-drv-dt-v2-12-a2ab9af954d2@oss.qualcomm.com> Date: Mon, 12 Oct 2026 13:43:06 +0000 X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0xvd10gYnVpbGQ6IHVudXNlZCBz dGF0aWMgc3ltYm9scyBicmVhayBjb21waWxhdGlvbiB1bmRlciBXZXJyb3IKLS0KCmNvbW1pdCBi YzNkNWM3ZDE1OWExMmRjOGJhYzJmMDZiY2M5MDg5NTg0Y2ZhODc3CkF1dGhvcjogUml0ZXNoIEt1 bWFyIDxyaXRlc2gua3VtYXJAb3NzLnF1YWxjb21tLmNvbT4KCnBoeTogcWNvbTogZWRwOiBBZGQg Tm9yZCBQSFkgY29uZmlndXJhdGlvbiBkYXRhIHRhYmxlcwoKVGhpcyBjb21taXQgYWRkcyBOb3Jk LXNwZWNpZmljIEFVWCBjaGFubmVsLCBWQ08gZGl2aWRlciwgTERPIGFuZCBUWApyZXNpc3RvciBj YWxpYnJhdGlvbiBkYXRhLiBUaGVzZSB0YWJsZXMgYXJlIHNvdXJjZWQgZnJvbSBIUEcgVGFibGVz CjItMS1hLCAyLTEtYiBhbmQgMi0xLWQuCgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3BoeS9xdWFs Y29tbS9waHktcWNvbS1lZHAuYyBiL2RyaXZlcnMvcGh5L3F1YWxjb21tL3BoeS1xY29tLWVkcC5j Cj4gaW5kZXggM2U4NTdkMTA1NjY4MC4uY2I1ZjZlMGFlNjA3YiAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL3BoeS9xdWFsY29tbS9waHktcWNvbS1lZHAuYwo+ICsrKyBiL2RyaXZlcnMvcGh5L3F1YWxj b21tL3BoeS1xY29tLWVkcC5jCj4gQEAgLTE3NDEsNiArMTc0MSwzOSBAQCBzdGF0aWMgaW50IHFj b21fZWRwX2NvbV9jb25maWd1cmVfcGxsX25vcmQoY29uc3Qgc3RydWN0IHFjb21fZWRwICplZHAp Cj4gIAlyZXR1cm4gMDsKPiAgfQo+ICAKPiArc3RhdGljIGNvbnN0IHU4IGVkcF9waHlfYXV4X2Nm Z19ub3JkW0RQX0FVWF9DRkdfU0laRV0gPSB7Cj4gKwkweDAwLCAweDEzLCAweGE0LCAweDAwLCAw eDBhLCAweDI2LCAweDBhLCAweDAzLCAweDM3LCAweDAzLCAweDAyLCAweDAyLCAweDA0LAo+ICt9 Owo+ICsKPiArc3RhdGljIGNvbnN0IHU4IGVkcF9waHlfdmNvX2Rpdl9jZmdfbm9yZFs0XSA9IHsK PiArCTB4MDAsIDB4MDAsIDB4MDIsIDB4MDEsCj4gK307CgpbU2V2ZXJpdHk6IExvd10KRG9lcyB0 aGlzIGNvZGUgaW50cm9kdWNlIHVudXNlZCBzdGF0aWMgdmFyaWFibGVzPwoKVGhlc2UgYXJyYXlz LCBhcyB3ZWxsIGFzIHR4X3Jlc19jZmdfbm9yZCBiZWxvdywgYXJlIGRlZmluZWQgYXMgc3RhdGlj IGJ1dCBhcmUKbm90IHJlZmVyZW5jZWQgYW55d2hlcmUgaW4gdGhpcyBjb21taXQuIERlZmluaW5n IHVucmVmZXJlbmNlZCBzdGF0aWMgYXJyYXlzCnRyaWdnZXJzIGEgLVd1bnVzZWQtY29uc3QtdmFy aWFibGUgY29tcGlsZXIgd2FybmluZy4KCklmIHRoZSBrZXJuZWwgaXMgYnVpbHQgd2l0aCBDT05G SUdfV0VSUk9SPXksIHRoaXMgd2FybmluZyBpcyBwcm9tb3RlZCB0byBhbgplcnJvciBhbmQgYnJl YWtzIHRoZSBidWlsZC4gV2hpbGUgYSBsYXRlciBwYXRjaCBpbiB0aGlzIHNlcmllcyAoY29tbWl0 CjEzOTNjNzlmMjliZDc4OGE4M2NlMjNjNDUzNzNiYTM5ZTY5MTMyZDApIHJlZmVyZW5jZXMgdGhl c2UgdGFibGVzLAppbnRlcm1lZGlhdGUgcGF0Y2hlcyBtdXN0IGNvbXBpbGUgY2xlYW5seSB0byBt YWludGFpbiBnaXQgYmlzZWN0YWJpbGl0eS4KCj4gKwo+ICtzdGF0aWMgaW50IHFjb21fZWRwX2xk b19jb25maWdfbm9yZChjb25zdCBzdHJ1Y3QgcWNvbV9lZHAgKmVkcCkKPiArewo+ICsJY29uc3Qg c3RydWN0IHBoeV9jb25maWd1cmVfb3B0c19kcCAqZHBfb3B0cyA9ICZlZHAtPmRwX29wdHM7Cj4g Kwo+ICsJd3JpdGVsKDB4ZDAsIGVkcC0+dHgwICsgVFhuX0xET19DT05GSUcpOwoKW1NldmVyaXR5 OiBMb3ddCkRvZXMgdGhpcyBjb2RlIGludHJvZHVjZSBhbiB1bnVzZWQgc3RhdGljIGZ1bmN0aW9u PwoKU2ltaWxhciB0byB0aGUgc3RhdGljIGFycmF5cyBhYm92ZSwgcWNvbV9lZHBfbGRvX2NvbmZp Z19ub3JkIGlzIGRlZmluZWQgYXMKc3RhdGljIGJ1dCBuZXZlciBjYWxsZWQgaW4gdGhpcyBjb21t aXQuIFRoaXMgdHJpZ2dlcnMgYSAtV3VudXNlZC1mdW5jdGlvbgp3YXJuaW5nLCB3aGljaCB3aWxs IGFsc28gYnJlYWsgdGhlIGJ1aWxkIHVuZGVyIENPTkZJR19XRVJST1I9eS4KClsgLi4uIF0KCi0t IApTYXNoaWtvIEFJIHJldmlldyDCtyBodHRwczovL3Nhc2hpa28uZGV2LyMvcGF0Y2hzZXQvMjAy NjEwMTItbm9yZC1kcnYtZHQtdjItMC1hMmFiOWFmOTU0ZDJAb3NzLnF1YWxjb21tLmNvbT9wYXJ0 PTEyCgotLSAKbGludXgtcGh5IG1haWxpbmcgbGlzdApsaW51eC1waHlAbGlzdHMuaW5mcmFkZWFk Lm9yZwpodHRwczovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1w aHkK