Re: [PATCH v3 1/2] mm/damon/core: Use only installed probe in damon_merge_two_regions()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] mm/damon: memory leak of test resources on damon_new_probe() failure
--

commit 04d02846ea56f0db196cf44b60e21ab0f25afe04
Author: Suhaas Joshi <suhaas@s-joshi.in>

mm/damon/core: Use only installed probe in damon_merge_two_regions()

This commit optimizes region merging by iterating only over installed
probes rather than the entire maximum probe array. It also introduces
a struct damon_ctx parameter to damon_merge_two_regions() and updates
tests to pass this new argument.

> diff --git a/mm/damon/tests/core-kunit.h b/mm/damon/tests/core-kunit.h
> index 3fbb4e4e36fac..385d32901650e 100644
> --- a/mm/damon/tests/core-kunit.h
> +++ b/mm/damon/tests/core-kunit.h
[ ... ]
> @@ -206,7 +208,21 @@ static void damon_test_merge_two(struct kunit *test)
>  	r2->age = 21;
>  	damon_add_region(r2, t);
>  
> -	damon_merge_two_regions(t, r, r2);
> +	p = damon_new_probe();
> +	if (!p) {
> +		kunit_skip(test, "probe alloc fail");
> +		damon_free_target(t);
> +	}

[Severity: Low]
Does this code leak the allocated target t and its regions on probe
allocation failure?

Since kunit_skip() invokes kunit_try_catch_throw() which halts the test
case execution immediately, the code does not return from this macro.
This means the subsequent damon_free_target(t) call is unreachable dead
code.

Should the cleanup be performed before calling kunit_skip(), similar to
how it is handled in the subsequent context allocation failure block?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261012145636.168436-1-suhaas@s-joshi.in?part=1