Re: [PATCH 1/2] dt-bindings: reset: introduce toshiba,tc9564-reset.yaml

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] dt-bindings: syscon missing hardware-specific compatible in example
- [Low] dt-bindings: incorrect node name 'reset' instead of 'reset-controller'
--

commit 86eb967be387fadac7b22aba279d8ed01983af26
Author: Alex Elder <elder@riscstar.com>

dt-bindings: reset: introduce toshiba,tc9564-reset.yaml

This commit defines the binding for the reset controller functionality present
in the Toshiba TC9564 SoC. It includes a new YAML schema, a header file for
the reset IDs, and updates the MAINTAINERS file.

> diff --git a/Documentation/devicetree/bindings/reset/toshiba,tc9564-reset.yaml b/Documentation/devicetree/bindings/reset/toshiba,tc9564-reset.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/reset/toshiba,tc9564-reset.yaml

[ ... ]

> +examples:
> +  - |
> +    #include <dt-bindings/reset/toshiba,tc9564.h>
> +
> +    syscon@0 {
> +        compatible = "syscon", "simple-mfd";

[Severity: Low]
Does this example fail dt_binding_check validation? The core syscon.yaml
schema typically requires a hardware-specific compatible string to precede
generic fallbacks like "syscon" and "simple-mfd".

> +        reg = <0x0 0x2000>;
> +
> +        reset {

[Severity: Low]
Should this node be named "reset-controller" instead of "reset"? The core
reset.yaml schema enforces the ^reset-controller(@.*)?$ naming convention
for nodes providing resets (identified by the #reset-cells property).

> +            compatible = "toshiba,tc9564-reset";
> +            #reset-cells = <1>;
> +        };
> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261012164354.3872326-1-elder@riscstar.com?part=1