Re: [PATCH 02/11] dt-bindings: i2c: Add NVIDIA LSTP I2C

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: incomplete schema validation allows unsupported clock-frequency property
--

commit 16ee132f4b8daa2cd636b3b3437f38ceb664442e
Author: Adrian Ambrozewicz <aambrozewicz@nvidia.com>

dt-bindings: i2c: Add NVIDIA LSTP I2C

This commit adds a device tree binding for the I2C controller channel on an
NVIDIA LSTP USB device. It includes configurations for the compatible string,
register ID, and a custom property for arbitration retries. The documentation
notes that the device sets the bus speed, so clock-frequency is unsupported.

> diff --git a/Documentation/devicetree/bindings/i2c/nvidia,lstp-i2c.yaml b/Documentation/devicetree/bindings/i2c/nvidia,lstp-i2c.yaml
> new file mode 100644
> index 0000000000000..eacabed52cd1c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/nvidia,lstp-i2c.yaml
> @@ -0,0 +1,71 @@
[ ... ]
> +description: |
> +  I2C controller channel on an NVIDIA LSTP USB device.
> +
> +  Peripherals on the bus are described as child nodes.  An i2c alias
> +  gives the bus a fixed number.
> +
> +  The bus speed is set by the device.  The LSTP protocol has no way to
> +  change it, so clock-frequency is not supported and is ignored.
> +
> +allOf:
> +  - $ref: /schemas/i2c/i2c-controller.yaml#
> +
> +properties:
> +  compatible:
> +    const: nvidia,lstp-i2c

[Severity: Low]
Since this schema inherits from /schemas/i2c/i2c-controller.yaml# which
evaluates and permits the standard clock-frequency property, should
clock-frequency: false be explicitly defined in this properties block?

Because the property is evaluated by the $ref, the unevaluatedProperties:
false directive at the bottom of the schema does not reject it. Device
trees that incorrectly specify clock-frequency for this controller will
silently pass schema validation, despite the binding's documentation stating
it is not supported.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261012-lstp-usb-adapter-v1-0-aambrozewicz@nvidia.com?part=2