Re: [PATCH v8 2/7] bus: mhi: Move Sahara protocol driver under MHI host client drivers

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] accel/qaic: Kconfig dependency silently disables DRM_ACCEL_QAIC
--

commit f5cb67a206ffebb3609b6a5fffcfe4b3a821d420
Author: Kishore Batta <kishore.batta@oss.qualcomm.com>

bus: mhi: Move Sahara protocol driver under MHI host client drivers

This commit moves the Sahara protocol driver out of the QAIC subsystem and
into drivers/bus/mhi as an independent host client driver. It also creates a
dedicated Kconfig hierarchy and updates the driver initialization to use
module_mhi_driver().

> diff --git a/drivers/accel/qaic/Kconfig b/drivers/accel/qaic/Kconfig
> index 116e42d152ca8..af90fdfcf77ee 100644
> --- a/drivers/accel/qaic/Kconfig
> +++ b/drivers/accel/qaic/Kconfig
> @@ -8,6 +8,7 @@ config DRM_ACCEL_QAIC
>  	depends on DRM_ACCEL
>  	depends on PCI && HAS_IOMEM
>  	depends on MHI_BUS
> +	depends on MHI_SAHARA

[Severity: Medium]
Does adding this dependency silently disable the DRM_ACCEL_QAIC driver for
users upgrading their kernels?

Since the newly introduced MHI_SAHARA symbol defaults to N, existing
configurations running make oldconfig will have DRM_ACCEL_QAIC silently
dropped because its new dependency is unmet.

To prevent breaking existing configurations, should DRM_ACCEL_QAIC use
select MHI_SAHARA instead, or should MHI_SAHARA default to DRM_ACCEL_QAIC?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261012-sahara_protocol_new_v2-v8-0-e12939d229a1@oss.qualcomm.com?part=2