From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 452B5384CDA for ; Mon, 12 Oct 2026 23:54:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791849260; cv=none; b=nS6frpGWwPVakRnPtC8mWKy66NI9L0i8PPO4ReXSulxq6nxA3Ouwm40oa9K7nJvbeVYw334WsNuehUUP2aa5wt96lZz2S2w5iWHBZpbEpwYCpNCEoUSrfkmHx5P58SLXpm5rrxPOPf7cbQK6w3JrYw5JhRjpyeVhxoQpdXDUpng= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791849260; c=relaxed/simple; bh=kl+E/d4y3mhV8tD46Sxpm1ZA25wZ7CCkZFCGL5AJT7M=; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type: Date; b=bDn2VBRwMcoMXCFHtWsJd1bgyww6oipJGM8DL+58Te0vFUFRuh+MjPybWDtFSKZnED+WrXA+E50kjME0QgrZvgLUJLjhuBcF0xufEvEailJZmfPSgoZ/tGNtrlLrDyBv6QE55sC9Ul7hxqS7Pk/es1BH9yv3zMARbmwpqIfXJ1Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=L68P0riZ; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="L68P0riZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 025661F0089B; Mon, 12 Oct 2026 23:54:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791849259; bh=Yp2ZVcq9sU06zV3UymZYRM9tlXw1rOs/TBq/3OImXqo=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=L68P0riZYhKediG9KgS3ybtvSIaj0C3RNcUTD5ZQiINYwmRvzX8CK2gcES+igg1TK jTKpWbhwcrZwXyB3msg4Lklj2iowYlTd6kDqh+HGmlj19aKXzSaHFgP1k5uANhIMqm y2KnqrbS5+ak/ikRWwGPCx2WOWtk7TeOM+bAqPTXoQSoOWEZXJPm8f0UQwxVuKQcg/ ex2aFKfzBTyB6PUyoQ1vD7UCdzBOeIXjM75ZOSoZT0HdkPng9SkcrZM5ZezioCTX9m KixGJchAfZI6Sz5YkK+sBMSWMmf4KhvqjICODb6tMNBEpJQ7jkgmUpj9evVANlMZXI +/O8VJj4JXhqQ== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v4 2/3] perf test: Improve JUnit XML schema compliance and completeness Reply-To: sashiko-reviews@lists.linux.dev To: "Ian Rogers" Cc: linux-perf-users@vger.kernel.org In-Reply-To: <20261012234724.721224-3-irogers@google.com> References: <20260929025345.88829-1-irogers@google.com> <20261012234724.721224-1-irogers@google.com> <20261012234724.721224-3-irogers@google.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 12 Oct 2026 23:54:18 +0000 Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: > Improve the JUnit XML output generated by 'perf test -j' so that it > validates cleanly against both the strict Apache Ant/Windy Road JUnit > schema (JUnit.xsd) and the Jenkins xUnit/Maven Surefire schema > (junit-10.xsd): > - Add the required 'package', 'id', 'timestamp' (ISO 8601 UTC), > 'hostname', and 'time' attributes to ''. > - Emit '' (populated with uname sysname, release, version, > and machine when available) at the start of '' and > '' and '' at the end, matching the element > sequence required by JUnit.xsd. > - Add the required 'type=3D"failure"' attribute to '' elements > and emit self-closing tags for passing '' elements and > ''/'' elements with empty error output. > - Escape apostrophes (''') and validate UTF-8 multi-byte sequences > against valid XML 1.0 codepoints in xml_escape(). > - Use the actual suite description and '%.2f' time format for user > override skipped tests ('-s'/'--skip'). > - Document '-j[]'/'--junit[=3D]' in perf-test.txt. >=20 > Assisted-by: Antigravity:gemini-3.1-pro > Signed-off-by: Ian Rogers Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261012234724.7212= 24-1-irogers@google.com?part=3D2