Re: [PATCH RFC v3 2/9] tee: optee: allow RPMI transport builds on RISC-V

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] kconfig: missing RISCV_RPMI_TEE_TRANSPORT definition
--

commit 1268be5496f8b09029f843bfb4ecaffba27bd25e
Author: Amirreza Zarrabi <amirreza.zarrabi@oss.qualcomm.com>

tee: optee: allow RPMI transport builds on RISC-V

This commit allows the TEE subsystem and OP-TEE driver to be built on RISC-V systems using the RPMI TEE transport. It also implements the memory type check for RISC-V to prevent unsupported architecture build errors.

> diff --git a/drivers/tee/Kconfig b/drivers/tee/Kconfig
> index 98c3ad0839409..ad754b647a3c5 100644
> --- a/drivers/tee/Kconfig
> +++ b/drivers/tee/Kconfig
> @@ -2,7 +2,8 @@
>  # Generic Trusted Execution Environment Configuration
>  menuconfig TEE
>  	tristate "Trusted Execution Environment support"
> -	depends on HAVE_ARM_SMCCC || COMPILE_TEST || CPU_SUP_AMD
> +	depends on HAVE_ARM_SMCCC || COMPILE_TEST || CPU_SUP_AMD || \
> +		   RISCV_RPMI_TEE_TRANSPORT

[Severity: High]
Is the RISCV_RPMI_TEE_TRANSPORT config defined in another patch in this
series?

Since RISCV_RPMI_TEE_TRANSPORT is not defined in this patch or the current
tree, this dependency evaluates to false. This makes it impossible to
enable TEE on RISC-V configurations, leaving the drivers disabled when
users expect them to be built.

[ ... ]

> diff --git a/drivers/tee/optee/Kconfig b/drivers/tee/optee/Kconfig
> index 891dac63cab85..cc057c76de622 100644
> --- a/drivers/tee/optee/Kconfig
> +++ b/drivers/tee/optee/Kconfig
> @@ -2,10 +2,11 @@
>  # OP-TEE Trusted Execution Environment Configuration
>  config OPTEE
>  	tristate "OP-TEE"
> -	depends on HAVE_ARM_SMCCC
> +	depends on HAVE_ARM_SMCCC || RISCV_RPMI_TEE_TRANSPORT

[Severity: High]
Similar to the TEE config above, OPTEE depends on RISCV_RPMI_TEE_TRANSPORT
here.

Without a corresponding config RISCV_RPMI_TEE_TRANSPORT definition in the
tree, this condition can never be met for RISC-V systems. Does this rely
on a missing prerequisite patch?

>  	depends on MMU
>  	depends on RPMB || !RPMB
>  	depends on ARM_FFA_TRANSPORT || !ARM_FFA_TRANSPORT
> +	depends on RISCV_RPMI_TEE_TRANSPORT || !RISCV_RPMI_TEE_TRANSPORT
>  	help
>  	  This implements the OP-TEE Trusted Execution Environment (TEE)
>  	  driver.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261012-rpmi-tee-service-grp-dev-v3-0-975b574667e2@oss.qualcomm.com?part=2