From: sashiko-bot@kernel.org
To: "Chengfeng Ye" <nicoyip.dev@gmail.com>
Cc: linux-rdma@vger.kernel.org, linux-s390@vger.kernel.org,
"Heiko Carstens" <hca@linux.ibm.com>,
"Vasily Gorbik" <gor@linux.ibm.com>,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>
Subject: Re: [PATCH net v3 2/3] net/smc: serialize early link group cleanup with termination
Date: Tue, 13 Oct 2026 09:51:50 +0000 [thread overview]
Message-ID: <sashiko-outbox-169392@kernel.org> (raw)
In-Reply-To: <20261013091716.1210420-3-nicoyip.dev@gmail.com>
> smc_lgr_cleanup_early() enters __smc_lgr_terminate() even when another
> teardown path has already claimed lgr->freeing. Both callers can observe
> lgr->terminating clear before either sets it, then tear down the same
> link group, causing use-after-free and duplicate resource release.
>
> BUG: KASAN: use-after-free in __smc_lgr_terminate+0x393/0x3a0
> Write of size 1 at addr ffff8880bf2c0300 by task poc/106
> Call Trace:
> __smc_lgr_terminate+0x393/0x3a0
> __smc_connect+0x2e3d/0x4930
> smc_connect+0x42c/0x580
> __sys_connect+0xfc/0x130
> __x64_sys_connect+0x6d/0xb0
>
> Check freeing under the link group list lock before unlinking the group
> [ ... ]
>
> Fixes: f9aab6f2ce57 ("net/smc: immediate freeing in smc_lgr_cleanup_early()")
> Cc: stable@vger.kernel.org
> Assisted-by: GPT-6.1-Sol
> Signed-off-by: Chengfeng Ye <nicoyip.dev@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261013091716.1210420-1-nicoyip.dev@gmail.com?part=2
next prev parent reply other threads:[~2026-10-13 9:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 9:17 [PATCH net v3 0/3] net/smc: fix link group scheduling, registration and work lifetime Chengfeng Ye
2026-10-13 9:17 ` [PATCH net v3 1/3] net/smc: serialize link group free work scheduling Chengfeng Ye
2026-10-13 9:51 ` sashiko-bot
2026-10-13 9:17 ` [PATCH net v3 2/3] net/smc: serialize early link group cleanup with termination Chengfeng Ye
2026-10-13 9:51 ` sashiko-bot [this message]
2026-10-13 9:17 ` [PATCH net v3 3/3] net/smc: hold a link group reference for free work Chengfeng Ye
2026-10-13 9:51 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-169392@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nicoyip.dev@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.