Re: [PATCH 3/8] arm64: dts: imx8mp-kontron: Remove obsolete VDD_CARRIER regulator

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: Stale CARRIER_PWR_EN label in carrier board gpio-line-names overrides
--

commit b5bf4333f3ce6c5ca93d4fd597b09395c78fe9b7
Author: Eberhard Stoll <eberhard.stoll@kontron.de>

arm64: dts: imx8mp-kontron: Remove obsolete VDD_CARRIER regulator

This commit removes the VDD_CARRIER regulator from the Kontron OSM-S i.MX8MP
SoM devicetree. It also renames the CARRIER_PWR_EN gpio line to GPIO_C_1, as
the signal is now controlled by hardware on regular revisions rather than
software.

> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-kontron-osm-s.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-kontron-osm-s.dtsi
> index 3459ee2c0eb64..4fd42e7170ee8 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-kontron-osm-s.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-kontron-osm-s.dtsi
[ ... ]
> @@ -185,7 +162,7 @@ &gpio4 {
>  			  "GPIO_B_3", "GPIO_B_4",
>  			  "GPIO_B_2", "GPIO_A_6", "CAN_A_TX", "UART_A_CTS",
>  			  "UART_A_RTS", "CAN_A_RX", "CAN_B_TX", "CAN_B_RX",
> -			  "I2S_B_DATA_IN", "CARRIER_PWR_EN", "I2S_A_DATA_IN", "I2S_B_DATA_OUT";
> +			  "I2S_B_DATA_IN", "GPIO_C_1", "I2S_A_DATA_IN", "I2S_B_DATA_OUT";
>  };

[Severity: Low]
Is this rename incomplete? While "CARRIER_PWR_EN" is updated to "GPIO_C_1"
here in the SoM's &gpio4 node, the carrier boards provide their own
gpio-line-names overrides for &gpio4 which still hardcode the old name.

For the BL OSM-S carrier board:

arch/arm64/boot/dts/freescale/imx8mp-kontron-bl-osm-s.dts:&gpio4 {
    ...
    gpio-line-names = "CAN_B_RX", "CAN_B_TX", "CAN_A_RX", "CAN_A_TX",
                      ...
                      "TFT_STBY", "CARRIER_PWR_EN", "I2S_A_DATA_IN", "I2S_LRCLK";
}

And similarly for the SMARC carrier board:

arch/arm64/boot/dts/freescale/imx8mp-kontron-smarc.dtsi:&gpio4 {
    ...
    gpio-line-names = "", "", "", "",
                      ...
                      "TEST", "CARRIER_PWR_EN", "I2S0_SDIN", "I2S0_LRCK";
}

Since the board-level overrides remain, the old label is still exported to
userspace on these boards. Does this defeat the purpose of the rename for
those devices?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261013-upstreaming-gpio-label-fixes-v1-0-94f09ec520ef@kontron.de?part=3