From: sashiko-bot@kernel.org
To: "Imre Kaloz" <kaloz@kernel.org>
Cc: linux-rtc@vger.kernel.org,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>
Subject: Re: [PATCH 1/2] rtc: ds1685: arm the wake-up alarm at power-off only if an alarm is set
Date: Tue, 13 Oct 2026 10:05:03 +0000 [thread overview]
Message-ID: <sashiko-outbox-169449@kernel.org> (raw)
In-Reply-To: <20261013094930.574-2-kaloz@kernel.org>
> ds1685_rtc_poweroff() always sets WIE. The wake-up alarm then compares
> the time-of-day and date alarm registers, which hold whatever was last
> written to them, and a match powers the machine straight back on.
>
> Set WIE only when AIE is set in Control B, and clear it otherwise.
>
> Fixes: aaaf5fbf56f1 ("rtc: add driver for DS1685 family of real time clocks")
> Signed-off-by: Imre Kaloz <kaloz@kernel.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261013094930.574-1-kaloz@kernel.org?part=1
next prev parent reply other threads:[~2026-10-13 10:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 9:49 [PATCH 0/2] rtc: ds1685: power-off fixes Imre Kaloz
2026-10-13 9:49 ` [PATCH 1/2] rtc: ds1685: arm the wake-up alarm at power-off only if an alarm is set Imre Kaloz
2026-10-13 10:05 ` sashiko-bot [this message]
2026-10-13 9:49 ` [PATCH 2/2] rtc: ds1685: keep setting PAB until power is removed Imre Kaloz
2026-10-13 10:15 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-169449@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=kaloz@kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.