Re: [PATCH v9 01/10] ASoC: dt-bindings: qcom,shikra-qaif-cpu: Add binding

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: missing header file for QAIF DAI IDs
--

commit 2a91d26485f5db137a06dc65becc26ee388409d0
Author: Harendra Gautam <harendra.gautam@oss.qualcomm.com>

ASoC: dt-bindings: qcom,shikra-qaif-cpu: Add binding

Add the Devicetree binding for the Qualcomm Audio Interface (QAIF) CPU DAI
controller used on the Shikra audio platform. Describes the MMIO region,
interrupt, clocks, DMA IOMMU mapping and aif-interface child nodes required
by the controller.

> diff --git a/Documentation/devicetree/bindings/sound/qcom,shikra-qaif-cpu.yaml b/Documentation/devicetree/bindings/sound/qcom,shikra-qaif-cpu.yaml
> new file mode 100644
> index 0000000000000..acca6f6177518
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/qcom,shikra-qaif-cpu.yaml
> @@ -0,0 +1,290 @@
[ ... ]
> +patternProperties:
> +  '^aif@[0-9a-f]+$':
> +    type: object
> +    description:
> +      QAIF AIF interface child node for PCM, TDM or MI2S configuration.
> +
> +    allOf:
> +      - $ref: /schemas/sound/tdm-slot.yaml#
> +
> +    properties:
> +      reg:
> +        maxItems: 1
> +        description:
> +          DAI ID of the AIF interface (QAIF_MI2S_AIF* or QAIF_TDM_AIF*).

[Severity: Medium]
The commit message states that this binding provides "named constants to avoid
raw numeric IDs in sound-dai references and child-node reg values". Are these
QAIF_MI2S_AIF* and QAIF_TDM_AIF* constants missing from this patch?

I don't see a dt-bindings header file added in this patch or the rest of the
series to define them.

[ ... ]
> +            #sound-dai-cells = <1>;
> +            #address-cells = <1>;
> +            #size-cells = <0>;
> +
> +            aif@b5 {
> +                reg = <181>;

[Severity: Medium]
Since the header file defining the named constants is missing, the example
here falls back to using a raw numeric ID. Should a header file be included
in this series to define these ABI constants so they can be used in the
example and by users?

> +                dai-format = "dsp_a";
> +                dai-tdm-slot-width = <32>;
> +                dai-tdm-slot-num = <2>;
> +                dai-tdm-slot-rx-mask = <1 1>;
> +                dai-tdm-slot-tx-mask = <1 1>;
> +                qcom,qaif-aif-lane-map = <1 0>;
> +            };
> +        };
> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261013-b4-qaif-shikra-audio-v9-0-f3022e28f2fd@oss.qualcomm.com?part=1