From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F5A2CC6B03 for ; Tue, 13 Oct 2026 13:00:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cKTi1Cev7N4sbRfT5GXCa/pKxiSIGBUiuO4poqKEyTE=; b=zZqDpdzLsmMGXY 7bS6B9zBtHVfqzV0LaDfvDPIENpqwrf3sNfk+AQqO2gqlw/ISrQpwuAomhg7zJR5jZvbOuP4lBeod qqoATTfdO/H4PxwS6aqo2sGsFflga5K/neIY49xo6GhP/n8nm1/KP7tY1FuFkg5Aee9OLzqCvV6NV 8umCHTdKx7Q9ik+SdxJZN5rUp0Tj2P8QWVcSYEzq/Re4ex0FjUgAPqYsgk7GoIKhkb9RsQLIhfFuV FvyZ2ox7TIQ8PwB2AyKzN6GAHXDGkXhF4uqNICZdohJGOveJzs8DZ87n70T6rFw+AVcAvPN1dK1kL Sl+loXUAS3gv2SbebWcA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xGc74-0000000CtOc-4BBH; Tue, 13 Oct 2026 13:00:14 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xGc72-0000000CtNY-3lqR for linux-phy@lists.infradead.org; Tue, 13 Oct 2026 13:00:12 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 6403E43AC9; Tue, 13 Oct 2026 13:00:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C1DDA1F000FF; Tue, 13 Oct 2026 13:00:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791896412; bh=jkn00oKNilqawMytVOgJxaKIXAtfj8HSDkaiQNLRYgI=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=V1xvDhsR8EK8bwdQiFPZqK3arBNNSPIfLZf1Pm4ZPVewADGjyzUVOZg8/w0x26one vCFX4l+ahbDdbWwe90P+fASGoLBFP8LLZw9z8/5ODH0VD1q4nf8D+sVCNSjxL6rUkx nlezNQj1LN0F6QBxvWjJ34JQey9B3G3q6wG8Ht0NluP8QS6HCddKtJF5SmATsc/vlm 7HVpTU7tJ4K9rspY0VbZGr1giJgwCClcKNdhYyzgM94jsNBr6dH0nvqNK7okG4Lzrb HzHZ2boO8Vv08vGAoMAJRANEd+zN52mSTh27Bmsu1fW62l0mPo2O9LChUBz1DvL8XJ hJ/sZDBxzJ9OA== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v1 5/6] drm/rockchip: analogix_dp: Add support for RK3568 To: "Damon Ding" Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-phy@lists.infradead.org, robh@kernel.org, conor+dt@kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com In-Reply-To: <20261013124946.1807886-6-damon.ding@rock-chips.com> References: <20261013124946.1807886-1-damon.ding@rock-chips.com> <20261013124946.1807886-6-damon.ding@rock-chips.com> Date: Tue, 13 Oct 2026 13:00:11 +0000 X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIHJvY2tjaGlwL2RwOiB1 bmNoZWNrZWQgTlVMTCBwb2ludGVyIGRlcmVmZXJlbmNlIG9uIG1pc3NpbmcgR1JGIHByb3BlcnR5 Ci0tCgpjb21taXQgOWE2ZTZmNDVjODU0YzIyZjI0ZDQwM2NmOGJkYWI3YTA1MDQxOTliNgpBdXRo b3I6IERhbW9uIERpbmcgPGRhbW9uLmRpbmdAcm9jay1jaGlwcy5jb20+Cgpkcm0vcm9ja2NoaXA6 IGFuYWxvZ2l4X2RwOiBBZGQgc3VwcG9ydCBmb3IgUkszNTY4CgpUaGUgUkszNTY4IGVEUCBjb250 cm9sbGVyIGRvZXMgbm90IHJlcXVpcmUgYW55IEdSRiBjb25maWd1cmF0aW9ucywKc28gbWFrZSB0 aGUgInJvY2tjaGlwLGdyZiIgcHJvcGVydHkgb3B0aW9uYWwuICBBbHNvIGVuYWJsZSB0aGUKb3B0 aW9uYWwgYXZkZC0wdjkgYW5kIGF2ZGQtMXY4IHN1cHBsaWVzIHdoaWNoIHBvd2VyIHRoZSBlRFAg UEhZLgoKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL2FuYWxvZ2l4X2Rw LXJvY2tjaGlwLmMgYi9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvYW5hbG9naXhfZHAtcm9ja2No aXAuYwo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9hbmFsb2dpeF9kcC1yb2NrY2hp cC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL2FuYWxvZ2l4X2RwLXJvY2tjaGlw LmMKPiBAQCAtMzIwLDggKzMyMCw5IEBAIHN0YXRpYyBpbnQgcm9ja2NoaXBfZHBfb2ZfcHJvYmUo c3RydWN0IHJvY2tjaGlwX2RwX2RldmljZSAqZHApCj4gIAlzdHJ1Y3QgZGV2aWNlICpkZXYgPSBk cC0+ZGV2Owo+ICAJc3RydWN0IGRldmljZV9ub2RlICpucCA9IGRldi0+b2Zfbm9kZTsKPiAgCXN0 cnVjdCBjbGsgKmNsazsKPiArCWludCByZXQ7Cj4gIAo+IC0JZHAtPmdyZiA9IHN5c2Nvbl9yZWdt YXBfbG9va3VwX2J5X3BoYW5kbGUobnAsICJyb2NrY2hpcCxncmYiKTsKPiArCWRwLT5ncmYgPSBz eXNjb25fcmVnbWFwX2xvb2t1cF9ieV9waGFuZGxlX29wdGlvbmFsKG5wLCAicm9ja2NoaXAsZ3Jm Iik7Cj4gIAlpZiAoSVNfRVJSKGRwLT5ncmYpKQo+ICAJCXJldHVybiBkZXZfZXJyX3Byb2JlKGRl diwgUFRSX0VSUihkcC0+Z3JmKSwKPiAgCQkJCSAgICAgImZhaWxlZCB0byBnZXQgcm9ja2NoaXAs Z3JmIHByb3BlcnR5XG4iKTsKCltTZXZlcml0eTogSGlnaF0KU2luY2UgdGhpcyBjaGFuZ2VzIHRo ZSBsb29rdXAgdG8gc3lzY29uX3JlZ21hcF9sb29rdXBfYnlfcGhhbmRsZV9vcHRpb25hbCgpLApk cC0+Z3JmIHdpbGwgYmUgTlVMTCB3aGVuIHRoZSBwcm9wZXJ0eSBpcyBhYnNlbnQsIGFuZCB0aGUg SVNfRVJSKCkgY2hlY2sgd2lsbApwYXNzLgoKQ2FuIHRoaXMgY2F1c2UgYSBOVUxMIHBvaW50ZXIg ZGVyZWZlcmVuY2UgZm9yIGxlZ2FjeSBTb0NzIChsaWtlIFJLMzI4OCwgUkszMzk5LApvciBSSzM1 ODgpIGlmIHRoZSBkZXZpY2UgdHJlZSBpcyBtaXNzaW5nIHRoZSBwcm9wZXJ0eT8KCkZvciB0aG9z ZSBvbGRlciBTb0NzLCB0aGUgY2hpcF9kYXRhIHNwZWNpZmllcyB2YWxpZCBHUkYgZmllbGRzLiBE dXJpbmcgZGlzcGxheQppbml0aWFsaXphdGlvbiwgdGhlIGRyaXZlciBjYWxscyByb2NrY2hpcF9n cmZfZmllbGRfd3JpdGUoKToKCmRyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9hbmFsb2dpeF9kcC1y b2NrY2hpcC5jOnJvY2tjaGlwX2dyZl9maWVsZF93cml0ZSgpIHsKCWlmICghZmllbGQtPnZhbGlk KQoJCXJldHVybiAwOwoKCW1hc2sgPSBHRU5NQVNLKGZpZWxkLT5tc2IsIGZpZWxkLT5sc2IpOwoJ dmFsIDw8PSBmaWVsZC0+bHNiOwoKCXJldHVybiByb2NrY2hpcF9ncmZfd3JpdGUoZ3JmLCBmaWVs ZC0+cmVnLCBtYXNrLCB2YWwpOwp9CgpUaGlzIGZvcndhcmRzIHRoZSBwb3RlbnRpYWxseSBOVUxM IGdyZiBwb2ludGVyIHRvIHJvY2tjaGlwX2dyZl93cml0ZSgpIGFuZApldmVudHVhbGx5IHRvIHJl Z21hcF93cml0ZSgpLCB3aGljaCBkZXJlZmVyZW5jZXMgaXQ6Cgpkcml2ZXJzL2Jhc2UvcmVnbWFw L3JlZ21hcC5jOnJlZ21hcF93cml0ZSgpIHsKCS4uLgoJaWYgKCFJU19BTElHTkVEKHJlZywgbWFw LT5yZWdfc3RyaWRlKSkKCQlyZXR1cm4gLUVJTlZBTDsKCS4uLgp9CgpTaG91bGQgcHJvYmUgdmFs aWRhdGUgdGhhdCBkcC0+Z3JmICE9IE5VTEwgaWYgdGhlIGNoaXAgdHlwZSByZXF1aXJlcyBpdCwK cmF0aGVyIHRoYW4gYWxsb3dpbmcgcHJvYmUgdG8gc3VjY2VlZCBhbmQgY2F1c2luZyBhIGtlcm5l bCBvb3BzIGxhdGVyPwoKLS0gClNhc2hpa28gQUkgcmV2aWV3IMK3IGh0dHBzOi8vc2FzaGlrby5k ZXYvIy9wYXRjaHNldC8yMDI2MTAxMzEyNDk0Ni4xODA3ODg2LTEtZGFtb24uZGluZ0Byb2NrLWNo aXBzLmNvbT9wYXJ0PTUKCi0tIApsaW51eC1waHkgbWFpbGluZyBsaXN0CmxpbnV4LXBoeUBsaXN0 cy5pbmZyYWRlYWQub3JnCmh0dHBzOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LXBoeQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 465354F85B6 for ; Tue, 13 Oct 2026 13:00:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791896414; cv=none; b=LJfexY898g6u3/EhYdjOxLB6JOu+NquwDdYxz0qHRg40UjD9XwQBLqeRLKUSyIszEAtOZgGUrEWLKKgGtrvpPCW4m2E8LjtdjelEwMWCJ9EZinbTOUUlqkd77qVBlPc7/gtv+dJTc0M5ZRmhyjwLWs1sZlXhd0vqpaYIZdpii1o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791896414; c=relaxed/simple; bh=/P2aIJYFDVhZABh2wWVTeeJ+G3E85Cdg75nuFvkqR9A=; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type: Date; b=fyWm0Fk5W2BiG9PVJUkonuzEt6u0cT+TFbUrtRYzavXY3Omd2o1Qw4w53OFfg2VcWRQAV2pJ6g3SDdixMuiFLB6UJZ47XZEaxwoLVcCfC3je3CvI1phUYd/87O8SazceCTx72GtNwB0QTx3yjMWBl0cZW4we7+4jY7l4jnyJfgg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=V1xvDhsR; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="V1xvDhsR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C1DDA1F000FF; Tue, 13 Oct 2026 13:00:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791896412; bh=jkn00oKNilqawMytVOgJxaKIXAtfj8HSDkaiQNLRYgI=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=V1xvDhsR8EK8bwdQiFPZqK3arBNNSPIfLZf1Pm4ZPVewADGjyzUVOZg8/w0x26one vCFX4l+ahbDdbWwe90P+fASGoLBFP8LLZw9z8/5ODH0VD1q4nf8D+sVCNSjxL6rUkx nlezNQj1LN0F6QBxvWjJ34JQey9B3G3q6wG8Ht0NluP8QS6HCddKtJF5SmATsc/vlm 7HVpTU7tJ4K9rspY0VbZGr1giJgwCClcKNdhYyzgM94jsNBr6dH0nvqNK7okG4Lzrb HzHZ2boO8Vv08vGAoMAJRANEd+zN52mSTh27Bmsu1fW62l0mPo2O9LChUBz1DvL8XJ hJ/sZDBxzJ9OA== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v1 5/6] drm/rockchip: analogix_dp: Add support for RK3568 Reply-To: sashiko-reviews@lists.linux.dev To: "Damon Ding" Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-phy@lists.infradead.org, robh@kernel.org, conor+dt@kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com In-Reply-To: <20261013124946.1807886-6-damon.ding@rock-chips.com> References: <20261013124946.1807886-1-damon.ding@rock-chips.com> <20261013124946.1807886-6-damon.ding@rock-chips.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 13 Oct 2026 13:00:11 +0000 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [High] rockchip/dp: unchecked NULL pointer dereference on missing GRF pro= perty -- commit 9a6e6f45c854c22f24d403cf8bdab7a0504199b6 Author: Damon Ding drm/rockchip: analogix_dp: Add support for RK3568 The RK3568 eDP controller does not require any GRF configurations, so make the "rockchip,grf" property optional. Also enable the optional avdd-0v9 and avdd-1v8 supplies which power the eDP PHY. > diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gp= u/drm/rockchip/analogix_dp-rockchip.c > --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c > +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c > @@ -320,8 +320,9 @@ static int rockchip_dp_of_probe(struct rockchip_dp_de= vice *dp) > struct device *dev =3D dp->dev; > struct device_node *np =3D dev->of_node; > struct clk *clk; > + int ret; > =20 > - dp->grf =3D syscon_regmap_lookup_by_phandle(np, "rockchip,grf"); > + dp->grf =3D syscon_regmap_lookup_by_phandle_optional(np, "rockchip,grf"= ); > if (IS_ERR(dp->grf)) > return dev_err_probe(dev, PTR_ERR(dp->grf), > "failed to get rockchip,grf property\n"); [Severity: High] Since this changes the lookup to syscon_regmap_lookup_by_phandle_optional(), dp->grf will be NULL when the property is absent, and the IS_ERR() check wi= ll pass. Can this cause a NULL pointer dereference for legacy SoCs (like RK3288, RK3= 399, or RK3588) if the device tree is missing the property? For those older SoCs, the chip_data specifies valid GRF fields. During disp= lay initialization, the driver calls rockchip_grf_field_write(): drivers/gpu/drm/rockchip/analogix_dp-rockchip.c:rockchip_grf_field_write() { if (!field->valid) return 0; mask =3D GENMASK(field->msb, field->lsb); val <<=3D field->lsb; return rockchip_grf_write(grf, field->reg, mask, val); } This forwards the potentially NULL grf pointer to rockchip_grf_write() and eventually to regmap_write(), which dereferences it: drivers/base/regmap/regmap.c:regmap_write() { ... if (!IS_ALIGNED(reg, map->reg_stride)) return -EINVAL; ... } Should probe validate that dp->grf !=3D NULL if the chip type requires it, rather than allowing probe to succeed and causing a kernel oops later? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261013124946.1807= 886-1-damon.ding@rock-chips.com?part=3D5