Re: [PATCH] usb-storage: option_ms: bound probe-time bulk transfers

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] usb-storage: build failure due to missing usb_stor_bulk_transfer_buf_timeout() dependency
--

commit 3551a3904408bdea1ed0fe7ef3aadc1aebde4e98
Author: Lee Yongjun <jun85566@gmail.com>

usb-storage: option_ms: bound probe-time bulk transfers

This commit replaces bulk transfers in the option_ms initialization path with
timeout-aware equivalents to prevent the USB hub worker from hanging
indefinitely if a device stops responding. A 30-second timeout is introduced
for transfers in option_inquiry() and option_rezero().

Link: https://lore.kernel.org/r/20261001123135.38831-1-xy521521@gmail.com/
Link: https://syzkaller.appspot.com/bug?extid=7317196294d50d6e55c3

> diff --git a/drivers/usb/storage/option_ms.c b/drivers/usb/storage/option_ms.c
> index 7c0b05a365543..1f3d984d69326 100644
> --- a/drivers/usb/storage/option_ms.c
> +++ b/drivers/usb/storage/option_ms.c

[ ... ]

> @@ -44,9 +46,9 @@ static int option_rezero(struct us_data *us)
>  		return USB_STOR_TRANSPORT_ERROR;
>  
>  	memcpy(buffer, rezero_msg, sizeof(rezero_msg));
> -	result = usb_stor_bulk_transfer_buf(us,
> -			us->send_bulk_pipe,
> -			buffer, sizeof(rezero_msg), NULL);
> +	result = usb_stor_bulk_transfer_buf_timeout(us, us->send_bulk_pipe,
> +						    buffer, sizeof(rezero_msg), NULL,
> +						    OPTION_MS_PROBE_TIMEOUT);

[Severity: High]
Does this cause a build failure? The new helper function
usb_stor_bulk_transfer_buf_timeout() does not appear to be defined or
declared anywhere in the current tree.

The commit message notes a dependency on a pending v3 series, but without
that series applied, compiling drivers/usb/storage/option_ms.c results in
an implicit function declaration and subsequent linker failure when the
usb-storage driver is enabled. 

Should this patch be held back from the tree until its dependencies are 
merged?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261013132033.4352-1-jun85566@gmail.com?part=1