Re: [PATCH v2 7/7] spi: dt-bindings: cadence: Make XSPI's IRQ line optional - sashiko-bot

From: sashiko-bot@kernel.org
To: "Paul Cercueil" <paul.cercueil@bootlin.com>,
	"Pratyush Yadav" <pratyush@kernel.org>,
	"Michael Walle" <mwalle@kernel.org>,
	"Takahiro Kuwano" <takahiro.kuwano@infineon.com>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Richard Weinberger" <richard@nod.at>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	"Mark Brown" <broonie@kernel.org>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
Cc: "Kees Cook" <kees@kernel.org>, "Tony Luck" <tony.luck@intel.com>,
	"Guilherme G . Piccoli" <gpiccoli@igalia.com>,
	linux-mtd@lists.infradead.org,
	"Bharat Bhushan" <bbhushan2@marvell.com>,
	"Sunil Kovvuri Goutham" <sgoutham@marvell.com>,
	"Tanmay Jagdale" <tanmay@marvell.com>
Subject: Re: [PATCH v2 7/7] spi: dt-bindings: cadence: Make XSPI's IRQ line optional
Date: Tue, 13 Oct 2026 14:20:03 +0000	[thread overview]
Message-ID: <sashiko-outbox-169897@kernel.org> (raw)
In-Reply-To: <20261013141350.189996-8-paul.cercueil@bootlin.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: justifying optional hardware property with driver capability
--

commit d3552de358b2091602e8175c29c60b182ad1aa2a
Author: Tanmay Jagdale <tanmay@marvell.com>

spi: dt-bindings: cadence: Make XSPI's IRQ line optional

The commit makes the 'interrupts' property optional in the Cadence XSPI
binding because the driver can operate in polling mode.

> diff --git a/Documentation/devicetree/bindings/spi/cdns,xspi.yaml b/Documentation/devicetree/bindings/spi/cdns,xspi.yaml
> index 38a5795589de2..dd8d03c07e688 100644
> --- a/Documentation/devicetree/bindings/spi/cdns,xspi.yaml
> +++ b/Documentation/devicetree/bindings/spi/cdns,xspi.yaml
> @@ -43,7 +43,6 @@ properties:
>  required:
>    - compatible
>    - reg
> -  - interrupts

[Severity: Low]
Device tree bindings are intended to describe hardware rather than software
driver capabilities.

The commit message justifies removing this constraint because the driver
"will happily work without an IRQ line registered". Does removing this
constraint based on software capability lead to an inaccurate hardware
description if the interrupt line is always present in the hardware?

Should the justification for making this property optional be based on
hardware instead, such as whether the IRQ is physically omitted or
disconnected on certain boards?

>  
>  allOf:
>    - $ref: spi-controller.yaml#

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261013141350.189996-1-paul.cercueil@bootlin.com?part=7

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/