Re: [PATCH v6 1/7] rust: clk: use 'kernel vertical style' for imports

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] rust: clk: missing trailing // in vertical imports in doctests
--

commit d1e8fb84f14ee05c8bc2b0c2603a25f2c8d23a0f
Author: Daniel Almeida <daniel.almeida@collabora.com>

rust: clk: use 'kernel vertical style' for imports

This commit converts all imports in the clk module to use the kernel 
vertical style. It also drops the Result import since it is provided 
by the prelude.

Link: https://docs.kernel.org/rust/coding-guidelines.html#imports

> diff --git a/rust/kernel/clk.rs b/rust/kernel/clk.rs
> index f04f5c4a03d64..c73fe7c572511 100644
> --- a/rust/kernel/clk.rs
> +++ b/rust/kernel/clk.rs

[ ... ]

> @@ -119,9 +125,11 @@ mod common_clk {
>      /// The following example demonstrates how to obtain and configure a clock for a device.
>      ///
>      /// ```
> -    /// use kernel::clk::{Clk, Hertz};
> +    /// use kernel::clk::{
> +    ///     Clk,
> +    ///     Hertz,
> +    /// };

[Severity: Low]
This isn't a bug, but should this vertical import have a trailing // empty
comment? According to Documentation/rust/coding-guidelines.rst, vertical
imports require a trailing // to prevent rustfmt from collapsing the lines.
It looks like the doc test for Clk::get is missing it here.

>      /// use kernel::device::Device;
> -    /// use kernel::error::Result;
>      ///
>      /// fn configure_clk(dev: &Device) -> Result {
>      ///     let clk = Clk::get(dev, Some(c"apb_clk"))?;

[ ... ]

> @@ -293,9 +301,11 @@ fn drop(&mut self) {
>      /// device. The code functions correctly whether or not the clock is available.
>      ///
>      /// ```
> -    /// use kernel::clk::{OptionalClk, Hertz};
> +    /// use kernel::clk::{
> +    ///     Hertz,
> +    ///     OptionalClk,
> +    /// };

[Severity: Low]
Similarly, should the vertical import in the OptionalClk::get doc test also
include a trailing // comment to match the kernel vertical style guidelines?

>      /// use kernel::device::Device;
> -    /// use kernel::error::Result;
>      ///
>      /// fn configure_clk(dev: &Device) -> Result {
>      ///     let clk = OptionalClk::get(dev, Some(c"apb_clk"))?;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261013-clk-type-state-v6-0-a5e9977b3509@collabora.com?part=1