From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D910751D538 for ; Tue, 13 Oct 2026 22:57:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791932259; cv=none; b=C21VyJ8mKqzj23+dWS4x3vc6avTT6VNKyb1iE4m+Xxc1L0HqG6K2L57I2Ib+fv0Y5by3AaDPeREpWuJVP0DewqXUh7QPlFBBbeVy+h0PMfXzd+ReONH87pV68QG2CuKzqZ8dQFYlLiVPd8pKMHUkXlTfTfKeBOQk8DZGNaYanIs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791932259; c=relaxed/simple; bh=p/1r0cRiOqmNQHo59ZT6X4W3YiYVuRkcdQHsw/WWFVA=; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type: Date; b=OIlQXFhhCqiY0BYR9hwsIwmoo+jtg3yAgcXXDPrnGZ547TgAb7SzrDa0dqPTEw0OqP3AtYLbe/RAEbQMqo53oUKm38cnlzsCR/EmpofG6CG9mez2WWr3ghi7BcwYiL27Fsz+5G5+5bbzckfOf75IxtQEYegbwkaUU30uXMAcQMc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MgFLhfUM; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MgFLhfUM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 184311F000FF; Tue, 13 Oct 2026 22:57:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791932258; bh=/tsBWa/AeIHpWYnSfggb/tcEzc59MfiSDgJMKAguNHg=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=MgFLhfUM1TXGEfGMJsgcAb6Y1wRILjIj+J3R430oMlOvQtyf5Jv0IB+lzvt1e4uzL 67Q2NgzwDZcj0h0Gp+T4ZaD9fgQpqhU9WOBXb6JeIcXDiW/RmANUUDfYQ0h6pl/r4I hsAFKKlxYOd3LPAKeNTyC54ujuxFojj1SrrMesYXyVNqoCUi6IKFL2xce+4dIemMTs G6MjJFNmZLll7yoqdBaXLsVLdEvTrtoUCVBTfMvaHLChoNrsUz/e7sCt7ZqvxZmfgO q+KVRFyMjefBCAo4ERPG6jZrtvjqAE5PcsoFqWN9Ygr1Yn5uKAyTcrdqfg2Tg5EKX0 R3ORV5tNZHeLQ== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH 10/11] drm/amdkfd: Free queue in procfs_queue_type kobject release callback Reply-To: sashiko-reviews@lists.linux.dev To: "Ian Rogers" , "Greg Kroah-Hartman" , "Rafael J . Wysocki" , "Danilo Krummrich" , "Miguel Ojeda" , "Kees Cook" , "Nathan Chancellor" Cc: "Nick Desaulniers" , "Bill Wendling" , "Justin Stitt" , "Jonathan Corbet" , "Madhavan Srinivasan" , "Michael Ellerman" , "Nicholas Piggin" , "Christophe Leroy" , "Nayna Jain" , "Yoshinori Sato" , "Rich Felker" , "John Paul Adrian Glaubitz" , "Viresh Kumar" , "David Teigland" , "Alexander Aring" , "Juergen Gross" , "Stefano Stabellini" , "Oleksandr Tyshchenko" , "Heiko Carstens" , "Vasily Gorbik" , "Alexander Gordeev" , "Christian Borntraeger" , "Sven Schnelle" , "Richard Weinberger" , "Zhihao Cheng" , "Felix Kuehling" , "Alex Deucher" , =?utf-8?b?Q2hyaXN0aWFuIEvDtm5pZw==?= , linux-s390@vger.kernel.org, linux-mtd@lists.infradead.org, dri-devel@lists.freedesktop.org In-Reply-To: <20261013223946.1836757-11-irogers@google.com> References: <20261013223946.1836757-1-irogers@google.com> <20261013223946.1836757-11-irogers@google.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 13 Oct 2026 22:57:36 +0000 Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] sysfs: WARNING in kernfs_remove_by_name_ns due to unconditionall= y deleting uninitialized kobject -- commit a813e5e5e38ff926a8859f22732d8fde3e0ed689 Author: Ian Rogers drm/amdkfd: Free queue in procfs_queue_type kobject release callback This commit adds a release callback to free the struct queue from the kobje= ct release function to prevent a use-after-free, and adjusts the kobject_put() locations accordingly. > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c b/drivers/gpu/drm/a= md/amdkfd/kfd_process.c > --- a/drivers/gpu/drm/amd/amdkfd/kfd_process.c > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process.c [ ... ] > @@ -701,7 +708,6 @@ void kfd_procfs_del_queue(struct queue *q) > return; > =20 > kobject_del(&q->kobj); [Severity: Medium] Can this trigger a kernel warning if sysfs creation fails? If kfd_procfs_add_queue() fails (for example, due to a memory allocation fa= ilure in sysfs), q->kobj.state_in_sysfs remains 0 and q->kobj.sd is null. However, pqm_create_queue() may ignore this sysfs failure and keep the queue operati= onal. Later, when pqm_destroy_queue() calls kfd_procfs_del_queue(), kobject_del()= is called unconditionally. This results in a call chain to __kobject_del() which invokes sysfs_remove_groups() with a null kobj->sd. This eventually propagates to kernfs_remove_by_name_ns(), where a warning is triggered explicitly when its parent argument is null: fs/kernfs/dir.c:kernfs_remove_by_name_ns() { ... if (!parent) { WARN(1, KERN_WARNING "kernfs: can not remove '%s', no directory\n",= name); return -ENOENT; } ... } Should we check if the kobject was successfully added to sysfs (such as che= cking q->kobj.state_in_sysfs) before calling kobject_del()? > - kobject_put(&q->kobj); > } --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261013223946.1836= 757-1-irogers@google.com?part=3D10 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4DC61CC6B15 for ; Tue, 13 Oct 2026 22:57:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=McZ7xN+EtDV2VPnlINpPzbfkotgkk9rZ5mGhIXWRMT8=; b=kseuXIJI1dOuRm EZ8kQL0bZMaPOvUyB4xVUCf7rpppfz+1x0LTtsi+VpWRXM8Qrhstx/nWq/PG4gK/QrIpEIpmjf4aW qraw0nU6MFS+A5lNVuMN9wnVaKy0BMEuSnDddY3ZZFY+//7Azdvqgw8FSZzSnGmuEsZhrRiK3B5rd DxnbPm286r5Wp1G3x0EoqII3m1+TIFXXvZauppekSku4PbpoVZ/kBxix/FJh0KlAihPJwtrf9LMEJ bmJJ815LYvOsYBKzsq8DpcTpDvgw7penpTRv58eJLo8BjZcBzk4+9zdt4lPgWlmjw2qea3auj3ItG paJFenZWWJ7fQOOo8V/A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xGlRF-0000000ECwh-3eKE; Tue, 13 Oct 2026 22:57:41 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xGlRC-0000000ECwW-3uJs for linux-mtd@lists.infradead.org; Tue, 13 Oct 2026 22:57:41 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 7C6F442DDE; Tue, 13 Oct 2026 22:57:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 184311F000FF; Tue, 13 Oct 2026 22:57:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791932258; bh=/tsBWa/AeIHpWYnSfggb/tcEzc59MfiSDgJMKAguNHg=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=MgFLhfUM1TXGEfGMJsgcAb6Y1wRILjIj+J3R430oMlOvQtyf5Jv0IB+lzvt1e4uzL 67Q2NgzwDZcj0h0Gp+T4ZaD9fgQpqhU9WOBXb6JeIcXDiW/RmANUUDfYQ0h6pl/r4I hsAFKKlxYOd3LPAKeNTyC54ujuxFojj1SrrMesYXyVNqoCUi6IKFL2xce+4dIemMTs G6MjJFNmZLll7yoqdBaXLsVLdEvTrtoUCVBTfMvaHLChoNrsUz/e7sCt7ZqvxZmfgO q+KVRFyMjefBCAo4ERPG6jZrtvjqAE5PcsoFqWN9Ygr1Yn5uKAyTcrdqfg2Tg5EKX0 R3ORV5tNZHeLQ== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH 10/11] drm/amdkfd: Free queue in procfs_queue_type kobject release callback To: "Ian Rogers" , "Greg Kroah-Hartman" , "Rafael J . Wysocki" , "Danilo Krummrich" , "Miguel Ojeda" , "Kees Cook" , "Nathan Chancellor" Cc: "Nick Desaulniers" , "Bill Wendling" , "Justin Stitt" , "Jonathan Corbet" , "Madhavan Srinivasan" , "Michael Ellerman" , "Nicholas Piggin" , "Christophe Leroy" , "Nayna Jain" , "Yoshinori Sato" , "Rich Felker" , "John Paul Adrian Glaubitz" , "Viresh Kumar" , "David Teigland" , "Alexander Aring" , "Juergen Gross" , "Stefano Stabellini" , "Oleksandr Tyshchenko" , "Heiko Carstens" , "Vasily Gorbik" , "Alexander Gordeev" , "Christian Borntraeger" , "Sven Schnelle" , "Richard Weinberger" , "Zhihao Cheng" , "Felix Kuehling" , "Alex Deucher" , =?utf-8?b?Q2hyaXN0aWFuIEvDtm5pZw==?= , linux-s390@vger.kernel.org, linux-mtd@lists.infradead.org, dri-devel@lists.freedesktop.org In-Reply-To: <20261013223946.1836757-11-irogers@google.com> References: <20261013223946.1836757-1-irogers@google.com> <20261013223946.1836757-11-irogers@google.com> Date: Tue, 13 Oct 2026 22:57:36 +0000 X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW01lZGl1bV0gc3lzZnM6IFdBUk5J TkcgaW4ga2VybmZzX3JlbW92ZV9ieV9uYW1lX25zIGR1ZSB0byB1bmNvbmRpdGlvbmFsbHkgZGVs ZXRpbmcgdW5pbml0aWFsaXplZCBrb2JqZWN0Ci0tCgpjb21taXQgYTgxM2U1ZTVlMzhmZjkyNmE4 ODU5ZjIyNzMyZDhmZGUzZTBlZDY4OQpBdXRob3I6IElhbiBSb2dlcnMgPGlyb2dlcnNAZ29vZ2xl LmNvbT4KCmRybS9hbWRrZmQ6IEZyZWUgcXVldWUgaW4gcHJvY2ZzX3F1ZXVlX3R5cGUga29iamVj dCByZWxlYXNlIGNhbGxiYWNrCgpUaGlzIGNvbW1pdCBhZGRzIGEgcmVsZWFzZSBjYWxsYmFjayB0 byBmcmVlIHRoZSBzdHJ1Y3QgcXVldWUgZnJvbSB0aGUga29iamVjdApyZWxlYXNlIGZ1bmN0aW9u IHRvIHByZXZlbnQgYSB1c2UtYWZ0ZXItZnJlZSwgYW5kIGFkanVzdHMgdGhlIGtvYmplY3RfcHV0 KCkKbG9jYXRpb25zIGFjY29yZGluZ2x5LgoKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2FtZC9hbWRrZmQva2ZkX3Byb2Nlc3MuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1ka2ZkL2tm ZF9wcm9jZXNzLmMKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGtmZC9rZmRfcHJvY2Vz cy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRrZmQva2ZkX3Byb2Nlc3MuYwpbIC4u LiBdCj4gQEAgLTcwMSw3ICs3MDgsNiBAQCB2b2lkIGtmZF9wcm9jZnNfZGVsX3F1ZXVlKHN0cnVj dCBxdWV1ZSAqcSkKPiAgCQlyZXR1cm47Cj4gIAo+ICAJa29iamVjdF9kZWwoJnEtPmtvYmopOwoK W1NldmVyaXR5OiBNZWRpdW1dCkNhbiB0aGlzIHRyaWdnZXIgYSBrZXJuZWwgd2FybmluZyBpZiBz eXNmcyBjcmVhdGlvbiBmYWlscz8KCklmIGtmZF9wcm9jZnNfYWRkX3F1ZXVlKCkgZmFpbHMgKGZv ciBleGFtcGxlLCBkdWUgdG8gYSBtZW1vcnkgYWxsb2NhdGlvbiBmYWlsdXJlCmluIHN5c2ZzKSwg cS0+a29iai5zdGF0ZV9pbl9zeXNmcyByZW1haW5zIDAgYW5kIHEtPmtvYmouc2QgaXMgbnVsbC4g SG93ZXZlciwKcHFtX2NyZWF0ZV9xdWV1ZSgpIG1heSBpZ25vcmUgdGhpcyBzeXNmcyBmYWlsdXJl IGFuZCBrZWVwIHRoZSBxdWV1ZSBvcGVyYXRpb25hbC4KCkxhdGVyLCB3aGVuIHBxbV9kZXN0cm95 X3F1ZXVlKCkgY2FsbHMga2ZkX3Byb2Nmc19kZWxfcXVldWUoKSwga29iamVjdF9kZWwoKSBpcwpj YWxsZWQgdW5jb25kaXRpb25hbGx5LgoKVGhpcyByZXN1bHRzIGluIGEgY2FsbCBjaGFpbiB0byBf X2tvYmplY3RfZGVsKCkgd2hpY2ggaW52b2tlcwpzeXNmc19yZW1vdmVfZ3JvdXBzKCkgd2l0aCBh IG51bGwga29iai0+c2QuIFRoaXMgZXZlbnR1YWxseSBwcm9wYWdhdGVzIHRvCmtlcm5mc19yZW1v dmVfYnlfbmFtZV9ucygpLCB3aGVyZSBhIHdhcm5pbmcgaXMgdHJpZ2dlcmVkIGV4cGxpY2l0bHkg d2hlbgppdHMgcGFyZW50IGFyZ3VtZW50IGlzIG51bGw6Cgpmcy9rZXJuZnMvZGlyLmM6a2VybmZz X3JlbW92ZV9ieV9uYW1lX25zKCkgewogICAgLi4uCiAgICBpZiAoIXBhcmVudCkgewogICAgICAg IFdBUk4oMSwgS0VSTl9XQVJOSU5HICJrZXJuZnM6IGNhbiBub3QgcmVtb3ZlICclcycsIG5vIGRp cmVjdG9yeVxuIiwgbmFtZSk7CiAgICAgICAgcmV0dXJuIC1FTk9FTlQ7CiAgICB9CiAgICAuLi4K fQoKU2hvdWxkIHdlIGNoZWNrIGlmIHRoZSBrb2JqZWN0IHdhcyBzdWNjZXNzZnVsbHkgYWRkZWQg dG8gc3lzZnMgKHN1Y2ggYXMgY2hlY2tpbmcKcS0+a29iai5zdGF0ZV9pbl9zeXNmcykgYmVmb3Jl IGNhbGxpbmcga29iamVjdF9kZWwoKT8KCj4gLQlrb2JqZWN0X3B1dCgmcS0+a29iaik7Cj4gIH0K Ci0tIApTYXNoaWtvIEFJIHJldmlldyDCtyBodHRwczovL3Nhc2hpa28uZGV2LyMvcGF0Y2hzZXQv MjAyNjEwMTMyMjM5NDYuMTgzNjc1Ny0xLWlyb2dlcnNAZ29vZ2xlLmNvbT9wYXJ0PTEwCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgg TVREIGRpc2N1c3Npb24gbWFpbGluZyBsaXN0Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8vbGludXgtbXRkLwo=