Re: [PATCH v2 1/2] perf build: Support building BPF skeletons with bpf-gcc

[sashiko-bot@kernel.org]

> Support building perf BPF skeletons with bpf-gcc (>= 14.0.0) in addition
> to clang (>= 12.0.1), similar to tools/testing/selftests/bpf/Makefile.
> 
> When building perf with GCC (CC_NO_CLANG=1), prefer bpf-gcc and fall
> back to clang if bpf-gcc is unavailable or too old. When building with
> Clang/LLVM (CC_NO_CLANG=0), prefer clang and fall back to bpf-gcc.
> Explicit command-line overrides via BPF_GCC=... or CLANG=... are
> respected, and setting BPF_GCC= or CLANG= to empty disables that
> compiler.
> 
> In bpf_skel.mak, pass the bpf-gcc flags (-mcpu=v3, -fno-ident,
> -DBPF_NO_PRESERVE_ACCESS_INDEX, -Wno-attributes,
> -D__TARGET_ARCH_$(SRCARCH), and target endianness) and query system
> include paths from $(CC).
> 
> Also update version-ge3 and version-lt3 in tools/scripts/utilities.mak
> to split the two version arguments separately in awk so empty or
> fewer-than-3-component version strings do not shift fields across
> arguments.
> 
> Assisted-by: Antigravity:gemini-3.1-pro
> Signed-off-by: Ian Rogers <irogers@google.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261013231430.2163505-1-irogers@google.com?part=1