Re: [PATCH rdma-next] IB/IPoIB: Cancel normal flush work on device stop

[sashiko-bot@kernel.org]

> From: Carolina Jubran <cjubran@nvidia.com>
> 
> ipoib_ib_dev_flush_normal() can race with ipoib_stop() because the normal
> flush work does not run under RTNL.
> 
> Before commit a77a57a1a22a ("IPoIB: Fix deadlock on RTNL in
> ipoib_stop()"), ipoib_stop() flushed ipoib_workqueue after clearing
> IPOIB_FLAG_ADMIN_UP and before calling ipoib_ib_dev_down(). This ensured
> that any in-flight flush work completed before ipoib_ib_dev_down()
> performed the final clear of IPOIB_FLAG_OPER_UP.
> 
> After that commit removed the workqueue flush to avoid a deadlock with
> workqueue tasks taking RTNL, a normal flush can continue running
> concurrently with ipoib_stop() after IPOIB_FLAG_ADMIN_UP has been
> cleared.
> [ ... ]
> Fixes: a77a57a1a22a ("IPoIB: Fix deadlock on RTNL in ipoib_stop()")
> Reported-by: John Popplewell <john.popplewell@nmc2.ai>
> Signed-off-by: Carolina Jubran <cjubran@nvidia.com>
> Reviewed-by: Cosmin Ratiu <cratiu@nvidia.com>
> Signed-off-by: Edward Srouji <edwards@nvidia.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261014-ipoib-cancel-work-v1-1-6c0faac016b8@nvidia.com?part=1