All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Mikhail Dmitrichenko" <mdmitrichenko@astralinux.ru>
Cc: linux-ext4@vger.kernel.org, tytso@mit.edu
Subject: Re: [PATCH 5.10] ext4: fix out-of-bounds read in ext4_read_inline_dir()
Date: Wed, 14 Oct 2026 16:11:44 +0000	[thread overview]
Message-ID: <sashiko-outbox-171517@kernel.org> (raw)
In-Reply-To: <20261014153817.239-1-mdmitrichenko@astralinux.ru>

> From: Xiang Mei <xmei5@asu.edu>
> 
> commit 9333cc809f0a89e001b814155a6cb8903a6274df upstream.
> 
> ext4_read_inline_dir() can read a dirent header past the end of its inline
> buffer, triggering a slab-out-of-bounds read during getdents64():
> 
>   BUG: KASAN: slab-out-of-bounds in __ext4_check_dir_entry
>   Read of size 2 at addr ffff88800f3dd23c by task exploit/148
>    ...
>    __ext4_check_dir_entry
>    ext4_read_inline_dir
>    iterate_dir
> 
> The dirent payload lives in a buffer of exactly inline_size bytes:
> [ ... ]
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> [ mdmitrichenko: use EXT4_DIR_REC_LEN(1) instead of
>   ext4_dir_rec_len(1, NULL), which does not exist in 5.10; both compute
>   the same minimal dirent length. ]
> Signed-off-by: Mikhail Dmitrichenko <mdmitrichenko@astralinux.ru>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261014153817.239-1-mdmitrichenko@astralinux.ru?part=1


      reply	other threads:[~2026-10-14 16:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-14 15:38 [PATCH 5.10] ext4: fix out-of-bounds read in ext4_read_inline_dir() Mikhail Dmitrichenko
2026-10-14 16:11 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-171517@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=mdmitrichenko@astralinux.ru \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.