Re: [PATCH v3] arm64: dts: qcom: x1e78100-thinkpad-t14s: Add thermal zones for PMICs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] dts: missing #thermal-sensor-cells causes thermal zone registration failure
--

commit fd5ef96fe4a4a5f82c85c0157e689c00a5a97d30
Author: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>

arm64: dts: qcom: x1e78100-thinkpad-t14s: Add thermal zones for PMICs

Add thermal zones for the ThinkPad T14s and describe the board
temperature sensors exposed through the PMK8550 VADC.

> diff --git a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi
> index 0bee2a3d6e7a9..9586421553442 100644
> --- a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi
> +++ b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi
> @@ -502,6 +502,81 @@ platform {
>  			};
>  		};
>  	};
> +
> +	thermal-zones {
> +		backcover-thermal {
> +			critical-action = "shutdown";
> +			thermal-sensors = <&pmk8550_vadc ADC5_GEN3_AMUX1_THM_100K_PU(1)>;

[Severity: High]
Does this setup cause thermal zone registration to fail at boot?

During boot, the thermal framework resolves the thermal-sensors phandle using
of_parse_phandle_with_args(), which expects the target node to have a
#thermal-sensor-cells property. 

Since the target pmk8550_vadc node lacks the #thermal-sensor-cells property,
will the device tree parser return -EINVAL, causing thermal_of_zone_register()
to abort registration for all these newly added thermal zones?

[ ... ]

> @@ -1285,6 +1360,36 @@ usb0_pwr_1p15_reg_en: usb0-pwr-1p15-reg-en-state {
>  	};
>  };
>  
> +&pmk8550_vadc {
> +	channel@144 {
> +		qcom,adc-tm;
> +	};

[Severity: High]
Should this override block include `#thermal-sensor-cells = <1>;`?

Adding the missing property here would allow the thermal framework to
successfully parse and register the thermal zones.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261014193524.5590-1-daniel.lezcano@oss.qualcomm.com?part=1