Re: [PATCH V2] xhci: Reset TI usb controller on xhci shutdown

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] usb: xhci: typo in commit signature and comment formatting
--

commit d01818bc6cd938fdc83cd4a8bea9dbde80b9d813
Author: Wen Xiong <wenxiong@linux.ibm.com>

xhci: Reset TI usb controller on xhci shutdown

This commit introduces a PCI function reset on shutdown for TI xHCI
controllers to ensure they initialize properly in a kexec booted kernel.

> Signed-off-by: Wen Xixong <wenxiong@linux.ibm.com>

[Severity: Low]
This isn't a bug, but there is a typo in the Signed-off-by name (Xixong
instead of Xiong).

> diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> index a8889081ae824..36191639bf430 100644
> --- a/drivers/usb/host/xhci-pci.c
> +++ b/drivers/usb/host/xhci-pci.c

[ ... ]

> @@ -950,6 +952,13 @@ static void xhci_pci_shutdown(struct usb_hcd *hcd)
>  	/* Yet another workaround for spurious wakeups at shutdown with HSW */
>  	if (xhci->quirks & XHCI_SPURIOUS_WAKEUP)
>  		pci_set_power_state(pdev, PCI_D3hot);
> +
> +	/* 
> +	* TI xHCI controllers fail to initialize in a kexec 
> +	* kernel without a PCI function reset
> +	*/

[Severity: Low]
This isn't a bug, but is this block comment introduced in xhci_pci_shutdown
missing the standard leading spaces before the asterisks on the second and
third lines?

> +	if (xhci->quirks & XHCI_RESET_ON_SHUTDOWN)
> +		pci_reset_function_locked(pdev);
>  }

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261014222855.13698-1-wenxiong@linux.ibm.com?part=1