From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5DB133939C; Thu, 15 Oct 2026 01:50:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792029020; cv=none; b=SZBsHR3kNtLc8d1i3QjnKLe/X5mCWhb9VdqlIsOCgcv/PRzTF9h65vBfiqABOkCmjIWRotCmShrKKvtDXtG6Idiy/kHxrFdsx9Frz+oPaOaCIB1rvbX0IkF49yef5KVNz6dy1uabhCYK4tHI3ojCmR8/VlZ1asBGDgmMKktKSmU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792029020; c=relaxed/simple; bh=lqzqa6mXZFZB56ZiAqpMIdWmUh42nRNUKyxJ3d69eCw=; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type: Date; b=ZoYQ+qGDUXB8IPZMwaUpcke0DsQwnUnYPS6IuP//crfevdXkYI5l+sj+OhF2QR7qyleizN7ERRBg23tVsOTqeFnVvf15rwhHWuJMXPJhf/p6Wj0sheqEIMs7nf8/EejeON4Hi1jaD/y3zt6EQnZ0FJckoEV6o58Lpy3RUliNI3Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PGJf06ng; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PGJf06ng" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A73B1F000C4; Thu, 15 Oct 2026 01:50:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792029019; bh=XqCsBBDToclNhntWS7LwgwCgD6io3q7EceQlCXtUiuU=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=PGJf06ngwaQwr3biaCaU9TpAVmbFprp7n3Ipjgw+QnNJyDJ6lP8jJISWbjlWWJsTa R4RnmmLTaQliAuKDYnjo3ypOGMbGxsfj+RMFnYjUcWW3bzl9BaQ5I0esD/h9ePfMHb nRY17QRgTs9OdkABkpahY0OK4HO82/qPvVlZKtB06Mckthp7Vq/FQzBScGiNcbOZmy 2P5NykZAhpS4+7brbXgufHXsK839w8P4xnvYIGRtHHfw+7oSyHH0GDGYx9pxMcL+fW 9Eb+VF+d+U3mHcBgLwxvNNLOUO44ZX5amNIGycT8tAl16/mZ1Xi9XwXYcl6Y9HWqMy 7zXqFugGYiDvw== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v7 06/16] mtd: rawnand: sunxi: select the pattern ID for the current ECC step Reply-To: sashiko-reviews@lists.linux.dev To: "James Hilliard" , "Miquel Raynal" , "Richard Weinberger" , "Vignesh Raghavendra" , "Sebastian Andrzej Siewior" , "Clark Williams" , "Steven Rostedt" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" Cc: "Chen-Yu Tsai" , "Jernej Skrabec" , "Samuel Holland" , "Maxime Ripard" , "Richard Genoud" , "Boris Brezillon" , "Masahiro Yamada" , "Brian Norris" , linux-mtd@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-rt-devel@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20261014-submit-sunxi-nand-vendor-oob-layout-v1-v7-6-5d3fc6ad2da1@gmail.com> References: <20261014-submit-sunxi-nand-vendor-oob-layout-v1-v7-0-5d3fc6ad2da1@gmail.com> <20261014-submit-sunxi-nand-vendor-oob-layout-v1-v7-6-5d3fc6ad2da1@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 15 Oct 2026 01:50:16 +0000 Precedence: bulk X-Mailing-List: linux-rt-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] mtd: rawnand: sunxi: PIO mode overwrites zero pattern with SRAM = garbage -- commit 6c354ef3bc88ac95cdf40b092e5c146de75aa789 Author: James Hilliard Subject: mtd: rawnand: sunxi: select the pattern ID for the current ECC step This commit fixes the pattern-ID register check during ECC exception mode. It updates the correction helper to test the bit corresponding to the current hardware step rather than always checking bit zero, which ensures DMA processing classifies physical all-zero and all-ones data blocks correctly. > diff --git a/drivers/mtd/nand/raw/sunxi_nand.c b/drivers/mtd/nand/raw/sun= xi_nand.c > index 57df88099206a..8256982d1d565 100644 > --- a/drivers/mtd/nand/raw/sunxi_nand.c > +++ b/drivers/mtd/nand/raw/sunxi_nand.c > @@ -1101,7 +1101,7 @@ static int sunxi_nfc_hw_ecc_correct(struct nand_chi= p *nand, u8 *data, u8 *oob, > if (pattern_found & BIT(step)) { > u8 pattern; > =20 > - if (unlikely(!(readl(nfc->regs + NFC_REG_PAT_ID(nfc)) & 0x1))) { > + if (unlikely(!(readl(nfc->regs + NFC_REG_PAT_ID(nfc)) & BIT(step)))) { > pattern =3D 0x0; [Severity: Medium] When the pattern is identified as 0x0, the *erased out parameter remains false. Later in sunxi_nfc_oob_read_batch(), the code checks this boolean and handles PIO mode (!read->dma) by copying directly from SRAM: sunxi_nfc_oob_read_batch() { ... if (erased) { read->has_erased_chunk =3D true; continue; } if (!read->dma) memcpy_fromio(data, nfc->regs + NFC_RAM0_BASE, ecc->size); ... } If scrambling is enabled for a physical all-zero block read in PIO mode, will this memcpy_fromio() overwrite the valid zeros populated in sunxi_nfc_hw_ecc_correct() with descrambled pseudo-random garbage from the SRAM? It appears this regression leaves PIO broken while fixing DMA zero pattern reads. > } else { > pattern =3D 0xff; --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261014-submit-sun= xi-nand-vendor-oob-layout-v1-v7-0-5d3fc6ad2da1@gmail.com?part=3D6 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87FDDCC6B2D for ; Thu, 15 Oct 2026 01:50:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9XtopW4gXkN57B6EztbMFAd0liiTnbWK5c4z0sagJSY=; b=y26sKob5eVQSUC KpaCNAs2zJ6MH+O6D5aB3wv8IzTJxWuxhXdEbHZira4/ooGVyR9u2IxRoAlaPxYkc55AZdIyVfJod eskRviGOnIzQ8hFr1HqvNE44yX5DrVO1XS13Jmb//u0u1qymQWr9/JmBQiWG3vh51yGBXknKgbiCk NN9rJ8zNjPy1KmCKiyTvX/xI35fGBXBx7XlrzGC223yjAvrr3tztoo3LXTC78L9Yqp9g/N3dCq0K4 H4Gmejp1pEFp7jVZ+2PeGlRtZPPXzSNRmJXAt1G/MXc0KiZ+KotjuiLKPUjOruEuEyG2PisTWVIfM 6EOsy9leNAt5rJkfCgKA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xHAbs-0000000Gcg4-299p; Thu, 15 Oct 2026 01:50:20 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xHAbr-0000000Gcfp-3gTn for linux-mtd@lists.infradead.org; Thu, 15 Oct 2026 01:50:19 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 4C30B43265; Thu, 15 Oct 2026 01:50:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A73B1F000C4; Thu, 15 Oct 2026 01:50:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792029019; bh=XqCsBBDToclNhntWS7LwgwCgD6io3q7EceQlCXtUiuU=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=PGJf06ngwaQwr3biaCaU9TpAVmbFprp7n3Ipjgw+QnNJyDJ6lP8jJISWbjlWWJsTa R4RnmmLTaQliAuKDYnjo3ypOGMbGxsfj+RMFnYjUcWW3bzl9BaQ5I0esD/h9ePfMHb nRY17QRgTs9OdkABkpahY0OK4HO82/qPvVlZKtB06Mckthp7Vq/FQzBScGiNcbOZmy 2P5NykZAhpS4+7brbXgufHXsK839w8P4xnvYIGRtHHfw+7oSyHH0GDGYx9pxMcL+fW 9Eb+VF+d+U3mHcBgLwxvNNLOUO44ZX5amNIGycT8tAl16/mZ1Xi9XwXYcl6Y9HWqMy 7zXqFugGYiDvw== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v7 06/16] mtd: rawnand: sunxi: select the pattern ID for the current ECC step To: "James Hilliard" , "Miquel Raynal" , "Richard Weinberger" , "Vignesh Raghavendra" , "Sebastian Andrzej Siewior" , "Clark Williams" , "Steven Rostedt" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" Cc: "Chen-Yu Tsai" , "Jernej Skrabec" , "Samuel Holland" , "Maxime Ripard" , "Richard Genoud" , "Boris Brezillon" , "Masahiro Yamada" , "Brian Norris" , linux-mtd@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-rt-devel@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20261014-submit-sunxi-nand-vendor-oob-layout-v1-v7-6-5d3fc6ad2da1@gmail.com> References: <20261014-submit-sunxi-nand-vendor-oob-layout-v1-v7-0-5d3fc6ad2da1@gmail.com> <20261014-submit-sunxi-nand-vendor-oob-layout-v1-v7-6-5d3fc6ad2da1@gmail.com> Date: Thu, 15 Oct 2026 01:50:16 +0000 X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW01lZGl1bV0gbXRkOiByYXduYW5k OiBzdW54aTogUElPIG1vZGUgb3ZlcndyaXRlcyB6ZXJvIHBhdHRlcm4gd2l0aCBTUkFNIGdhcmJh Z2UKLS0KCmNvbW1pdCA2YzM1NGVmM2JjODhhYzk1Y2RmNDBiMDkyZTVjMTQ2ZGU3NWFhNzg5CkF1 dGhvcjogSmFtZXMgSGlsbGlhcmQgPGphbWVzLmhpbGxpYXJkMUBnbWFpbC5jb20+ClN1YmplY3Q6 IG10ZDogcmF3bmFuZDogc3VueGk6IHNlbGVjdCB0aGUgcGF0dGVybiBJRCBmb3IgdGhlIGN1cnJl bnQgRUNDIHN0ZXAKClRoaXMgY29tbWl0IGZpeGVzIHRoZSBwYXR0ZXJuLUlEIHJlZ2lzdGVyIGNo ZWNrIGR1cmluZyBFQ0MgZXhjZXB0aW9uIG1vZGUuCkl0IHVwZGF0ZXMgdGhlIGNvcnJlY3Rpb24g aGVscGVyIHRvIHRlc3QgdGhlIGJpdCBjb3JyZXNwb25kaW5nIHRvIHRoZQpjdXJyZW50IGhhcmR3 YXJlIHN0ZXAgcmF0aGVyIHRoYW4gYWx3YXlzIGNoZWNraW5nIGJpdCB6ZXJvLCB3aGljaCBlbnN1 cmVzCkRNQSBwcm9jZXNzaW5nIGNsYXNzaWZpZXMgcGh5c2ljYWwgYWxsLXplcm8gYW5kIGFsbC1v bmVzIGRhdGEgYmxvY2tzCmNvcnJlY3RseS4KCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbXRkL25h bmQvcmF3L3N1bnhpX25hbmQuYyBiL2RyaXZlcnMvbXRkL25hbmQvcmF3L3N1bnhpX25hbmQuYwo+ IGluZGV4IDU3ZGY4ODA5OTIwNmEuLjgyNTY5ODJkMWQ1NjUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9tdGQvbmFuZC9yYXcvc3VueGlfbmFuZC5jCj4gKysrIGIvZHJpdmVycy9tdGQvbmFuZC9yYXcv c3VueGlfbmFuZC5jCj4gQEAgLTExMDEsNyArMTEwMSw3IEBAIHN0YXRpYyBpbnQgc3VueGlfbmZj X2h3X2VjY19jb3JyZWN0KHN0cnVjdCBuYW5kX2NoaXAgKm5hbmQsIHU4ICpkYXRhLCB1OCAqb29i LAo+ICAJaWYgKHBhdHRlcm5fZm91bmQgJiBCSVQoc3RlcCkpIHsKPiAgCQl1OCBwYXR0ZXJuOwo+ ICAKPiAtCQlpZiAodW5saWtlbHkoIShyZWFkbChuZmMtPnJlZ3MgKyBORkNfUkVHX1BBVF9JRChu ZmMpKSAmIDB4MSkpKSB7Cj4gKwkJaWYgKHVubGlrZWx5KCEocmVhZGwobmZjLT5yZWdzICsgTkZD X1JFR19QQVRfSUQobmZjKSkgJiBCSVQoc3RlcCkpKSkgewo+ICAJCQlwYXR0ZXJuID0gMHgwOwoK W1NldmVyaXR5OiBNZWRpdW1dCldoZW4gdGhlIHBhdHRlcm4gaXMgaWRlbnRpZmllZCBhcyAweDAs IHRoZSAqZXJhc2VkIG91dCBwYXJhbWV0ZXIgcmVtYWlucwpmYWxzZS4gTGF0ZXIgaW4gc3VueGlf bmZjX29vYl9yZWFkX2JhdGNoKCksIHRoZSBjb2RlIGNoZWNrcyB0aGlzIGJvb2xlYW4KYW5kIGhh bmRsZXMgUElPIG1vZGUgKCFyZWFkLT5kbWEpIGJ5IGNvcHlpbmcgZGlyZWN0bHkgZnJvbSBTUkFN OgoKc3VueGlfbmZjX29vYl9yZWFkX2JhdGNoKCkgewogICAgLi4uCiAgICBpZiAoZXJhc2VkKSB7 CiAgICAgICAgcmVhZC0+aGFzX2VyYXNlZF9jaHVuayA9IHRydWU7CiAgICAgICAgY29udGludWU7 CiAgICB9CgogICAgaWYgKCFyZWFkLT5kbWEpCiAgICAgICAgbWVtY3B5X2Zyb21pbyhkYXRhLCBu ZmMtPnJlZ3MgKyBORkNfUkFNMF9CQVNFLCBlY2MtPnNpemUpOwogICAgLi4uCn0KCklmIHNjcmFt YmxpbmcgaXMgZW5hYmxlZCBmb3IgYSBwaHlzaWNhbCBhbGwtemVybyBibG9jayByZWFkIGluIFBJ TyBtb2RlLAp3aWxsIHRoaXMgbWVtY3B5X2Zyb21pbygpIG92ZXJ3cml0ZSB0aGUgdmFsaWQgemVy b3MgcG9wdWxhdGVkIGluCnN1bnhpX25mY19od19lY2NfY29ycmVjdCgpIHdpdGggZGVzY3JhbWJs ZWQgcHNldWRvLXJhbmRvbSBnYXJiYWdlIGZyb20KdGhlIFNSQU0/CgpJdCBhcHBlYXJzIHRoaXMg cmVncmVzc2lvbiBsZWF2ZXMgUElPIGJyb2tlbiB3aGlsZSBmaXhpbmcgRE1BIHplcm8KcGF0dGVy biByZWFkcy4KCj4gIAkJfSBlbHNlIHsKPiAgCQkJcGF0dGVybiA9IDB4ZmY7CgotLSAKU2FzaGlr byBBSSByZXZpZXcgwrcgaHR0cHM6Ly9zYXNoaWtvLmRldi8jL3BhdGNoc2V0LzIwMjYxMDE0LXN1 Ym1pdC1zdW54aS1uYW5kLXZlbmRvci1vb2ItbGF5b3V0LXYxLXY3LTAtNWQzZmM2YWQyZGExQGdt YWlsLmNvbT9wYXJ0PTYKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpMaW51eCBNVEQgZGlzY3Vzc2lvbiBtYWlsaW5nIGxpc3QKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1tdGQvCg==