Re: [PATCH v2] USB: serial: simple: narrow OWON match to avoid breaking VDS1022

[sashiko-bot@kernel.org]

> A USB_DEVICE() match on VID:PID 0x5345:0x1234 was added to the
> owon_device entry in drivers/usb/serial/usb-serial-simple.c by
> commit 4cc01410e1c1 ("USB: serial: simple: add OWON HDS200 series
> oscilloscope support"). OWON uses this VID:PID across multiple device
> families (HDS, VDS, SDS, PDS), so the broad match makes the
> owon_device driver also claim devices such as the VDS1022.
> 
> While the owon_device entry is equivalent to the generic usbserial
> driver for kernel-space users, the VDS1022 is a headless scope that
> is driven from userspace over libusb (e.g. the florentbr/Owon-VDS1022
> tool), which can no longer claim the interface once a kernel driver
> binds to it. Prior to that commit, no in-kernel driver claimed these
> interfaces.
> 
> The two families can be told apart by their interface descriptors
> despite sharing interface class 5 (Physical): the HDS200 series
> reports subclass 0 and protocol 0, as documented by the HDS272S dump
> (firmware V5.7.1) in that commit's message, while the VDS1022 reports
> subclass 6 and protocol 0x50. Match the full HDS200 interface
> tuple so that the VDS1022 remains unclaimed and stays accessible to
> userspace tools.
> 
> Reported-by: leStoppe <lestoppe@gmail.com>
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=220193
> Tested-by: leStoppe <lestoppe@gmail.com>
> Signed-off-by: Huang Wei <huangwei@kylinos.cn>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261015025456.3927808-1-huangwei@kylinos.cn?part=1