Re: [PATCH 1/2] ASoC: dt-bindings: Add Iron Device MA5311

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: additionalProperties: false with allOf breaks inherited properties
--

commit 28fede9028d5369d7e76bfe368a2b05ad5391a52
Author: Hyunuk Son <hyunuk.son@irondevice.com>

ASoC: dt-bindings: Add Iron Device MA5311
    
Add a Device Tree binding for the Iron Device MA5311 audio codec.

> diff --git a/Documentation/devicetree/bindings/sound/irondevice,ma5311.yaml b/Documentation/devicetree/bindings/sound/irondevice,ma5311.yaml
> new file mode 100644
> index 0000000000000..ae4a13c2981ab
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/irondevice,ma5311.yaml
> @@ -0,0 +1,69 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/irondevice,ma5311.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#

[ ... ]

> +allOf:
> +  - $ref: dai-common.yaml#
> +
> +properties:

[ ... ]

> +required:
> +  - compatible
> +  - reg
> +  - reg-names
> +  - '#sound-dai-cells'
> +
> +additionalProperties: false

[Severity: Low]
Because this schema includes dai-common.yaml# in its allOf block, will
additionalProperties: false incorrectly reject standard DAI properties?

In JSON schema, additionalProperties: false only evaluates explicitly defined
properties in the local properties dictionary, ignoring properties brought in
via a $ref. This causes make dt_binding_check to fail with "additional
property is not allowed" errors when valid common DAI properties are used
in the device tree.

Should this use unevaluatedProperties: false instead, as documented in
writing-schema.rst?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261015060408.128711-1-hyunuk.son@irondevice.com?part=1